Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1156535rda; Mon, 23 Oct 2023 04:36:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IECeUukgc3cWeUmsuPiiOzmi9xMy0F0GtugoNBe51TVUkPUWFL6RdXiOc+koMmBc0+ZJOJX X-Received: by 2002:a05:6a00:150d:b0:68c:69ca:2786 with SMTP id q13-20020a056a00150d00b0068c69ca2786mr6986638pfu.34.1698060965823; Mon, 23 Oct 2023 04:36:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698060965; cv=none; d=google.com; s=arc-20160816; b=NQN6UIE228WwFz79POK89YElKjDYrJ7QUtIAULacqR/U9M7818RcleGVf0hy4OHtWM AvOL10tOGpNwB5DKYpOQQ9qshMi/7jOmhMD3nzGihvL0QhcB0RhX5AKxmRe7SNoBDF0x I7kfGZhZxcFFWyo89GT22Wsdl8AlSTgL4CivFsn1QCYcWWNozXI5XiWCx4CLFNNTMlum HiJKrzh1PIhzc69we5Kic287Z8+Os4LPPNBTnFdlczz+JV1DloxzfAyu+dfgj5+Mvsut uuWlt3gDgDjPIDXSdBvoK280WygmyOzzWYqElINJI7r5M4M2MdLwmBMaGd2E3RAB/d7p 8tBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=USuL46JAPel/bA5kD+t2sR2vM/Cl77pTNAsxFEtWa5k=; fh=1YuZ6yBvXgFODHUGXX8e69MscorgyyWPwTsebgkJnOA=; b=A6sReVLHaz/UoDA1hqSyyAcclW5Qm4mui7LCEY3RcIv/H3DBFld45R+FM8jnaaXKPI 1u7jjr5/OFBmiW0+bFsW8MS8vQsMQPMZtUFmBcZigynj8Lxd9KRf2yFYDUPgKkKTGrKG CCjCakACdsMsSZmC556Pe/Xayss9puOuTBbyz1IJglNMkHdvTAghJsY/EUGU3ZrGXFaE zSWs7JEDDOahPg+lTs2aaDy10hZ44uHGzRizpWsWSeUfYDWmANnQFhSOsrqzAPiLWhKX +dBuW1R62vBxYGxPtKnz225pJguQMhxhREOK40ZtF22KmRYfI9fRbWJV7yoSQ0Kg6hUj OKmA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=QWrKUow+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id v18-20020a634812000000b005859c6d691dsi6291773pga.895.2023.10.23.04.36.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 04:36:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=QWrKUow+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 4B495809926A; Mon, 23 Oct 2023 04:35:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234074AbjJWLf2 (ORCPT + 99 others); Mon, 23 Oct 2023 07:35:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234038AbjJWLf0 (ORCPT ); Mon, 23 Oct 2023 07:35:26 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59C20E8; Mon, 23 Oct 2023 04:35:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698060922; x=1729596922; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=oxQ99Lbr0YPXctAU2ZPK0KvWToc8S5g7FWzgOBc/tco=; b=QWrKUow+jFqrLzXHv4IDTJhzD73Gi6KQ6MlihK4encHmex+ZyJfKy3M9 Wd6/Ip10maDr1TpRaxA7c79xkpIxAzgZxE5seYNdo1Wr5LHD08OiHichq HNeP7iPWLXqzwGTYKkmc+JGsTEcBBFsUHN/jxts78skVdgyWrjHgR/89z wGrmRbyYMVJTJRL64PCXskUwEqGJqeD//sD9I72Es1DpoTAO9x01rPwqo kQ2fPeQRk13IbwtGQ3hCXvzjzdVHjfyzPTlcPC/FBiHdFDzJTA6J9ycB3 +lZmuNdzs5OCubbSnSLmmNDUcAQngY/2lMJyQWnBQjGjLgdblfStt5rIU A==; X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="377193012" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="377193012" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 04:35:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="901779783" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="901779783" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga001.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 04:32:59 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC2) (envelope-from ) id 1qutDF-00000007vGe-48Ha; Mon, 23 Oct 2023 14:35:13 +0300 Date: Mon, 23 Oct 2023 14:35:13 +0300 From: Andy Shevchenko To: Raag Jadav Cc: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com, mika.westerberg@linux.intel.com, mark.rutland@arm.com, will@kernel.org, linux@roeck-us.net, Jonathan.Cameron@huawei.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com Subject: Re: [PATCH v2 2/6] pinctrl: intel: use acpi_dev_uid_match() for matching _UID Message-ID: References: <20231023053530.5525-1-raag.jadav@intel.com> <20231023053530.5525-3-raag.jadav@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231023053530.5525-3-raag.jadav@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 23 Oct 2023 04:35:42 -0700 (PDT) On Mon, Oct 23, 2023 at 11:05:26AM +0530, Raag Jadav wrote: > Convert manual _UID references to use the standard ACPI helper. > Signed-off-by: Raag Jadav > Reviewed-by: Andy Shevchenko As I asked you, please drop this one. It has a hidden logic that is not aligned with acpi_dev_hid_uid_match(). Or revert to your v1 I assume. -- With Best Regards, Andy Shevchenko