Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
MIME-Version: 1.0
References: <20231019195752.62692-1-edson.drosdeck@gmail.com>
In-Reply-To: <20231019195752.62692-1-edson.drosdeck@gmail.com>
From:   Ulf Hansson <ulf.hansson@linaro.org>
Date:   Mon, 23 Oct 2023 13:42:20 +0200
Message-ID: <CAPDyKFoeuVHu+Rt7kg1zbz1oFW8aCkQJ5swCbmSnA_Xrhx0eYw@mail.gmail.com>
Subject: Re: [PATCH] mmc: block: Use octal for file permissions
To:     Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
Cc:     adrian.hunter@intel.com, CLoehle@hyperstone.com,
        brauner@kernel.org, axboe@kernel.dk,
        victor.shih@genesyslogic.com.tw, f.fainelli@gmail.com,
        asuk4.q@gmail.com, yibin.ding@unisoc.com,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, 19 Oct 2023 at 21:58, Edson Juliano Drosdeck
<edson.drosdeck@gmail.com> wrote:
>
> Octal permissions are preferred as stated in
> Documentation/dev-tools/checkpatch.rst. Replace symbolic permissions
> with octal permissions when creating the files.
>
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>

Thanks for your patch!

Replacing symbolic permissions with octal permissions makes sense to
me. However, I don't want one patch per line that needs to be changed.

Instead, please go over all the files in drivers/mmc/core and fix all
of them in one patch. Another patch can be done for
drivers/mmc/hosts/*

Kind regards
Uffe

> ---
>  drivers/mmc/core/block.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
> index b5b414a71e0b..edb653d8fbfa 100644
> --- a/drivers/mmc/core/block.c
> +++ b/drivers/mmc/core/block.c
> @@ -2916,7 +2916,7 @@ static void mmc_blk_add_debugfs(struct mmc_card *card, struct mmc_blk_data *md)
>
>         if (mmc_card_mmc(card)) {
>                 md->ext_csd_dentry =
> -                       debugfs_create_file("ext_csd", S_IRUSR, root, card,
> +                       debugfs_create_file("ext_csd", 0400, root, card,
>                                             &mmc_dbg_ext_csd_fops);
>         }
>  }
> --
> 2.39.2
>