Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1160024rda; Mon, 23 Oct 2023 04:43:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIWy4L6YyZe+z+9H82IzazMoyE54sUYZwrZ4thMTKJ/0m9HmoXK2fxDAvXYTv8GNvrbToe X-Received: by 2002:a17:902:dac9:b0:1bb:30c5:835a with SMTP id q9-20020a170902dac900b001bb30c5835amr8667065plx.7.1698061412825; Mon, 23 Oct 2023 04:43:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698061412; cv=none; d=google.com; s=arc-20160816; b=U0bTY+wvr5Z0vfVDeiTheUPhzmosQPUry9od9ggwZx+spMOPSv+0ZRxc0zLWIxh6Zl tyOvftrkKvtYpMd917h0s7fZrt5C5uOGgLdQmW11afB3xKsGYmlkcGedID7d3yRlee7H sl7aQTdQHAa8bAQrQMi2Rh1gv0+cd43yVhTfogm3yIh5tfJa9t3MBN/mk95c5q6fwDIo st3dgAsVmRweda0TXRSewTmnq9+YPFHu07y/PZppU3nbrtWudgNASfI1S6Oc6dKTgLi4 fzsCiQQ6XDUWXGKj85HtkkieruO4pMCT2qHWA3+bIyP8mySlzU9RWkg5uK9l+m+QiReV cyqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DYsy36lZl2hcQoQRVuMmMM5BU5/FV/B7lnXvVJ/Ws5I=; fh=1bEoSeKlOGurhvnSi2pzdW2AZoMRq2idIHm15GAQso0=; b=XH7Eq7V2kbfZenwIFkfEEkzoTxVKVbvFff//7zplIq9RESB0siljBhxB0yA89QMWGx DTSRhko+lFuxLAJe7QgvmD4ovfwvxUSPk2Mlgo3LNrwqnwRq0aQp0A72k5luKBSEQQVS 8Sy6m+ciAhZed6JxwU4XcyfqhO3UGvG1EXaMW5q+zljqlBn+iQO7NcVOu0LbJhiNEZHe 7633PlxmHdVaL1xW8PU6lKro6NNuK2rz5OnsaElU3tbFptJtLOBPlRnjyyY5vrGyOQrv 19sAgeDBqnzzR5whgxv29Tn6OVAw0yoO2C5zNC1r9PwOhnZuQo9z/BI2piJSIU6zOcQ1 QMhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qRsxBcAH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id w21-20020a170902d3d500b001c20db25108si6072648plb.41.2023.10.23.04.43.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 04:43:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=qRsxBcAH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 6776780B1FA5; Mon, 23 Oct 2023 04:43:30 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234380AbjJWLnG (ORCPT + 99 others); Mon, 23 Oct 2023 07:43:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234426AbjJWLmz (ORCPT ); Mon, 23 Oct 2023 07:42:55 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4A87B1988; Mon, 23 Oct 2023 04:42:47 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDD08C433CC; Mon, 23 Oct 2023 11:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698061367; bh=IVU3t0iDHy73gQKGWr58nGN8gjjzyZ0qQW4gTPxs1TE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qRsxBcAHTgPlC0WnbTt5lDRHuok4TIcsDHwGh4r/jA4xKmKEQ64Zi7NKhY6yBeKZx JblXZSw3KodhUOCJ0EUJpmP+FtnIwTt8EFQnl+sLoWMl2kjcVmGx6AfcFX7rnItBNK SZduZrvsoPuMegTSygMeXwGIdu/DVWshTS+OZNss= From: Greg Kroah-Hartman To: stable@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Andrew Donnellan , Alexander Potapenko , Xiaoke Wang , Andrew Morton Subject: [PATCH 5.10 006/202] lib/test_meminit: fix off-by-one error in test_pages() Date: Mon, 23 Oct 2023 12:55:13 +0200 Message-ID: <20231023104826.776616509@linuxfoundation.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231023104826.569169691@linuxfoundation.org> References: <20231023104826.569169691@linuxfoundation.org> User-Agent: quilt/0.67 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 23 Oct 2023 04:43:30 -0700 (PDT) 5.10-stable review patch. If anyone has any objections, please let me know. ------------------ From: Greg Kroah-Hartman commit efb78fa86e95 ("lib/test_meminit: allocate pages up to order MAX_ORDER") works great in kernels 6.4 and newer thanks to commit 23baf831a32c ("mm, treewide: redefine MAX_ORDER sanely"), but for older kernels, the loop is off by one, which causes crashes when the test runs. Fix this up by changing "<= MAX_ORDER" "< MAX_ORDER" to allow the test to work properly for older kernel branches. Fixes: 2a1cf9fe09d9 ("lib/test_meminit: allocate pages up to order MAX_ORDER") Cc: Andrew Donnellan Cc: Alexander Potapenko Cc: Xiaoke Wang Cc: Cc: Andrew Morton Signed-off-by: Greg Kroah-Hartman --- lib/test_meminit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/lib/test_meminit.c +++ b/lib/test_meminit.c @@ -86,7 +86,7 @@ static int __init test_pages(int *total_ int failures = 0, num_tests = 0; int i; - for (i = 0; i <= MAX_ORDER; i++) + for (i = 0; i < MAX_ORDER; i++) num_tests += do_alloc_pages_order(i, &failures); REPORT_FAILURES_IN_FN();