Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1165550rda; Mon, 23 Oct 2023 04:55:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGWyjrMfwhFHOnXPBKOxJrBqpA6+65HPzlK1gKVGqdomLCXYQg+Fz5IDc4JNelTvCLI32Aj X-Received: by 2002:a17:90a:41:b0:27d:d9d:c54d with SMTP id 1-20020a17090a004100b0027d0d9dc54dmr8057795pjb.34.1698062149979; Mon, 23 Oct 2023 04:55:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698062149; cv=none; d=google.com; s=arc-20160816; b=Zz0CrgBD20UvDoevbvNSQV0RObatWiiCB/54+VMdqwIbM3fnmttHpTjLKQ88Utf3nZ M+spkuOr2YC6IJQT1EmQ3oCAwuG8l+po2vr3LhraD92jzjlPVVhq66ShTwBXqxpmy9TK Fs5D79FxtgJY5j1QPm2mSHohOwiFWXXSddmfJYGFJSA6uTVZDkBE55gVnbGbfdyyaDBw 9ccVWLN6qCFQcpEt6ypkjnXiJwFAjFvE5C/yh2BBO+hrrcRgO5so6XcjG6hHjQwlAQ4u GPNnAZ+xG5aAp0OSdhCIxgjyNBDuIdRf5O2lHGikNkatabt+Bn1ouJttCjGJAu6LHear bh8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=JtQC8qqDz0rI1hIlefVh9KNcstU30xrZRWGiXS84F7o=; fh=51i87zNlNN4evVtgzXwKWM9O7dN+qMfuAlKQPFTJKnw=; b=uZCoa9h26Lf7j6HQtmiOXVeORHIVjZrhcTpCO6ZAYkSohxCUEgD6HePTI+vd642NgI IRx8RO+rnbDHbvUOhsEIfQcpqNwuCrb6xIFqU5giIC5RuhXqTVqku949LnuTb2U1XWos PYvI/l6CPqNk/8awhgQmhuf/qSNUhmuwqnfwSxdlbsFfXwR5jXSYOs+IO2vZGDXcFJTF Rwt+f0aQ14uODoHI7r7k0z0EOss3cJVT87DLhkriYwfT+DySCmj62BBIXCPuTFRQJSOg WoB7zLhrnHX0zsBRVJOldbVYy4LCqeFJ9TexhALaWjaGYklcg8b5Ygbim6efgsAuBNZs 9MuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="CboYAmM/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id f2-20020a17090a700200b0027d11201a11si8543828pjk.170.2023.10.23.04.55.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 04:55:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="CboYAmM/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 44D1C8068967; Mon, 23 Oct 2023 04:55:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234231AbjJWLza (ORCPT + 99 others); Mon, 23 Oct 2023 07:55:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234201AbjJWLz2 (ORCPT ); Mon, 23 Oct 2023 07:55:28 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69F89F5; Mon, 23 Oct 2023 04:55:26 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A99BDC433C9; Mon, 23 Oct 2023 11:55:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698062126; bh=QmL2n3u+Alr84E1Gw8kq6qtlkqPDghDn12S47YzShJE=; h=From:To:Cc:Subject:Date:From; b=CboYAmM/OqCQ2/1wE5prPGQSgk1mT+KLZqUT8Mq34t97GOdYLJBKWwiqL6ZFgIpuv c2sEkI6AZb3dRseyfKz5CAx9ka4jRO232X3z7KJEW3/ZU/02hLm71i8QhvUSu/lBJE N8StwgXNHY4krOFbwILM6Ow7uwqGPmrX3ctPzEZeS2QzFZNaC+Ih6KeojzlpDQ4L0x RW1GZ3oQ4CKPF8pM4brt/WpoHNDzNeSzy26WBYM5ZJP6iSw4Jno/d9GB0WWS63PSen Psz5ulowqnUQFZimJRiy64G6+g0xsBcVinXwAsBdwlQpXYK2PArlB6fmSfc4jRGcSF gerq9C04NDoqg== From: Arnd Bergmann To: Kevin Tian , Joao Martins Cc: Arnd Bergmann , Yishai Hadas , Jason Gunthorpe , Shameer Kolothum , Alex Williamson , Brett Creeley , Shixiong Ou , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] vfio: mlx5, pds: add IOMMU_SUPPORT dependency Date: Mon, 23 Oct 2023 13:55:03 +0200 Message-Id: <20231023115520.3530120-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 23 Oct 2023 04:55:37 -0700 (PDT) From: Arnd Bergmann Selecting IOMMUFD_DRIVER is not allowed if IOMMUs themselves are not supported: WARNING: unmet direct dependencies detected for IOMMUFD_DRIVER Depends on [n]: IOMMU_SUPPORT [=n] Selected by [m]: - MLX5_VFIO_PCI [=m] && VFIO [=y] && PCI [=y] && MMU [=y] && MLX5_CORE [=y] There is no actual build failure, only the warning. Make the 'select' conditional using the same logic that we have for INTEL_IOMMU and AMD_IOMMU. Fixes: 33f6339534287 ("vfio: Move iova_bitmap into iommufd") Signed-off-by: Arnd Bergmann --- drivers/vfio/pci/mlx5/Kconfig | 2 +- drivers/vfio/pci/pds/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vfio/pci/mlx5/Kconfig b/drivers/vfio/pci/mlx5/Kconfig index c3ced56b77876..c23815c486a75 100644 --- a/drivers/vfio/pci/mlx5/Kconfig +++ b/drivers/vfio/pci/mlx5/Kconfig @@ -3,7 +3,7 @@ config MLX5_VFIO_PCI tristate "VFIO support for MLX5 PCI devices" depends on MLX5_CORE select VFIO_PCI_CORE - select IOMMUFD_DRIVER + select IOMMUFD_DRIVER if IOMMUFD help This provides migration support for MLX5 devices using the VFIO framework. diff --git a/drivers/vfio/pci/pds/Kconfig b/drivers/vfio/pci/pds/Kconfig index fec9b167c7b9a..6091e11f0e521 100644 --- a/drivers/vfio/pci/pds/Kconfig +++ b/drivers/vfio/pci/pds/Kconfig @@ -5,7 +5,7 @@ config PDS_VFIO_PCI tristate "VFIO support for PDS PCI devices" depends on PDS_CORE && PCI_IOV select VFIO_PCI_CORE - select IOMMUFD_DRIVER + select IOMMUFD_DRIVER if IOMMUFD help This provides generic PCI support for PDS devices using the VFIO framework. -- 2.39.2