Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
MIME-Version: 1.0
References: <20231023115646.3573494-1-arnd@kernel.org>
In-Reply-To: <20231023115646.3573494-1-arnd@kernel.org>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Mon, 23 Oct 2023 14:00:42 +0200
Message-ID: <CAMRc=MdoRWn_grWoKWagAi11S=mZ9RbP673L77a+qfN_8oTBcg@mail.gmail.com>
Subject: Re: [PATCH] hte: tegra194: add GPIOLIB dependency
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Dipen Patel <dipenp@nvidia.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>, timestamp@lists.linux.dev,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 23, 2023 at 1:57=E2=80=AFPM Arnd Bergmann <arnd@kernel.org> wro=
te:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The driver started calling into a few interfaces that are part of GPIOLIB=
 and
> don't have stub implementations otherwise:
>
> drivers/hte/hte-tegra194.c: In function 'tegra_hte_line_xlate':
> drivers/hte/hte-tegra194.c:424:48: error: implicit declaration of functio=
n 'gpio_device_get_base'; did you mean 'gpio_device_get_desc'? [-Werror=3Di=
mplicit-function-declaration]
>   424 |                 line_id =3D desc->attr.line_id - gpio_device_get_=
base(gs->gdev);
>       |                                                ^~~~~~~~~~~~~~~~~~=
~~
>       |                                                gpio_device_get_de=
sc
>
> Add a Kconfig dependency to only allow building when this is defined.
>
> Fixes: dc850faa28ee0 ("hte: tegra194: don't access struct gpio_chip")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/hte/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hte/Kconfig b/drivers/hte/Kconfig
> index 083e67492bf2e..641af722b555d 100644
> --- a/drivers/hte/Kconfig
> +++ b/drivers/hte/Kconfig
> @@ -17,6 +17,7 @@ if HTE
>  config HTE_TEGRA194
>         tristate "NVIDIA Tegra194 HTE Support"
>         depends on (ARCH_TEGRA_194_SOC || COMPILE_TEST)
> +       depends on GPIOLIB
>         help
>           Enable this option for integrated hardware timestamping engine =
also
>           known as generic timestamping engine (GTE) support on NVIDIA Te=
gra194
> --
> 2.39.2
>

Thanks. None of the new interfaces are "consumer" APIs and are not
meant to have stubs so depending on GPIOLIB is correct here.

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>