Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
From:   "Drewek, Wojciech" <wojciech.drewek@intel.com>
To:     Shinas Rasheed <srasheed@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "hgani@marvell.com" <hgani@marvell.com>,
        "vimleshk@marvell.com" <vimleshk@marvell.com>,
        "Gallen, Erwan" <egallen@redhat.com>,
        mschmidt <mschmidt@redhat.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "horms@kernel.org" <horms@kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Veerasenareddy Burru <vburru@marvell.com>,
        Sathesh Edara <sedara@marvell.com>,
        Eric Dumazet <edumazet@google.com>
Subject: RE: [PATCH net-next 1/3] octeon_ep: remove dma sync in trasmit path
Thread-Topic: [PATCH net-next 1/3] octeon_ep: remove dma sync in trasmit path
Thread-Index: AQHaBaaCzcrb+QRMCk2jP0Wj9GkRKrBXRMrg
Date:   Mon, 23 Oct 2023 12:02:31 +0000
Message-ID: <MW4PR11MB5776017470E5871819D93D5BFDD8A@MW4PR11MB5776.namprd11.prod.outlook.com>
References: <20231023114449.2362147-1-srasheed@marvell.com>
 <20231023114449.2362147-2-srasheed@marvell.com>
In-Reply-To: <20231023114449.2362147-2-srasheed@marvell.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kAyZLvyt3Zi7PUsm2kJdExA2jDfuZFtf6Tl+TGVRVeJl1uuicD9Be69PIgOz?=
 =?us-ascii?Q?AgyX8RNcxRO0bVGC7yEf94+Ps9DStfcMsVIbNxffXiSDDdt4TZmIPuOwz5oa?=
 =?us-ascii?Q?0a8jQDb8/LG6JdpNYiB+0wKCHNH93nLVUuDceNdyIQ8wSR1gm0xKFnGfUgnc?=
 =?us-ascii?Q?ZRFz9HedNYzCxu9hZRZMJeGldq7YqwvSpuFqQgZkx7YjmSLqNVRTQ6sY3kT5?=
 =?us-ascii?Q?Kedm91njKofAVXEuN8nUPzsMl+DiVh/k8y88KBiNzisC3+eGjBDDBW5+vEZ2?=
 =?us-ascii?Q?OvX9KWvdbBuRSC1ySXrmi6vp2QlQiGgsWkXlACq0XMkBmg9PtCpVU3uE+xxF?=
 =?us-ascii?Q?hED+4MCau5xXHbXuWYJlEROYTF2Xm2sM94yE123mO6LICCpjISuvWMG6UzrJ?=
 =?us-ascii?Q?YEzfRj+L5RDZuNqQ4FPfxJL3N15mKn+w62zYnihgTMvvQxc0XclLp7W/MLJO?=
 =?us-ascii?Q?bWcMPSXJrEGjFPjVik0aLXogJ6Mg49PhB7q7DG7d+6j825gb6gjBkc++qa0+?=
 =?us-ascii?Q?AZzseplKVea9srf9Yo+XA8lih1kPO/FllMZyAR76lhbD1TSpr/jMZJyLcAUX?=
 =?us-ascii?Q?tb8VefmN2AdDxsuhmWoxGuIFNTJLWNx/Wb7Htxm7NpYAYs2kXsfkKT7CEk6h?=
 =?us-ascii?Q?JHpX+w7PjVYQ0wn2jqRABTAU/n6mfM1pGFD3wL5J5/mlsMbrsiXPaaHCq2km?=
 =?us-ascii?Q?eUi3y8yvrUVRcKeo+GSUyUkG9O5oc/ZDvi7IVm7Og2GBhhkNURb9OLx9AXQZ?=
 =?us-ascii?Q?cQAlgTxcfJzldOewGxRhW6icfXpa8Rzpz/uO5fxXZ/Rux/rigkitk5BEufjG?=
 =?us-ascii?Q?ZDzEufgDrE5a65OMw0bXrt79qdG1/lifJCVQTRBBQpcpMWNPxMmH9gqSLSgv?=
 =?us-ascii?Q?E7pzB6MABzUr27vEtGrlR9n5qpgQ5/+iyVuAzQM7vFnIf7Yek73pS/xyC4RE?=
 =?us-ascii?Q?ksTLWF4M5XYIODv/8uQtCTfGFvKZs6yYpCatmZQecwL4cjpOA3819OUlkOab?=
 =?us-ascii?Q?Jw/uMZAE5rzoJMy2d82vv71RSIWIf7541ar6X2dytRdBWmb1pS459mS/TBxY?=
 =?us-ascii?Q?m8SDt1UyixK82JV7l4TSWbBpJbJcqiJhFMYIAt+PpNMBbAPjS2rhpKsCaWJQ?=
 =?us-ascii?Q?71dYY0J4GCrt/NwHKo8gqt9ThNFPxhBTNchSogPRAtT086W51tQgoPrVFPSY?=
 =?us-ascii?Q?rNxzM1CSvODYQRTee54pF7FhC0rmYw85VcNjemc0wWUZUPFr/99FGs2YhBcx?=
 =?us-ascii?Q?3zDswizITv3SG5kOAoT7YpMws0AkQE2FUAAHWcPVIvbBktG95ah5Y5FOo9ND?=
 =?us-ascii?Q?hxW29t4xHYbomDugdc/35ZwEK8VaaxioE0x+W1W+jCkqK2de4yk+G8xNYceI?=
 =?us-ascii?Q?YhG4EKRPkeU1JA8NbTogriXOlJV6gORuZeXZUW2sm7LdTn0t3Cp1Gf1e8lMr?=
 =?us-ascii?Q?ee2K4iVjBU/lTSC+0ag3THOUM9cOXuODK0xi4JmHCoAoKh8pF7T+uCfFL4q6?=
 =?us-ascii?Q?bf0xv311OC4KR/60VLaIF3LtsVrZjSTsSWvWOXUY5xdLSCWhuPm74nFK8d6v?=
 =?us-ascii?Q?Khy7Q7MbA8qmr/3E2clcz/f+uH4LE25eKyuV4eRt?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f529d658-7feb-40a7-e9c7-08dbd3bfef62
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2023 12:02:31.1382
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0/TrKOJGzc4XN8/Nf0c7/VI1tPugIw+MC/PXTvVZfjIE2CWqYqqPqYJHLBbrjW9WWEUXUVrmJugyJquozh7ZXS3QsBw0OUvcIfWXLnK1pPQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8151
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 23 Oct 2023 05:02:48 -0700 (PDT)


> -----Original Message-----
> From: Shinas Rasheed <srasheed@marvell.com>
> Sent: Monday, October 23, 2023 1:45 PM
> To: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: hgani@marvell.com; vimleshk@marvell.com; Gallen, Erwan <egallen@redha=
t.com>; mschmidt <mschmidt@redhat.com>;
> pabeni@redhat.com; horms@kernel.org; kuba@kernel.org; davem@davemloft.net=
; Shinas Rasheed <srasheed@marvell.com>;
> Veerasenareddy Burru <vburru@marvell.com>; Sathesh Edara <sedara@marvell.=
com>; Eric Dumazet <edumazet@google.com>
> Subject: [PATCH net-next 1/3] octeon_ep: remove dma sync in trasmit path
>=20
> Cleanup dma sync calls for scatter gather
> mappings in trasmit path
>=20
> Signed-off-by: Shinas Rasheed <srasheed@marvell.com>

Hi Shinas,

The commit msg only says what changed without justification.
What is the reasoning behind those changes?

> ---
>  drivers/net/ethernet/marvell/octeon_ep/octep_main.c | 7 -------
>  1 file changed, 7 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/driver=
s/net/ethernet/marvell/octeon_ep/octep_main.c
> index 552970c7dec0..bf1e376a4232 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> @@ -869,9 +869,6 @@ static netdev_tx_t octep_start_xmit(struct sk_buff *s=
kb,
>  		if (dma_mapping_error(iq->dev, dma))
>  			goto dma_map_err;
>=20
> -		dma_sync_single_for_cpu(iq->dev, tx_buffer->sglist_dma,
> -					OCTEP_SGLIST_SIZE_PER_PKT,
> -					DMA_TO_DEVICE);
>  		memset(sglist, 0, OCTEP_SGLIST_SIZE_PER_PKT);
>  		sglist[0].len[3] =3D len;
>  		sglist[0].dma_ptr[0] =3D dma;
> @@ -891,10 +888,6 @@ static netdev_tx_t octep_start_xmit(struct sk_buff *=
skb,
>  			frag++;
>  			si++;
>  		}
> -		dma_sync_single_for_device(iq->dev, tx_buffer->sglist_dma,
> -					   OCTEP_SGLIST_SIZE_PER_PKT,
> -					   DMA_TO_DEVICE);
> -
>  		hw_desc->dptr =3D tx_buffer->sglist_dma;
>  	}
>=20
> --
> 2.25.1
>=20