Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Date:   Mon, 23 Oct 2023 09:04:18 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        Joao Martins <joao.m.martins@oracle.com>
Cc:     Kevin Tian <kevin.tian@intel.com>, Arnd Bergmann <arnd@arndb.de>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Brett Creeley <brett.creeley@amd.com>,
        Shixiong Ou <oushixiong@kylinos.cn>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: mlx5, pds: add IOMMU_SUPPORT dependency
Message-ID: <20231023120418.GH691768@ziepe.ca>
References: <20231023115520.3530120-1-arnd@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231023115520.3530120-1-arnd@kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rDMwCOi1jhL4nuzV+pu5rHROVcAfLNI1tkCneiCBON71pU3r9nmz/4OMDDtN?=
 =?us-ascii?Q?sHcR00HR9aza3ITYgkRHQ8PebQv1GG3AJLixX9X7iGhnPVCNWHiumBk2YwMb?=
 =?us-ascii?Q?+46YvpG0RgZ7XlkoaYUay/WK0kDxXKGOiN3tMMs3bEgq8a9Pd1RTFjUScofO?=
 =?us-ascii?Q?CF1De5FJb1zxL+pgKtGlWRQ/bwW0wERnlOrsFj7pi1UWz/G7uv6p2indUU5h?=
 =?us-ascii?Q?rQ2Ps0xWZAnDCb1vGJY27j5bZ+oxgvijuR7ivQ3TelGJCbXHXdpkDoTx8J9W?=
 =?us-ascii?Q?5VpPWq9atrl8FRW4WkZ5FJF+NthTjSYNr2pV3Nf+Vos+y07PJY8Df5VcaH6N?=
 =?us-ascii?Q?shoyPTWKBCwIA7P79TBpHCzKrgk2hRdue3EjhsI3HbNFpcqvDQONYJQeqZk1?=
 =?us-ascii?Q?8ssPz9rO3SBOeLUkqf6rFdVGu1Sr4c+pjRpjZIEPVYB4NpMwOlpfGAVTys6B?=
 =?us-ascii?Q?hohwZbAVzo+rXKKFYVWujHhyngw8cjaaOiRMUK8z28ztT8cuGltdUwRiysN3?=
 =?us-ascii?Q?qlFb+GttIQTXB9+hfxkRowoG70nzU8zn7xk8qP7uJCAVpSkG2ygBXsRTofLM?=
 =?us-ascii?Q?A0PQ8e853e9PyiPkClls53rXwzTyCmnFE7P0Ds+kymlhNM/7H3fWQLQzzTiq?=
 =?us-ascii?Q?HXAcxefc0VZeIyKnzNDSV5Avi5fznb6jTFVWvK7l8QEzdEfQJI/CbEJ6X3xM?=
 =?us-ascii?Q?GmV16Yygj8zqYCEFBdifEDV+7RwhiIK4FcMCE1r0mZII0bY+wz3z5W6rC9XG?=
 =?us-ascii?Q?WKxDY7oJreEEceiaL/8wwWvSwgEt0zGibKyE6JykIthwHqqDJvw0KaPiTcmd?=
 =?us-ascii?Q?O4bfhMydCUodkupQZroroiBQ8ULFes3lJMcrMSy2kSk20NE3DOTQDST5WVlw?=
 =?us-ascii?Q?hBZl9NW8W1ydfewMFRvHlukxIXHhgNlPxDBZYcl5wD1KFKST0aVXuYF00RCm?=
 =?us-ascii?Q?OK/kdf9hokP5c/aA+CxDimj76ZbBkVSb3TU+s8Ve1bE3JvOV3AyGc2vEDw0O?=
 =?us-ascii?Q?/SlkkNgKoQXbnfxr4wr1GCLbHRPlYpQ368WPHhiQqYSjf82Q5ywNC2scCasl?=
 =?us-ascii?Q?1YijR2vBPgE/WNITZ7JGxc02JnaIbgIHPpgLDAUYeCDXRxJV0sie9sRklJiD?=
 =?us-ascii?Q?7ITfPuxkak6RC447/wLlvC1y8kkxj/IbfvRMiJaAO9d7byNBqEuDI+cdwIbq?=
 =?us-ascii?Q?od7+NhqW+Qy/ME5CzqmBB4bFsRv34cllS+scGCqQGoeyka2/TvdqO1SzJnX+?=
 =?us-ascii?Q?VlMK5igQba1ZH/3sKrPOrY0910Y+ZwroUODC35kfYApxDPQs+xo6A0KKMNAK?=
 =?us-ascii?Q?i4z/JCLPvGuE2cNyXl+Eh+Yo4akRo9aahJY8hgiRlD95DWxVd0OukA9OsRUq?=
 =?us-ascii?Q?rbpYL0EMEi2bTRr9eL9afOnn8qQY8qB/nFKhKbWF+GBfK5X1Ela+Lr3HUKii?=
 =?us-ascii?Q?9K4fwwd84eI8lUs8+EAqaFzCkR3bRLTcAZRttNktZtN6WLlK2sMu9gaWJvU/?=
 =?us-ascii?Q?Z0ayBXj+y0DGnpayCIJxfHmnlpxNDF/B3jwk06PGUU5A64oOiMwy3qi5N9sp?=
 =?us-ascii?Q?m8sIxg8KmV5oT+6vrss=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cad0be06-de6a-40f6-14a2-08dbd3c03076
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 12:04:20.5733
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: N4spnyah2pEwZsy+AZthJeKJWhhgEquULjeMi1foStEClpDiee8fwx1yC3C3fqN7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5217
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 23 Oct 2023 05:04:39 -0700 (PDT)

On Mon, Oct 23, 2023 at 01:55:03PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Selecting IOMMUFD_DRIVER is not allowed if IOMMUs themselves are not supported:
> 
> WARNING: unmet direct dependencies detected for IOMMUFD_DRIVER
>   Depends on [n]: IOMMU_SUPPORT [=n]
>   Selected by [m]:
>   - MLX5_VFIO_PCI [=m] && VFIO [=y] && PCI [=y] && MMU [=y] && MLX5_CORE [=y]
> 
> There is no actual build failure, only the warning.
> 
> Make the 'select' conditional using the same logic that we have for
> INTEL_IOMMU and AMD_IOMMU.
> 
> Fixes: 33f6339534287 ("vfio: Move iova_bitmap into iommufd")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/vfio/pci/mlx5/Kconfig | 2 +-
>  drivers/vfio/pci/pds/Kconfig  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

But this isn't the logic this wants, it wants to turn on
IOMMUFD_DRIVER if MLX5_VFIO_PCI is turned on.

I think it means IOMMUFD_DRIVER should be lifted out of the
IOMMU_SUPPORT block somehow. I guess just move it into the top of
drivers/iommu/Kconfig?

Jason