Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Mon, 23 Oct 2023 13:09:11 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Stephan Gerhold <stephan.gerhold@kernkonzept.com>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        Stephan Gerhold <stephan@gerhold.net>
Subject: Re: [PATCH RFC 1/2] regulator: core: Disable unused regulators with
 unknown status
Message-ID: <80307316-f55e-4540-9c5f-655844c3b3f4@sirena.org.uk>
References: <20231004-reg-smd-unused-v1-0-5d682493d555@kernkonzept.com>
 <20231004-reg-smd-unused-v1-1-5d682493d555@kernkonzept.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="SPN+lB5wKEJ80DqE"
Content-Disposition: inline
In-Reply-To: <20231004-reg-smd-unused-v1-1-5d682493d555@kernkonzept.com>
Precedence: bulk


--SPN+lB5wKEJ80DqE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Oct 04, 2023 at 04:17:17PM +0200, Stephan Gerhold wrote:

> Instead of -EINVAL we could also use a different return code to indicate
> the initial status is unknown. Or maybe there is some other option that
> would be easier? This is working for me but I'm sending it as RFC to get
> more feedback. :)

The more normal thing here would be -EBUSY I think - -EINVAL kind of
indicates that the operation will never work while in reality it could
possibly work in future.  Though for the RPMH it's not really the case
that it ever supports readback, what it does is have it's own reference
counting in the driver.  Rather than doing this we should probably have
logic in the core which sees that the driver has a write operation but
no read operation and implements appropriate behaviour.

--SPN+lB5wKEJ80DqE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmU2YmcACgkQJNaLcl1U
h9DG1wf+NXfFlCEiYLkBH4eo1ZKPyDHhg/GfUj6L8qCoftmrX4MX5dd5FNe8MCOY
w+ikBTafNI0VXvZrRy6Hi/b6iUK7LSB3teuJn0ppE5gXUmKpdzm09W9Rmh4GPMva
SFkIgiYXL6ou15043YVm/h22qnISmsdgejTjDkocjhGLShocTS1h3wNDSLl5XdrX
lFLJXxZHrxGu2KXvMNZDozkG4z8AbYOoN3M2hDOLk1lC0vEr/ZaIQYnR4Oqp8n1p
SH3kG+TeIP91UeC7HXV25hiUwHximvgImM6sL9BtNkHAthrv5GGaeBAIwLrXLzIU
uW4/pT3PRGlB6jtuNqlGKx3e4NMa/A==
=Y0WM
-----END PGP SIGNATURE-----

--SPN+lB5wKEJ80DqE--