Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
From:   "Drewek, Wojciech" <wojciech.drewek@intel.com>
To:     Shinas Rasheed <srasheed@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "hgani@marvell.com" <hgani@marvell.com>,
        "vimleshk@marvell.com" <vimleshk@marvell.com>,
        "Gallen, Erwan" <egallen@redhat.com>,
        mschmidt <mschmidt@redhat.com>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "horms@kernel.org" <horms@kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Veerasenareddy Burru <vburru@marvell.com>,
        Sathesh Edara <sedara@marvell.com>,
        Eric Dumazet <edumazet@google.com>
Subject: RE: [PATCH net-next 2/3] octeon_ep: implement xmit_more in transmit
Thread-Topic: [PATCH net-next 2/3] octeon_ep: implement xmit_more in transmit
Thread-Index: AQHaBaZ1ZUHfo9uwG02p7XdCLNoTULBXRlyA
Date:   Mon, 23 Oct 2023 12:13:42 +0000
Message-ID: <MW4PR11MB57766788EBB4D99302002A7FFDD8A@MW4PR11MB5776.namprd11.prod.outlook.com>
References: <20231023114449.2362147-1-srasheed@marvell.com>
 <20231023114449.2362147-3-srasheed@marvell.com>
In-Reply-To: <20231023114449.2362147-3-srasheed@marvell.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QwOJ6aDNUv/BwC0OdUwKeCR4paZ8hpw4zCwkGWcGVvJRTC9dedu8fTgfXevP?=
 =?us-ascii?Q?YEbo4ADqxeW1jjP3gHEiE3jj9pK6eKeunu7dgRkYU5fqJTMerNDQOnfsGa6j?=
 =?us-ascii?Q?vV1IVzyz9nb35jPaVnz8TNlbzurCbURGvvNdEyMyEzvo+dZ2MId9bB1EuIjo?=
 =?us-ascii?Q?QeJKjCGel0TvUziMhtP+xbikHI1g/L+vGRcDSL/e09UtdwyHZ8CA0/SpBS1t?=
 =?us-ascii?Q?O2lsR4SwyiZpUlJBcKLVPq6o7uf27B8fvUGq6FoHxiA/qS5yBpLq3jjrTq3J?=
 =?us-ascii?Q?1svdKWoOmvIUNJ+7oxGH15JZeA/No6ro4/mEceUEFhViFz6jASK5sOzPQChg?=
 =?us-ascii?Q?EDkkG3EsX9TNKdne/fv58IWQd+YT8qTMpPtlt6DzO48LJDdYDozznq9PjltH?=
 =?us-ascii?Q?JxhEFJfZsYNs0ms6j5K1Q7ncdGCrzKToYPtWzAqxy0WRIxkKFvX7XJX/v4fU?=
 =?us-ascii?Q?fbKg+oOVSiMazq8kPoulOVKu8aRTf3eEaxI0xELRnyrbgcJN117f1vG38M+y?=
 =?us-ascii?Q?GqRM5tghXdg5EoTZUN6j0k+6Aszs0Dg/M67S9CGM1rITdiYRbQyYDcgKpQ+y?=
 =?us-ascii?Q?yZd93ZU18fbkpQdtGzRXadkROJHm7LceLm11/fOJax4pV+kBhvn81vlePG5c?=
 =?us-ascii?Q?+6kpErVj/5LBVoqyrc0JoRJ26K8kDZboC3tIhtWofjUq/zmCxQ81F4jVOY+2?=
 =?us-ascii?Q?s99WmM8dCveD7jCBXcIrdkzvlejzmQ4v+4yWJMtUvI0N9/7Mta5H/n8bL9zU?=
 =?us-ascii?Q?iR2pFRreUaRl0HKspimwwP2dY5VXlc9b2zCejXI60S7H01Qug73BNfnpIcMP?=
 =?us-ascii?Q?U7qk9U+kz8mlIChqTFBraKUjEa/osmUl0GMxi3GKxCZGv3wkcEAgB90LWiPW?=
 =?us-ascii?Q?fQ9IpMXKo7N/Xswc7MQ61SX7pp4nuJnyFOKmmnHJoS7dfe/D1Wt5wY0lFp7U?=
 =?us-ascii?Q?c2OcshKWaTpIa1dd1JtHWO1sGCugsbB39EJzogPp65KA5QHw4cOqGhr4+PbM?=
 =?us-ascii?Q?ZA5Dnng74r9o34vaoYjhqAhkJkumvq4CrkFup1m09CvGZHCEIV6juzAhra3r?=
 =?us-ascii?Q?pBM6wiC650uXatAOHmVOlFGzO77quAkA1hofSAMt1gvbyssypnGKBWUuWywY?=
 =?us-ascii?Q?ow9SNX7F52eAoq3EjCHUNXypNInRn0yTkV7lzvudk4m/8SOxZdRC6jdCcGoF?=
 =?us-ascii?Q?npM8Kc8exCX5aUh/5My61oonNDqbRLVIx5iHcq7GUOuHT0EnJzyFZpH9fp6X?=
 =?us-ascii?Q?8VvnQbI/WjrKgwu8KLMlhHxNOwaoj5Fu0AeWR4R8iaDX9TTLz/lJXqsXQ0mi?=
 =?us-ascii?Q?GX3pUoEOMVDiI9BkJ4vQb+UBr7qBrjSxqYWX2v7fi4Bp0rwMQ97obGuNtp/F?=
 =?us-ascii?Q?14XY2e6Hdlt48UAWwz8u1ZpR/PpCRbaBYfnP3Z9ItP94ixN9k77IVRUG01kH?=
 =?us-ascii?Q?3usN8xWiyoc6DfovOrbDJknhfufSEFeJ42t+qm35m8E+xYE7o/az3wtZPsjH?=
 =?us-ascii?Q?ee9VWazxmPoilrp/0HBCSCWXAg0sng02tXjOwJfCRT/SD16Sv/DI13h6Iqkp?=
 =?us-ascii?Q?BHeStA2Wc8a//OakXmCq/SCfbVYPImpD9YkFMH9U?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: aab151da-4c23-444a-d70b-08dbd3c17f92
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2023 12:13:42.5207
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lA1w9Lqxa1F+dSks0E40eeOHFePTRkYw7iKFI6WMWObZ4a45GFKR7daqu4B/xHtUEWUVbS4RPIB6LYky+6rcDxifcyuGiPKut4/e2ngO7X0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5813
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 23 Oct 2023 05:14:04 -0700 (PDT)


> -----Original Message-----
> From: Shinas Rasheed <srasheed@marvell.com>
> Sent: Monday, October 23, 2023 1:45 PM
> To: netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: hgani@marvell.com; vimleshk@marvell.com; Gallen, Erwan <egallen@redha=
t.com>; mschmidt <mschmidt@redhat.com>;
> pabeni@redhat.com; horms@kernel.org; kuba@kernel.org; davem@davemloft.net=
; Shinas Rasheed <srasheed@marvell.com>;
> Veerasenareddy Burru <vburru@marvell.com>; Sathesh Edara <sedara@marvell.=
com>; Eric Dumazet <edumazet@google.com>
> Subject: [PATCH net-next 2/3] octeon_ep: implement xmit_more in transmit
>=20
> Adds xmit_more handling in tx datapath for octeon_ep pf.

Imperative mode is preferred :)
Besides that:
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>=20
> Signed-off-by: Shinas Rasheed <srasheed@marvell.com>
> ---
>  .../ethernet/marvell/octeon_ep/octep_config.h |  2 +-
>  .../ethernet/marvell/octeon_ep/octep_main.c   | 19 +++++++++++++++----
>  2 files changed, 16 insertions(+), 5 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_config.h b/driv=
ers/net/ethernet/marvell/octeon_ep/octep_config.h
> index 1622a6ebf036..ed8b1ace56b9 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep/octep_config.h
> +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_config.h
> @@ -15,7 +15,7 @@
>  /* Tx Queue: maximum descriptors per ring */
>  #define OCTEP_IQ_MAX_DESCRIPTORS    1024
>  /* Minimum input (Tx) requests to be enqueued to ring doorbell */
> -#define OCTEP_DB_MIN                1
> +#define OCTEP_DB_MIN                8
>  /* Packet threshold for Tx queue interrupt */
>  #define OCTEP_IQ_INTR_THRESHOLD     0x0
>=20
> diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c b/driver=
s/net/ethernet/marvell/octeon_ep/octep_main.c
> index bf1e376a4232..730443ba2f5b 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_main.c
> @@ -818,6 +818,7 @@ static netdev_tx_t octep_start_xmit(struct sk_buff *s=
kb,
>  	struct octep_iq *iq;
>  	skb_frag_t *frag;
>  	u16 nr_frags, si;
> +	int xmit_more;
>  	u16 q_no, wi;
>=20
>  	q_no =3D skb_get_queue_mapping(skb);
> @@ -892,18 +893,28 @@ static netdev_tx_t octep_start_xmit(struct sk_buff =
*skb,
>  	}
>=20
>  	netdev_tx_sent_queue(iq->netdev_q, skb->len);
> +
> +	xmit_more =3D netdev_xmit_more();
> +
>  	skb_tx_timestamp(skb);
>  	atomic_inc(&iq->instr_pending);
> +	iq->fill_cnt++;
>  	wi++;
>  	if (wi =3D=3D iq->max_count)
>  		wi =3D 0;
>  	iq->host_write_index =3D wi;
> +	if (xmit_more &&
> +	    (atomic_read(&iq->instr_pending) <
> +	     (iq->max_count - OCTEP_WAKE_QUEUE_THRESHOLD)) &&
> +	    iq->fill_cnt < iq->fill_threshold)
> +		return NETDEV_TX_OK;
> +
>  	/* Flush the hw descriptor before writing to doorbell */
>  	wmb();
> -
> -	/* Ring Doorbell to notify the NIC there is a new packet */
> -	writel(1, iq->doorbell_reg);
> -	iq->stats.instr_posted++;
> +	/* Ring Doorbell to notify the NIC of new packets */
> +	writel(iq->fill_cnt, iq->doorbell_reg);
> +	iq->stats.instr_posted +=3D iq->fill_cnt;
> +	iq->fill_cnt =3D 0;
>  	return NETDEV_TX_OK;
>=20
>  dma_map_sg_err:
> --
> 2.25.1
>=20