Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1186106rda; Mon, 23 Oct 2023 05:27:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJNZEeRbnR41RQoZo3k+zvClr3p3VBP7to7qIqLH+MhBwqh7K8R5aCWdKeR+E32MJcQYfr X-Received: by 2002:a17:90a:1917:b0:27d:b4a4:2d87 with SMTP id 23-20020a17090a191700b0027db4a42d87mr6736077pjg.1.1698064060789; Mon, 23 Oct 2023 05:27:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698064060; cv=none; d=google.com; s=arc-20160816; b=mjUHehxDyh6wa4d6WtFOFMp/uIVpEhin7/thllbkrT8QBqIrXzJhHq6RDEucup3Hc2 YJxA4Tr7gmh2l44L9hh/wkCusWDyvZ6c9cZi2Yq0N+RqTkHD0579eVlvbGplnCngg65z 5hp+6gIzLClG82RkbNtB1RzbpZqgBOckdaId52Z3sOHpuKo3VdlsTrb4Wzxej2OWlYWq RCpyj+Ft7mKaL9oPbXlUccNDZiOgMTsIBVqgeUSFvALsdqFJPjHMGgmB3fdLDlwZgDuI 9fGokyRdca0LYRYWkfiJK+x9uf2JShXyHs81mzhIEHqXdSb8St2OTdIlBOY0y522a4Ui ax6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=I7n2wPfYbkOR4KALU85bgAy+YFw+vS3fxWh1WcwTU1s=; fh=vZfb3O80gXx+GWahWnKknQMjJZuXMRkYD83JzxokXDU=; b=rRuGo3nM4OKhxdtWP25ptwMbCm1uiecRqjDCd/OsPZHLpKQGy+FpTicFJRo3oj50mm lsdmHvzbogUUpgbwojX5WxYViiOjNa2goOgqVC7EolhvoPLQ/Aoj/3HTS201XoWpQnwJ uQVMheHSeXzbjne5k1chvygiFIrNcymxowwe5PAQpn6VRYEMjJvSJiLu2I5ewy7kpqkW ggbqZjJboqz6C5vji70xtHDA1IFQwkxCiWJmUNHWQHv3yPgbxY1bST1RbDqaV18xMeJq IEYbCjiR1bH2Ya5isKlNSPmuwkRpHUDaEJJokmXfnMZ1Z54QmGSYpGhxfCiwt/b/dlQ9 F5dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=byT2dQKw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id l19-20020a170902d35300b001ca7af18a99si6052460plk.564.2023.10.23.05.27.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 05:27:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=byT2dQKw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 8EECF80408DF; Mon, 23 Oct 2023 05:27:39 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231668AbjJWM1h (ORCPT + 99 others); Mon, 23 Oct 2023 08:27:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55016 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbjJWM1g (ORCPT ); Mon, 23 Oct 2023 08:27:36 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3C75FD; Mon, 23 Oct 2023 05:27:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C07D3C433C8; Mon, 23 Oct 2023 12:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1698064053; bh=Xp7fzzJQf8eXvhJSrsZLSWle47TqztytXWqSnLv99rM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=byT2dQKwYWhtzx2BDkCplAtpYbiDfYz/JV/dnQa49Kq4+kJpVstynSBMyR9/Kf6To NHXOvxc+DjZUM6e0PAmipBej82Nl5/yOylNYjN3f13u7VuQDm77qZwCjMQ/NvL/p0p 3xKFjglcKAYSRNmmRkA8cfw+34Jhe6HPTeuVi80I= Date: Mon, 23 Oct 2023 14:27:30 +0200 From: Greg KH To: Florian Eckert Cc: Eckert.Florian@googlemail.com, jirislaby@kernel.org, pavel@ucw.cz, lee@kernel.org, kabel@kernel.org, u.kleine-koenig@pengutronix.de, m.brock@vanmierlo.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-leds@vger.kernel.org Subject: Re: [PATCH v5 2/2] leds: ledtrig-tty: add new line mode evaluation Message-ID: <2023102320-princess-issuing-be13@gregkh> References: <20231023094205.2706812-1-fe@dev.tdt.de> <20231023094205.2706812-3-fe@dev.tdt.de> <2023102341-jogger-matching-dded@gregkh> <7e8860574413505c314bdfd0f3e10188@dev.tdt.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7e8860574413505c314bdfd0f3e10188@dev.tdt.de> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 23 Oct 2023 05:27:39 -0700 (PDT) On Mon, Oct 23, 2023 at 02:15:55PM +0200, Florian Eckert wrote: > > Again, I thought we had rx/tx already? If not, how was that controlled > > today? > > It could not be controlled! The LED flashed when data where transferred. > This was the only function that the trigger supported. Ok, then maybe this needs to be a bit longer of a series. One that does the "tx/rx" feature, as that is needed today, and will be the more complex one, and then one-per-line-setting that you want to apply. That should make it much easier to review overall, right? thanks, greg k-h