Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Date:   Mon, 23 Oct 2023 13:32:27 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     chengming.zhou@linux.dev
Cc:     cl@linux.com, penberg@kernel.org, rientjes@google.com,
        iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, vbabka@suse.cz,
        roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, pcc@google.com,
        tytso@mit.edu, maz@kernel.org, ruansy.fnst@fujitsu.com,
        vishal.moola@gmail.com, lrh2000@pku.edu.cn, hughd@google.com,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Chengming Zhou <zhouchengming@bytedance.com>
Subject: Re: [RFC PATCH v2 1/6] slub: Keep track of whether slub is on the
 per-node partial list
Message-ID: <ZTZn23OzQfAm6epp@casper.infradead.org>
References: <20231021144317.3400916-1-chengming.zhou@linux.dev>
 <20231021144317.3400916-2-chengming.zhou@linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231021144317.3400916-2-chengming.zhou@linux.dev>
Precedence: bulk

On Sat, Oct 21, 2023 at 02:43:12PM +0000, chengming.zhou@linux.dev wrote:
> +++ b/include/linux/page-flags.h
> @@ -478,6 +478,8 @@ PAGEFLAG(Active, active, PF_HEAD) __CLEARPAGEFLAG(Active, active, PF_HEAD)
>  	TESTCLEARFLAG(Active, active, PF_HEAD)
>  PAGEFLAG(Workingset, workingset, PF_HEAD)
>  	TESTCLEARFLAG(Workingset, workingset, PF_HEAD)
> +	__SETPAGEFLAG(Workingset, workingset, PF_HEAD)
> +	__CLEARPAGEFLAG(Workingset, workingset, PF_HEAD)

This makes me nervous.  The __ versions can only be used when there are
guaranteed to be no other accesses to the flags.  It's never going to
be the case that we want code to call __folio_set_workingset().

_Assuming_ that it's safe to use the non-atomic flag setting, I'd
rather see this done as ...

static inline void slab_set_node_partial(struct slab *slab)
{
	__folio_set_workingset(slab_folio(slab));
	__set_bit(PG_workingset, folio_flags(slab_folio(slab), 0));
}