Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <a16758d6-964d-4e46-9074-4d155f9b3703@oracle.com>
Date:   Mon, 23 Oct 2023 13:37:28 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] vfio: mlx5, pds: add IOMMU_SUPPORT dependency
Content-Language: en-US
To:     Jason Gunthorpe <jgg@nvidia.com>, Arnd Bergmann <arnd@kernel.org>
Cc:     Kevin Tian <kevin.tian@intel.com>, Arnd Bergmann <arnd@arndb.de>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Brett Creeley <brett.creeley@amd.com>,
        Shixiong Ou <oushixiong@kylinos.cn>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231023115520.3530120-1-arnd@kernel.org>
 <20231023120418.GH691768@ziepe.ca>
From:   Joao Martins <joao.m.martins@oracle.com>
In-Reply-To: <20231023120418.GH691768@ziepe.ca>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mk9wVndyVlVpaW5Ha2JhNzNJTENzdjBDYmQwWE9oV1ZpZU9uRWxSUXZvWWVV?=
 =?utf-8?B?RnNGMVJMRnArY202MFNaeDVkUXY0WVNXbG5qc0VPUFc3NUg0Q2RZUjZ2ZzV4?=
 =?utf-8?B?R2s4Q0R0NWxWNGp1dnBUR3lqR3NHbm1NbjZLbzI0NHdoMGNaRUJMNmNRNkNm?=
 =?utf-8?B?TUt5ZCt4QmxyS3g5NUJyeitxR2p6bTluSUd4NWVPYkNzazN0UmZ0NHMrMDdm?=
 =?utf-8?B?K055ZmYyMVBUanJ6MHh1VkxBL3lhV0paTHduNzBzTmg1SkJadEdGYlJuSUlZ?=
 =?utf-8?B?U05ZT3ZqL1BjTW9jMGFweWY2enZqTS9OQzVJSGxVL1UwOVFTUmxXN1dxVHNT?=
 =?utf-8?B?YlVZcHU3VFNncTQyVDBubHQ2ZWtHYTk4TWt2bDFCMndMb1Q1T3VoNjUydFFr?=
 =?utf-8?B?bWVpRkQzN09rOHN2eE02Qkg1ZlRZblV4TWZDcyt1MTd4Vm1aRVZhbmJ0ams1?=
 =?utf-8?B?NkQzaHZIekxET1IySU9qNWNwZ1ViK1ZKRGRPR3EvU3I5WnJzcDlXWTNDaXVH?=
 =?utf-8?B?ZHpWMUFzS2NxUVJQMFI5ei9NcjcvMnNIanNTaGVoTnBvRFdyTStOWkgyU0RV?=
 =?utf-8?B?eUhoZUZoQ2FuczZUVEJ3K3RPNy9BMkR4clMrcVM3OUQrMG5rQlJKbXl5TjRR?=
 =?utf-8?B?clp5RjljbjliaHRta0ZxUlRlVW5tdjFac1BOUnB4OXI0MnprU0NBTU0xRE9L?=
 =?utf-8?B?cnBWbTd3b0djK1hiRmZJNHNNbmFMRmNpTytzVkRwMlRURzVjc1FFckJlRVVt?=
 =?utf-8?B?Qkg1eTQrZ3p5UmVReUZpbldHazZMK0NLZHozZWVCcmNXak16SUxpeEVuNG15?=
 =?utf-8?B?SjJvMU5nY0VGMUl6Y2ZMYUNPclV1bWNtMGdidEx1ZGxzckEycDhlMkdQbGlI?=
 =?utf-8?B?ZWtzOE52bzVIT05zZEQwYWNBdkJqWHdPTXNmODdNMnRYYUxQMU5MRkhONENo?=
 =?utf-8?B?MnM3L0FzZ05xT3hMaE9Qd0Y0TFRsQ3ZpV1BBUWluenJTVTJMTUNxRjREZzRT?=
 =?utf-8?B?ZVBEb1I4Z3dzbUVzdCtNR1lLRS9VRWxHcEhDNWtqSHNWa2svQUtUQmZZb1lz?=
 =?utf-8?B?K2duTmhXZ1Jlc09VdjE2bnBsRm9TQWkwanpQbHM3V0FJQzZTRkt0SkJxTDdS?=
 =?utf-8?B?d29rZzZXTXAzbk0rS2FUc2Z3WFN3cGwwZVppekdSV2EvcnZwaFpzSXM0b0hx?=
 =?utf-8?B?QWZHZGdNWnZqTE8rMWNrK2dzakpubkNjSFQ5RHRxOXZQUnFwSkRqNU1NVjZx?=
 =?utf-8?B?aGRjRmVWNUw4QVpyU3psNlhMOFM1OFg5TXh4and4TXA0SlZ6Y05YUlVsYUVP?=
 =?utf-8?B?YUFVTnBlNkVvWmpYSzhHanJuMEhuVko1akN3MERORi8zUExSZmNBSVJSZGo3?=
 =?utf-8?B?bDJIa1NLZEpBZklrTVB5b3BPZ1ovNHZJZDB0bC9nN2Rrb29rQkdNb0xGVHND?=
 =?utf-8?B?SjlVWWUzdTYwZjZxRER6ZTY5OS96Y09ybVZEanZQUms5eHphSmNuM1BjaGVW?=
 =?utf-8?B?VGtvaXJHV29NaFpjNm90TWpydWQ5bTdzVitXd3VrQ00vSnVhdFFsNGcxa2I0?=
 =?utf-8?B?YVdCaXZPSDNzU3RSWmVyZFFZeDBxdGlIR01OTnNEM0lmYWJMZ1BqL0s0QVpR?=
 =?utf-8?B?RkJmN0prM2YydHN3b1krQVB4NTVFclhSK0RoTHI0VkRSRVVUdGpKYjhONDBS?=
 =?utf-8?B?cyszS1B5ZUM0OGYxV0NHZkRuK1hRYnFqbitzVFFON0FiQVl6OS95bFBudm5O?=
 =?utf-8?B?bmFCUTdFTkZ5aE5yVUhNRjBmdXBGUUpYSmhOcHBWbzQrcDFmL2w3QjJXeXN4?=
 =?utf-8?B?ZHVSaUlIQzBjaHdXTkFSZzZKMlgzcng2WmRnSEdaNzNQTE5Pd0R0RDFUNUxo?=
 =?utf-8?B?RjlVNzVnOGxjeWtVY0JES2I4SEVTK0lJM0tKRnpRd2dOODZXVjUxdE9KTU9V?=
 =?utf-8?B?VUxFT1VSMlpGaE9MeSsyeGk4Zy84ZmJ4RzRNYXpjb2xIWGN4b2txVmpDb3JW?=
 =?utf-8?B?cE5SYXh5OHFyZW9lcVNYVGdtcmJ5TEhLMGV2MHVPbEFUV3hacFJFNkJNbFIx?=
 =?utf-8?B?dzJnTUk3QlpyUXFiUks3UUwrTXpHWldwd0JEeDRsOHhwY3ZqTWJTYTNoVGUy?=
 =?utf-8?B?bFAyeStDSFN0ZkdZYzhFbm9iczF2ZTMxb3FDZzluZU9EOTkveWVBK0cvMGIz?=
 =?utf-8?B?dkE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?ZlBPaG9JVVd4ZG9YSHBqdEdkeWQ2eGtuTDR2NU9SWk9wR2FwVUNGS2ZDS1Nj?=
 =?utf-8?B?aHJ5N3hTS0RKSFViYlIrdTNLUWs3cVRJZzdManV2aFhlRHVtRkRkM0VZeTJH?=
 =?utf-8?B?Z2Q0ejdxWTFTTUl5ZmZ1eHBlSEFucVRMd285M0dhWHhweXdqUnVMOXdXWVZa?=
 =?utf-8?B?Y0NaSGdSQS9ua29rVWxLS0YwVGxKU3NjQW1rbVRwUnRYUGhSRkMzbU5EWHRJ?=
 =?utf-8?B?czhzT3Bjdng4aE16VGV0VUc2NnVaZU5FNG1ETXRweDZJbmtIZUk5cThDYUtG?=
 =?utf-8?B?MDFpbWlnbGtJVmU4R3JCaHJMY3M0MHFkRGJ5Z2JkY3RGRE0xWWFINnZIdWpa?=
 =?utf-8?B?bjZtTmgzQWFTV3JVRVFGT2h5ZndFV1padVNhcVhtcDdGdDNHSElNWmtzQllK?=
 =?utf-8?B?T1NIV0xrandWVVRwc28zSDVtdmErL2lmMEtydmJlVHRQRGdvcHpsRDY5VjNk?=
 =?utf-8?B?czEwNTR1elNBV2VTNlNxd3JJS0FpQmdoMGY2OUYyQTRHWm93cmpiZ1lrSHZo?=
 =?utf-8?B?ZUZRbktNL2xGR3l1Y2hTQ2Z4akpCM1ZYOVZvYmFaM09sYktNeUM0a3dDUEJo?=
 =?utf-8?B?ZUtKdFVtN3lMTnNXcWcrYTVFNjFCRWNXT0lJV1ZZNXZCbGJmUWVTQVN0TjNR?=
 =?utf-8?B?VUFma0hYU0RiNG4rL1JZWDM0NDR6aUQ4VWIrZjNuWE5YSmdwTEtjYXhjTFh0?=
 =?utf-8?B?MHBFSGZEQTlJd1MzalJvS3RPc3QrRktDeGhmM2oxNk50MHZIZjhOV2l4N0hU?=
 =?utf-8?B?eHdEamREWFZvWHVNQ05ZSkVacVRZRDZjZ3NsdDN2bVA2V0dzTWJtYjF4dWVY?=
 =?utf-8?B?QUZidUVGRmpOM2w0R0FvZXUxWENiSmNXeUZNSW91M3lJNy9iNVdOb2J2RDQ0?=
 =?utf-8?B?ckl0d1NiV0pVQ1A5aFJDeVR1a3ZJSHBpa3FTOCtreVZaWG1Qd0hiUUFEbjU1?=
 =?utf-8?B?TURXRFllZDNFYWhRa3hBRTE5NWNKc2l3K2hxOUhuVmdCKzBCeVNOVWg0Q2FM?=
 =?utf-8?B?MG5HRVlKcGcyRS9xcW1GemVZM3ZvV2oyNXlia09rRVJmdFZHUGFIZmprSS9j?=
 =?utf-8?B?VDN0VWpibmRKWlQ2TythTVRVZDVQeDUrM3FVcjlDWitVMXFSMGx2aWFyZzZ2?=
 =?utf-8?B?eDZ4V2xWRjN1aXpvRktzb2xJRDZnRUMvWXRCYm8xRGhya0VCZkFRb0xwMFhK?=
 =?utf-8?B?OXZ0dTJkUnQ1dXdJTnkybis5dGlDVHBkRklCNDJGUnVudHQxcUtBdEorUWlv?=
 =?utf-8?B?czVUYW9QRnpELzNsUU5zQmEwSEpseVE5YTFPb0c1MFVtN3I4L3Qzc2dHRUo4?=
 =?utf-8?Q?fk3XfV1dWu3QQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e4c68f35-8f59-4fa0-4783-08dbd3c4d418
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB4835.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 12:37:33.0401
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9+LIEuCTcvLJSxCvCr3DlvZvhAAwd9eZjVIASF2Jc4aAC+xn28nrKBeV0oSIKauaJTFtE2N+YRqDlS3RxL7u32xl4QSysgfZwJcIkKadYMY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4557
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-23_10,2023-10-19_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 suspectscore=0
 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 spamscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310170001
 definitions=main-2310230110
X-Proofpoint-GUID: yevtW7KTwTcdvpYCKNB-aTqyKL-g_qmp
X-Proofpoint-ORIG-GUID: yevtW7KTwTcdvpYCKNB-aTqyKL-g_qmp
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 23 Oct 2023 05:38:05 -0700 (PDT)

On 23/10/2023 13:04, Jason Gunthorpe wrote:
> On Mon, Oct 23, 2023 at 01:55:03PM +0200, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Selecting IOMMUFD_DRIVER is not allowed if IOMMUs themselves are not supported:
>>
>> WARNING: unmet direct dependencies detected for IOMMUFD_DRIVER
>>   Depends on [n]: IOMMU_SUPPORT [=n]
>>   Selected by [m]:
>>   - MLX5_VFIO_PCI [=m] && VFIO [=y] && PCI [=y] && MMU [=y] && MLX5_CORE [=y]
>>
>> There is no actual build failure, only the warning.
>>
>> Make the 'select' conditional using the same logic that we have for
>> INTEL_IOMMU and AMD_IOMMU.
>>
>> Fixes: 33f6339534287 ("vfio: Move iova_bitmap into iommufd")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>  drivers/vfio/pci/mlx5/Kconfig | 2 +-
>>  drivers/vfio/pci/pds/Kconfig  | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> But this isn't the logic this wants, it wants to turn on
> IOMMUFD_DRIVER if MLX5_VFIO_PCI is turned on.
> 

Right -- IOMMU drivers need really IOMMUFD (as its usage is driven by IOMMUFD),
whereby vfio pci drivers don't quite need the iommufd support, only the helper
code support, as the vfio UAPI drives VF own dirty tracking.

> I think it means IOMMUFD_DRIVER should be lifted out of the
> IOMMU_SUPPORT block somehow. I guess just move it into the top of
> drivers/iommu/Kconfig?

iommufd Kconfig is only included in the IOMMU_SUPPORT kconfig if clause; so
moving it out from the iommufd kconfig out into iommu kconfig should fix it.
Didn't realize that one can select IOMMU_API yet have IOMMU_SUPPORT unset/unmet.
I'll make the move in v6

	Joao