Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20231021140802.4nyyaxclcrqv5n7b@pengutronix.de>
References: <20231021005100.3490929-1-kieran.bingham@ideasonboard.com> <20231021140802.4nyyaxclcrqv5n7b@pengutronix.de>
Subject: Re: [PATCH] arm64: dts: freescale: debix-som: Add heartbeat LED
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>, moderated list:
        ARM/FREESCALE IMX / MXC ARM ARCHITECTURE 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>, ;
Illegal-Object: Syntax error in Cc: address found on vger.kernel.org:
        Cc:     ;
                        ^-missing semicolon to end mail group, extraneous tokens in mailbox, missing end of mailbox
To:     Marco Felsch <m.felsch@pengutronix.de>
Date:   Mon, 23 Oct 2023 13:57:14 +0100
Message-ID: <169806583408.3350128.7507727905154745981@ping.linuxembedded.co.uk>
User-Agent: alot/0.10
Precedence: bulk

Hi Marco,

Quoting Marco Felsch (2023-10-21 15:08:02)
> Hi Kieran,
>=20
> On 23-10-21, Kieran Bingham wrote:
> > Map the 'RUN' LED present on the Debix-SOM as a heartbeat.
> >=20
> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> > ---
> >  .../dts/freescale/imx8mp-debix-som-a.dtsi     | 19 +++++++++++++++++++
> >  1 file changed, 19 insertions(+)
> >=20
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a.dtsi b/ar=
ch/arm64/boot/dts/freescale/imx8mp-debix-som-a.dtsi
> > index bc312aa1bfc8..c9a81486da48 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a.dtsi
> > @@ -20,6 +20,19 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
> >               gpio =3D <&gpio2 19 GPIO_ACTIVE_HIGH>;
> >               enable-active-high;
> >       };
> > +
> > +     gpio-leds {
> > +             compatible =3D "gpio-leds";
> > +             pinctrl-names =3D "default";
> > +             pinctrl-0 =3D <&pinctrl_gpio_led>;
> > +
> > +             status {
>=20
> according the bindings-doc, this should be:
>=20
>                 'led-status' or 'led-0'

Interesting - I can see 'led-0' is supported, but I can't see if
led-status is supported.

Documentation/devicetree/bindings/leds/leds-gpio.yaml:

patternProperties:
  # The first form is preferred, but fall back to just 'led' anywhere in the
  # node name to at least catch some child nodes.
  "(^led-[0-9a-f]$|led)":
    type: object
    $ref: common.yaml#
    unevaluatedProperties: false

That regex looks like it wouldn't support 'led-status'. Otherwise I'd
probably label it as 'led-run' to match how the LED is physically
labelled.

I've set led-0 locally for now.

>=20
> > +                     label =3D "yellow:status";
>=20
> label is deprecated, instead function and color should be used.

Ohh - I knew that, and I should have remembered this from the last time
I did an LED.  That was too long ago and too small a task I guess.

Looking more closely, the LED is green - not yellow too! so I've udpated
this with:

	led-0 {
		gpios =3D <&gpio3 16 GPIO_ACTIVE_HIGH>;
		default-state =3D "on";
		linux,default-trigger =3D "heartbeat";
		function =3D LED_FUNCTION_STATUS;
		color =3D <LED_COLOR_ID_GREEN>;
	};


Updating, for a v2.

> With that fixed feel to add my:
>=20
> Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>

Thanks.

--
Kieran


>=20
> > +                     gpios =3D <&gpio3 16 GPIO_ACTIVE_HIGH>;
> > +                     default-state =3D "on";
> > +                     linux,default-trigger =3D "heartbeat";
> > +             };
> > +     };
> >  };
> > =20
> >  &A53_0 {
> > @@ -203,6 +216,12 @@ &wdog1 {
> >  };
> > =20
> >  &iomuxc {
> > +     pinctrl_gpio_led: gpioledgrp {
> > +             fsl,pins =3D <
> > +                     MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16           0=
x19
> > +             >;
> > +     };
> > +
> >       pinctrl_i2c1: i2c1grp {
> >               fsl,pins =3D <
> >                       MX8MP_IOMUXC_I2C1_SCL__I2C1_SCL                 0=
x400001c2
> > --=20
> > 2.34.1
> >=20
> >