Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Mon, 23 Oct 2023 14:20:13 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Willy Tarreau <w@1wt.eu>
Cc:     Thomas =?iso-8859-1?Q?Wei=DFschuh?= <thomas@t-8ch.de>,
        Thomas =?iso-8859-1?Q?Wei=DFschuh?= <linux@weissschuh.net>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/nolibc: Add Linux specific waitpid() flags
Message-ID: <fc236f5a-8763-417f-8e9b-57da15d5dea3@sirena.org.uk>
References: <20231020-nolibc-waitpid-flags-v1-1-8137072dae14@kernel.org>
 <633402b0-7167-465f-99c6-d959b5f48073@t-8ch.de>
 <ZTOWQnFwrQufHUyw@1wt.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="8/zfyLwjdpXmZrxg"
Content-Disposition: inline
In-Reply-To: <ZTOWQnFwrQufHUyw@1wt.eu>
Precedence: bulk


--8/zfyLwjdpXmZrxg
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Oct 21, 2023 at 11:13:38AM +0200, Willy Tarreau wrote:
> On Sat, Oct 21, 2023 at 11:00:20AM +0200, Thomas Wei=DFschuh  wrote:
> > Oct 20, 2023 23:57:01 Mark Brown <broonie@kernel.org>:

> > > Linux defines a few custom flags for waitpid(), make them available to
> > > nolibc based programs.

> > Wouldn't it be easier to include linux/wait.h instead?

> That's indeed the trend we should follow whenever possible. We've got
> caught a few times in the past with build errors depending on the
> includes ordering due to such redefinitions. I don't know if that's the
> case for these ones (nor if including linux/wait.h would cause other
> breakage) but it's worth considering at least.

> The difficulty here is that originally nolibc did not *explicitly* depend
> on UAPI headers, and was supposed to be self-sufficient (that was the
> main point). Adapting to multiple archs caused the addition of ifdefs
> all around, then trying to standardize the include file names instead
> of just "nolibc.h" caused conflicts with programs already including
> linux/anything.h. Anyway now we depend on linux/lots-of-stuff so I
> think it's worth continuing in that direction so that we don't replicate
> the UAPI maintenance effort.

OK, I'll do that - I'd not noticed that nolibc had started pulling in
linux/ headers so was trying to maintain the deliberate duplication.

--8/zfyLwjdpXmZrxg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmU2cw0ACgkQJNaLcl1U
h9DgEgf+Mj/4MWqwmRLWrbshIma/gJxD2aDCgbB6u/Z3r4WtORWBGpCLHu2HwuUw
1l9FvVIosz/dvUMEYsyCdsRieKYD+G4y7d7mrMOsDy89btenS2ZCISpdeI/UNXun
m1xZyscHvpryRBMg6T89Eu+woMqPly3flZ1N0yPc/fD2xmdnN27WDjveN8VPgY9W
p/ZVQdpnmUvHKIZ7buns17GsXXk27j4rcLbFExCQyz4sOJn1uyT3Wtvq/kiu+EPe
SKkk5NaEn+o6QLUtKyw9t162v5BEjNj47vtXFRcEsVFp6cqEE5guBbsqcE1jbuJB
9qgUjQC6m/o4KdMvtJJz0Qwh4QykPQ==
=W+4M
-----END PGP SIGNATURE-----

--8/zfyLwjdpXmZrxg--