Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <cbe9af6c-cf92-4683-b302-0fdfc9c5009b@amd.com>
Date:   Mon, 23 Oct 2023 19:31:45 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] tee: amdtee: use page_alloc_exact() for memory
 allocations
To:     Jeff Johnson <quic_jjohnson@quicinc.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H . Peter Anvin" <hpa@zytor.com>,
        Jens Wiklander <jens.wiklander@linaro.org>,
        Sumit Garg <sumit.garg@linaro.org>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Daniel Sneddon <daniel.sneddon@linux.intel.com>,
        Rijo Thomas <Rijo-john.Thomas@amd.com>,
        SivaSangeetha SK <SivaSangeetha.SK@amd.com>,
        Josh Poimboeuf <jpoimboe@kernel.org>,
        Juergen Gross <jgross@suse.com>,
        Ard Biesheuvel <ardb@kernel.org>,
        Ross Lagerwall <ross.lagerwall@citrix.com>,
        Yuntao Wang <ytcoode@gmail.com>,
        Sean Christopherson <seanjc@google.com>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Mario Limonciello <mario.limonciello@amd.com>,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        op-tee@lists.trustedfirmware.org
Cc:     Mythri PK <Mythri.Pandeshwarakrishna@amd.com>,
        Nimesh Easow <Nimesh.Easow@amd.com>
References: <fe6fd7781d77ea32064e5b861f33150b28768278.1693340098.git.Devaraj.Rangasamy@amd.com>
 <f08778aa-0e50-40aa-a1be-9cc894b2e219@quicinc.com>
Content-Language: en-US
From:   Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>
Organization: AMD
In-Reply-To: <f08778aa-0e50-40aa-a1be-9cc894b2e219@quicinc.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2xrbTVjK1Z0T0MyS09EVVhTQnZ6bHZ3Y0NWVFYzTTZDRTNXak80SVhBRkZt?=
 =?utf-8?B?NzZuWXVCcGNKUWpTYzBSblNIaXlrK3NUaTVqY3l4azdxRlJvVDdNYkVJLzR5?=
 =?utf-8?B?RTJWRVkxQnUyRGRZdWlObnNoSzRNV0dDYkNPTXhVT2lqVStJd3hFclpveDd6?=
 =?utf-8?B?ZVp1RFNMZGRkMFlNelJRaFo3bHlvVlpZVm9oV2VMSWNxYnQxL2JYZ21WQzkw?=
 =?utf-8?B?Y0xpTTUvY2d3dDYwbTN5dWZlVjFWdTdQQ3BhYzNDU3lJQ2FLdVdFQ2w5WEh0?=
 =?utf-8?B?aWhjU2RWSEROTDhveWxRVFBDSkFvY3pRRDJ3eWxmWXh1dkphWFBTcmtZcURD?=
 =?utf-8?B?ekQyN2hrNmRjYjE1RGFCY3BvdnYzaFZYSDhZUXUyMlpkRHhNZ0oxdUZOUzc5?=
 =?utf-8?B?S2JHRnVwcURIMnlSM0NNNlZWcmtjM3h2UGYrU2luaWlKV2Q5ZUFrZXYxZzl2?=
 =?utf-8?B?YWRGNGpVQ1NIVDZOa24yYWkwRmNnZkpXVmVNSGNZVFg5M0dDYUFNdE84R004?=
 =?utf-8?B?QW5CL01vcVpGcm03YzRuTkFqMXZ4Y0ZGRkYyTkQ3RkZJSXRkOFYxV3hRSkNS?=
 =?utf-8?B?ZHZtOUloemhTMk9qMituMEQ3NTR1U2FvTEJjeFphSnllQXFSOUNscVR1dFN3?=
 =?utf-8?B?OHA3WVBpK0xRYTZRbUk2UFBOK1NJbVNKVlpDZGxoWGFXbUhzZ0Y3eGs2dTAz?=
 =?utf-8?B?WEptY25uTlVzSjNYYzdGL2FrM1F6a3BJWGhiMGZ2OEZ4Vk5ydHlGUTlNNEtT?=
 =?utf-8?B?K2VuR2tSY1U3M2lKc2JOSTZrN2JFdk8vMitZUHNtUlVzUC9ZbDhDbW5xN3Ew?=
 =?utf-8?B?bVJrSzR3RnRuZkg0UTRBeWtnQ09GWjEwWlJHOFFGeGJJUExPWnMvN1AvazR6?=
 =?utf-8?B?aHpUZE9mUU8ydHdRNGQ0bUNaSjRNSmRNSnBtdWFldXNWQURjVlFPRStYL2wr?=
 =?utf-8?B?QjBMT0tablBGRTZtYm5PVFdTZzkycXdPUjVjQ3Y5VDRnbnRiR3JlZVZqQzE3?=
 =?utf-8?B?VUwzeW96Qjg2SzY1cEhsbkFIM2l6SE1QNFE5UnJIY3c5Y2p4aVFJNVJvRjNh?=
 =?utf-8?B?T3Z4VCtLb0NlcDcyT0VnbFd4YnhTYjF4L2cxdU04RmRhTnBxcTFuUy9nbnRr?=
 =?utf-8?B?bEFwNDV3OTZRR2U0TWNRN20rUyt1VFFvbVprOVQvMkVCeVk3RHBFQ0Rwa05V?=
 =?utf-8?B?UXZyR3FSUUJoMU5aK0xDT25pbWNNMUpwT0JHYk03QWhFTEE5OU14NGZUclU2?=
 =?utf-8?B?THh1eVBmRVRDbG5XZ2UvSEZFMjJzTnl1U2tOTENqRnE2MjNsYmJJbktxWFF5?=
 =?utf-8?B?bmRrS2pZd2pPcEE1ZlVOMHE1ZUp6UFJSOWIyQklxUmx2M1lsdFdsVjhDa3F1?=
 =?utf-8?B?NURiTWFvUVZCb291VklXWmNmT3N0NzhLMWZyMHVCZ0tBSk8zYzhUV1hQZlcx?=
 =?utf-8?B?cVpGTXZTY2d6alNQb2hVbnhLQnZ0N3JlaGhTVGZ3V1pLTmxuS3BZdFB5QVp4?=
 =?utf-8?B?VDdxaHV0Z1prVFJFMG5xV1ZWVkl3WEJRRFpQeWZySzNCenlYaGVWUG1FNjJD?=
 =?utf-8?B?S0loZmdoQUNSOG9Ic1ljN204bkVnUEwrOFJLSzhQam8zTHJnYjZOQU1MdTNI?=
 =?utf-8?B?KzRHbDJwS0h3Y0pEVklGQTFZS0k0Q2pJTkxLUEZsUE9ibUsxU1pTNXpBTlBy?=
 =?utf-8?B?NzdtL1lJZko1NnAyeXlOYUNwcTk1WTMzUmVDa21uRkJERlJQSXc5a3Y1Z0la?=
 =?utf-8?B?TEJWY2tlS2x0dFV2azZRSTFBTkd5T1U2Q3gyNTNlemFsK0pLVzVrQ3dsa2FM?=
 =?utf-8?B?dFJ0TStzaDlIREp6N1dUNVB4UU1zWlZGRnRhZ2U0bVVGcCt3NnZ4UlpFakVa?=
 =?utf-8?B?WEFCejBYaTJoY3EvNmtSMUZqNVRHdWNOa2YyZ2c3Qml3QWQyb2ZuOXUwalUr?=
 =?utf-8?B?Lzd0aTlNMmp2azRLdC8vN1RkL2JST1VXdGlzb1VKeWYrUWlyMzhSODdtL0hy?=
 =?utf-8?B?dUlielZBbkhLNzB0akRLRUt6TlhKYUJYV3o2SG41b01HT29iTmxzSFU5VnV1?=
 =?utf-8?B?eE4wN0hSbUlpM210WkNES1ZZa0xmR2t1QTNWdlg2UyswVTJOZGRSMEVmZHhC?=
 =?utf-8?Q?4k/Uswz4fjoaFaLA6hWH+4k47?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5fde619b-582e-4fe7-4847-08dbd3d0a7fc
X-MS-Exchange-CrossTenant-AuthSource: SA1PR12MB8743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 14:02:13.1502
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1vZYzQS720ct3ut6rSu6YWwOWjE/Po0fmjfU3CJ15g96EZywa7aLIFyW/RlVCwG9fmqWa6JgJXo79Y3DGq/KdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7111
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 23 Oct 2023 07:02:31 -0700 (PDT)


On 10/5/2023 12:39 AM, Jeff Johnson wrote:
> On 8/29/2023 1:19 PM, Devaraj Rangasamy wrote:> Use page_alloc_exact() 
> to get buffers, instead of
>> get_free_pages(), so as to avoid wastage of memory.
>> Currently get_free_pages() is allocating at next order,
>> while page_alloc_exact() will free the unused pages.
>
> s/page_alloc_exact()/alloc_pages_exact()/ everywhere including subject 
> to match the actual code change?

Ack. Thanks for the catching this.

While I could send an updated patch taking care of this, we are working 
on a rearchitected patch, due to a new requirement.

Kindly abandon this patch series, and we will be posting new support 
soon to the community.