Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Mon, 23 Oct 2023 11:19:55 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Joao Martins <joao.m.martins@oracle.com>,
        Arnd Bergmann <arnd@kernel.org>,
        Kevin Tian <kevin.tian@intel.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameerali Kolothum Thodi 
        <shameerali.kolothum.thodi@huawei.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Brett Creeley <brett.creeley@amd.com>,
        oushixiong <oushixiong@kylinos.cn>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: mlx5, pds: add IOMMU_SUPPORT dependency
Message-ID: <20231023141955.GX3952@nvidia.com>
References: <20231023115520.3530120-1-arnd@kernel.org>
 <20231023120418.GH691768@ziepe.ca>
 <a16758d6-964d-4e46-9074-4d155f9b3703@oracle.com>
 <b3f7ecb1-9484-426b-8692-98706f7ff6d4@app.fastmail.com>
 <20231023132305.GT3952@nvidia.com>
 <5d7cb04d-9e79-43b9-9dd2-7d7803c93f4f@app.fastmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5d7cb04d-9e79-43b9-9dd2-7d7803c93f4f@app.fastmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?O24cT2d9UadfnenE0UNIdg8Dl4G3vaGbkhSZYi5dnah/RYSB5Z4hidXdJfxm?=
 =?us-ascii?Q?lgbXlsVoLOd1mPtNRnXwcBNLRhUln1RUe+TbV3YMm4+Jy2kYeH0Xg7Tm6854?=
 =?us-ascii?Q?KvjmP8Mj5GxzmX7ELDaz1S+3v5p2BKLpO9VTj//afQUZ8e1Z+kBIMkTtwrxC?=
 =?us-ascii?Q?3meP2tk8EBoss0lNisyKX9dUnSP6P1ABQoFiIBYC2A1n2jxdbzZmK6cxuQp0?=
 =?us-ascii?Q?09VzPTtDXCeOf7V80ku0w/z4RLCcCKPtqZAnh8RQH7PuklikRBUrt6RtkOTX?=
 =?us-ascii?Q?iLMB/IoJHHtp/+WwWkPQM8swEU/2vMvSJT+rD9cWjqiLA3WiUIPOQOwvnqa8?=
 =?us-ascii?Q?6pQYdqejQmWVg36SszZSFBSB3O7YCT5EWXINPm5qE7H5HO3IstSo2bYscme8?=
 =?us-ascii?Q?lZo3ycLtv52nbzMQ/cdTYBa22/5ILOg2pQcfRlbNjOIUp5aPRD09PcH0eDsB?=
 =?us-ascii?Q?SEpLRIwbq3cPUEEon2ojFkB3Eu8yeXemmTnTCBUMmfveRKP8TxY/i8lUtece?=
 =?us-ascii?Q?S/GZ0B6pUtmGLjZ151RKJjPnwz+H0mYoDRqiZqJHWG+onwro89yc1y10ppEt?=
 =?us-ascii?Q?z72cmDfizFZokKjkv4SUUmGPD5B+GDitByMCYbNdPWempCOVzD2pA4Pn5D7Y?=
 =?us-ascii?Q?Br4L8hUfCfVT9O14sqvSAI4sJCOJpbfkY3uptGn6NqpXywu9qqRn277QI+lY?=
 =?us-ascii?Q?swzzoBnjJkfG8CkPtMaN/OprRiKJzrhVxODVNo1O8xTp7LX5S6vB9Sx/K90J?=
 =?us-ascii?Q?7fpj1wslKzW31c2zCG2nqS+6vuzpNLIpm2gTS5lEVeaMn5h8BKw8C6lijhQ0?=
 =?us-ascii?Q?tJvnjlJltQKSSYJq0yxyEStfxy08u9S3f6Eh9glu4BcycidMpuOBMZAWNrvr?=
 =?us-ascii?Q?vRercok2841qdwb+zQ7cMzxUZK9Cs2GamsI9BMi+sHIJVr2Zp2QtNISzy1yR?=
 =?us-ascii?Q?pX5Z9I+8COZQ2JbCDQGZho5O0I1ruBeA0O4LauA1WSCp28jk+14k24UNawrb?=
 =?us-ascii?Q?iwPA4izTa0/DWZEw+2niBAbO09eUbozAh6lCKfnezy/d8iIt7CE15rHH1/eR?=
 =?us-ascii?Q?VtF4I0MihAiinYTyZLUWQgzK4hI21QrMUdVQlRNW/0NsaINO6I3PBNM7LiOz?=
 =?us-ascii?Q?YlOg2orL/LNRm3ytA2E+eKKjDhg6uMbuv05mEiwvG6THmeNns9amW/Mh5R+x?=
 =?us-ascii?Q?tYuwuxOZhvMZimJMdhRcZ/IJNsN7ii1/O6l4Z+W+wrBjsRedA1S6q3w/HyvF?=
 =?us-ascii?Q?1KPHUjpaNqehXbyvNA5TH3Urug66tjoSmPhMz8tEECBq2FxlFLKUrETVdIhX?=
 =?us-ascii?Q?2yDid71VYGgdcCi155wJmjocVr5MNqQnsurKMP1CYU/vqU5B45O/vlEvlcru?=
 =?us-ascii?Q?pwkBxsk2VTHQuW0qpZOYY7xvEbqsWzQYI/MHLle1iL7ifuU8M1hYgPXuhZ+F?=
 =?us-ascii?Q?bfsobhVfAJoVobWE/dtz2g7sLpJvAMeJbVBhJdwiCdWvxoo3U8Zt7QaZhh3P?=
 =?us-ascii?Q?gYSYyC3vxxmWMtNR/8feh42P+xxXqyENT15eDFnBDqrgXepI1kgqwen2svHd?=
 =?us-ascii?Q?Eklk5Du62izUfo9fJOJ4K/PuA+egiCmtdSsdVk/b?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5f5e89b-ac08-4455-8742-08dbd3d3222c
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 14:19:56.9353
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TtcNr79pcmS+Okz3xnQ6LUEXkOU4GT7/afaXtfdHQMM/+VmrcA1Lv5rKUzPZsbhU
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB5664
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 23 Oct 2023 07:20:36 -0700 (PDT)

On Mon, Oct 23, 2023 at 04:02:11PM +0200, Arnd Bergmann wrote:
> On Mon, Oct 23, 2023, at 15:23, Jason Gunthorpe wrote:
> > On Mon, Oct 23, 2023 at 02:55:13PM +0200, Arnd Bergmann wrote:
> >> On Mon, Oct 23, 2023, at 14:37, Joao Martins wrote:
> >> 
> >> Are there any useful configurations with IOMMU_API but
> >> not IOMMU_SUPPORT though? My first approach was actually
> >
> > IOMMU_SUPPORT is just the menu option in kconfig, it doesn't actually
> > do anything functional as far as I can tell
> >
> > But you can have IOMMU_API turned on without IOMMU_SUPPORT still on
> > power
> >
> > I think the right thing is to combine IOMMU_SUPPORT and IOMMU_API into
> > the same thing.
> 
> I've had a closer look now and I think the way it is currently
> designed to be used makes some sense: IOMMU implementations almost
> universally depend on both a CPU architecture and CONFIG_IOMMU_SUPPORT,
> but select IOMMU_API. So if you enable IOMMU_SUPPORT on an
> architecture that has no IOMMU implementations, none of the drivers
> are visible and nothing happens. Similarly, almost all drivers
> using the IOMMU interface depend on IOMMU_API, so they can only
> be built if at least one IOMMU driver is configured.

Maybe, but I don't think we need such micro-optimization.

If someone selects 'enable IOMMU support' and doesn't turn on any
drivers then they should still get the core API. That is how a lot of
the kconfig stuff typically works in the kernel.

Similarly, if they don't select 'enable IOMMU support' then they
definitely shouldn't quitely get the core API turned on!

> diff --git a/drivers/gpu/drm/nouveau/Kconfig b/drivers/gpu/drm/nouveau/Kconfig
> index 4a79704b164f7..2902b89a48f17 100644
> --- a/drivers/gpu/drm/nouveau/Kconfig
> +++ b/drivers/gpu/drm/nouveau/Kconfig
> @@ -4,7 +4,7 @@ config DRM_NOUVEAU
>  	depends on DRM && PCI && MMU
>  	depends on (ACPI_VIDEO && ACPI_WMI && MXM_WMI) || !(ACPI && X86)
>  	depends on BACKLIGHT_CLASS_DEVICE
> -	select IOMMU_API
> +	depends on IOMMU_API
>  	select FW_LOADER
>  	select DRM_DISPLAY_DP_HELPER
>  	select DRM_DISPLAY_HDMI_HELPER

Like here, nouveau should still be compilable even if no iommu driver
was selected, and it should compile on arches without iommu drivers at
all.

Jason