Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1279486rda; Mon, 23 Oct 2023 07:58:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF92OBRDIGM3wdaMnCUCkJzwsI3Vf8QlPFXkNuL9k9nHJ0g9+A2p+Ca+P1C92p8hmL83v2J X-Received: by 2002:a05:6358:3b8d:b0:168:eec9:f3ae with SMTP id j13-20020a0563583b8d00b00168eec9f3aemr190211rwe.31.1698073088425; Mon, 23 Oct 2023 07:58:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698073088; cv=none; d=google.com; s=arc-20160816; b=qC37WLl75a+htqyZ/7OzKW3AmhpPdqV0vowbZKUxAuaF6cRA9dCdMDF9t/EgVNI+us b2x06vgvOpu0Yi6fH9/OC/Iui9XaL5zJrSnGsPRWRiKZ8pBoYIhyuIiOburISD8iu/Tu 84g0ZPJV0WpV3/HLOf+orFTxy3KJGb54LhdaPmIk3o+s8oVQtppmYDMUqniZOApak0IU Vj/GwTIp4C33Xon/w2cz4iHzIZnTIc2yVqkdwRUrpjN7NqzYeDwvIEUYYDiYRXbJC0nB 9pAcyOIFmG45yFL01MBzyJWpx1+ndw8xyJFW3ahHLhF0lX8HUnqPjWh1wvcxAVJ7OZAv TixA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Ibdm669iv9OJcE/KkdIFiBrAQ0+k5qbSY1Q4FYfsL4s=; fh=ohdczvOs4J7S8E/87JjAUe6tyGJWZpGB+dZjzhiAfoA=; b=Hwg9OEhgwjcV7Gs8CW1ys4pcC7q9zl9c4TFZwbtS/ITPflG1ygTJEfYjHUIkdPNJBm gpCuCjZ0WMW4OH/98uW1Fxw4Jr3IAufvQbkC1zRMjvY6nUExV5POV7kePEsvaujzt1gv +il0Nn0KU32Kb63iu7TyOefX2qxLHpMFhHEvDukldg3sqVO4fnN9p39puBPCM61mZ7W3 PPczuzNt3HAL3WBDYLL+CzHm4+O6Cqy3UwV8ioanJNQDB52g71lbZwyVQmu7XdwFA166 80K4Oa3FNpIla85cOg+EuvvyNgJFXX0uMYLZ5+Zx6uuhZhCqsSgrIUvknNn2C2IdpHX8 gjew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fCMzxp5F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id p16-20020a631e50000000b00584ca25959csi6531619pgm.540.2023.10.23.07.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 07:58:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fCMzxp5F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id EC22F8067E1B; Mon, 23 Oct 2023 07:58:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231163AbjJWO5z (ORCPT + 99 others); Mon, 23 Oct 2023 10:57:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43868 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231312AbjJWO0T (ORCPT ); Mon, 23 Oct 2023 10:26:19 -0400 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 055C6100 for ; Mon, 23 Oct 2023 07:26:17 -0700 (PDT) Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-4079ed65471so27830875e9.1 for ; Mon, 23 Oct 2023 07:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698071175; x=1698675975; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Ibdm669iv9OJcE/KkdIFiBrAQ0+k5qbSY1Q4FYfsL4s=; b=fCMzxp5Fse15xzLkg6RG3CAvdg6fbORtUTOBfpmgLuiL/xYcr1q5xhb2RHFJed57sW Ly0O3x0X0p0deKvPqDyeeC3V7VSifTRSE2aSFtD6Q2UEQOBqDaxPMc8b4TXZvcEneX0c bX5R7xn7YpW9Lz8PygRkVOQkOCVuWXXE1WKkxlfw/fpXRc6S/YpjY9fsuIZVn/+sxqlm 5v0EW0ajBcnXOy5OK6fUUiJac+zRDgvj9fVrTtf+OtVpeDO0zs9E5riOz+Fr7Bg5Sh1i 9FGJuh+4Md/ucOHmefPXAJAUeQ50Lt/LfdirrfWbmTrqt1QIWMmB1BR2h/fzmNsT33Ob q50Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698071175; x=1698675975; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ibdm669iv9OJcE/KkdIFiBrAQ0+k5qbSY1Q4FYfsL4s=; b=h/Re0Y0P+LSs+LZ14qZips3ONwqOBkLTBUN90T7/wHTLwojPrnnw8dohDLZb5CqjSj SxmLhYlHySQUeEW02Eze4BU1UginVCe5RWf4jSqITPfiWT0hWPwFwTMxMXIWyzuIlxKz NGHHkoQ/bEzgpiNScC8tmyP7mXME1m/QybNNm2jarfPtNnCrTg6bZXyp7G8mqzF7dG+k heDwSnuJgrR4gdlckqHRkUNfZYuaNirqiJhkZDfrpAG1vUsSCPZy0d3y+DIeEEGTm6M1 K2MP8A6dRVdTJzQJ7hy+vHthIn3RB7SeTuuIOc7ZTss6MjrA+9V+f04iPY2yPcjKRiNO w7zA== X-Gm-Message-State: AOJu0YyQOEYNJmY8T/TFcqdavPpWM5vqOmkuLShzqxHrZZitsTIolS0H kZSl+V6UZAyNgo4VZw6XuJeWHQ== X-Received: by 2002:a05:600c:5493:b0:406:5463:3f51 with SMTP id iv19-20020a05600c549300b0040654633f51mr7197630wmb.25.1698071175401; Mon, 23 Oct 2023 07:26:15 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id 1-20020a05600c228100b0040596352951sm14091003wmf.5.2023.10.23.07.26.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 07:26:15 -0700 (PDT) Date: Mon, 23 Oct 2023 17:26:11 +0300 From: Dan Carpenter To: Jonathan Bergh Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, error27@gmail.com, linux-staging@lists.linux.dev, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] staging: media: av7110: Fix various whitespace checkpatch errors Message-ID: References: <20231020232332.55024-1-bergh.jonathan@gmail.com> <20231020232332.55024-3-bergh.jonathan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231020232332.55024-3-bergh.jonathan@gmail.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 23 Oct 2023 07:58:06 -0700 (PDT) On Sat, Oct 21, 2023 at 01:23:29AM +0200, Jonathan Bergh wrote: > Fixed the following checkpatch errors relating to whitespaces: > * extra whitespace after '~' symbol > * remove whitespace before/after parentheses for switch statement and > function parameters as well as after switch keyword > * ensure whitespace before '{' braces > * remove whitespace between function name and '(' parentheses > * ensure whitespace after ',' commas in parameter lists > > Signed-off-by: Jonathan Bergh > --- > drivers/staging/media/av7110/av7110_av.c | 28 ++++++++++++------------ > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/drivers/staging/media/av7110/av7110_av.c b/drivers/staging/media/av7110/av7110_av.c > index af3845406626..482dfc548b16 100644 > --- a/drivers/staging/media/av7110/av7110_av.c > +++ b/drivers/staging/media/av7110/av7110_av.c > @@ -241,8 +241,8 @@ int av7110_pes_play(void *dest, struct dvb_ringbuffer *buf, int dlen) > sync |= DVB_RINGBUFFER_PEEK(buf, 2) << 8; > sync |= DVB_RINGBUFFER_PEEK(buf, 3); > > - if (((sync &~ 0x0f) == 0x000001e0) || > - ((sync &~ 0x1f) == 0x000001c0) || > + if (((sync &~0x0f) == 0x000001e0) || > + ((sync &~0x1f) == 0x000001c0) || These should be: if (((sync & ~0x0f) == 0x000001e0) || ((sync & ~0x1f) == 0x000001c0) || > (sync == 0x000001bd)) > break; > printk("resync\n"); regards, dan carpenter