Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   Frank Li <Frank.Li@nxp.com>
To:     miquel.raynal@bootlin.com
Cc:     Frank.li@nxp.com, alexandre.belloni@bootlin.com,
        conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 4/6] i3c: master: svc: fix check wrong status register in irq handler
Date:   Mon, 23 Oct 2023 12:16:56 -0400
Message-Id: <20231023161658.3890811-5-Frank.Li@nxp.com>
In-Reply-To: <20231023161658.3890811-1-Frank.Li@nxp.com>
References: <20231023161658.3890811-1-Frank.Li@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EpREH2ApipoCFTjNKq78RmnjXZbB0XRrG4CC+afhXCiIpKgh2cKFCI4Rb0bV?=
 =?us-ascii?Q?FhFLENsAlBd9DsG3oVZbT6zWkFtv5XrcJX9ryFTG9b8bnE8Sapl+U0+Pilwh?=
 =?us-ascii?Q?Grhm99mEjnr6tD9KNAers6S0xGonuKnwhABr2GP0JXGtfFXz3mCLE+pI3+gI?=
 =?us-ascii?Q?S+EUqBRg6/pZhwuqGvfsWQ0WFkqyqXGlOT9DTmxv/JuCtJkIvnIKS8vT6+hd?=
 =?us-ascii?Q?oftLUWb9dw7WyjfO4xNVfeWzBMlM/p8K3a67WDlHa+s7Tyv+KepMe/J3JcO9?=
 =?us-ascii?Q?4c5VIKcLcOTkFYKSlFoB74U35yotDSWyVpU1L+9GWklXpfPWYWQccpoiDylg?=
 =?us-ascii?Q?ev2DktSPP9nx2v3ft49AmusCC5/k9u2jOnyRewm6ZrBIuJlkGJz2yq/BnMDr?=
 =?us-ascii?Q?3Qyv6em5Fj60Uwe4Q9ZmbEDFfasfzPBCz6mqrSzeX862rgG7DyUqtSvajI9R?=
 =?us-ascii?Q?PESdsNza1OXcvQRYnjkOGzKDX/Py8d7kAWKixc4tL9HgxL7Rpr/bXGMGrvH5?=
 =?us-ascii?Q?CFxvkRJ5TPHQhqH9FE5ZohyqDRlMY58rzPAnNwJet2Zy0dPVSBpOukscEuBv?=
 =?us-ascii?Q?gM43OtPTHz4G1Ms2AuR5P9MC2IdbkNPyelGZs9WuNtPtEqDigHgDkjuF/0Yz?=
 =?us-ascii?Q?IPb5Ndf3NImfkto2pKk1r7AVNE3NNKdk0Do2uDK7ovzx8AyRAqAzeJR0FOig?=
 =?us-ascii?Q?9AXLHTRWL+prQRaFCbp5GcYp6M1yMJe+X7DjkATyUDAhq8Unk5nP/tNRtukB?=
 =?us-ascii?Q?ZlXW0q0Jr8m+OV71Wt/QoQR7NguP6GCOtOTk68zO2kMy/olRSaxso1cXAqj+?=
 =?us-ascii?Q?juYyhFNr+nkUb8oOfb7pNuxJLFob4INP7PT7Hd7StAVrEsWUDIxl7267NYgD?=
 =?us-ascii?Q?uJPA54Dfgc3wJHcccrPg0VoLjy9xcz/8SPlIj+8FGUVHf8eeLXXsmtVL6CZn?=
 =?us-ascii?Q?Qj+i1VPESyz1q0dnj0986ZIFO0/sw50PsCs4c9JDbFsnxZ4jXRHll5dY+YCA?=
 =?us-ascii?Q?EsTa8/7uCMFgfT9HA3kCQZYVnJroDEB78CwTZfoGjZTmDHBOlPiXHL0yatVq?=
 =?us-ascii?Q?MxrHi/MrNfqXWin+Ej4kWGiJ7s0aZ1hl7ir+LR+fjWSC/FHy1OV97aPH3YBw?=
 =?us-ascii?Q?Sz8eUXORz61jBVbyUPiNRW7dg+XGA/OeogvT1JCdeByLguT0+MjJvBFJFYLm?=
 =?us-ascii?Q?vysnD4ezIdNbeAbkFd9thQOCltUmAuLCtVH4kQT/vR+2Jx5MmdNKLW4Y/7ji?=
 =?us-ascii?Q?dUxuxutHzZq8fG2X0cJtkb8mMNXpL3ZQn9H2r6RrnnN2rGjUHaWYnxC+W7NR?=
 =?us-ascii?Q?V+uoK79GXqqoPd6G0Wmy52QvHDB/2CxR1CBJ3j8/5WCd4mWEkyTdCqutmJGg?=
 =?us-ascii?Q?qYuTYX4F6Vavkw0BUcnBQvSZyZ643SsbPuruuMoZR1A2UTa8OeKUFlPS4zEV?=
 =?us-ascii?Q?kfS9UaxQab7aLclN9e3l3eSAoA6ev/tAe89SaZ3XIus4c90noYldHnq+R+nr?=
 =?us-ascii?Q?UXnM2IZ5e8VTqCkgojrEVt9XN0htcgmfaNF4eE6BLDrRILXPLBnjXqJgs7gU?=
 =?us-ascii?Q?LhbRQRr5gmMItIK9yOCyWLewUmS0c+o44CSK8vqW?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3069292a-2621-486f-446b-08dbd3e388f4
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 16:17:21.4682
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6waxxU/5KgXtirH/MXaK4sRjHcHfjEpQVpfP3ntSLWlh4Wc9+ib2dIK38AdsV2/1pnjnCiv7n8d7hy9bnTcMfw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8655
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 23 Oct 2023 09:18:01 -0700 (PDT)

svc_i3c_master_irq_handler() wrongly checks register SVC_I3C_MINTMASKED. It
should be SVC_I3C_MSTATUS.

Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Cc: stable@vger.kernel.org
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v2 to v3
    - 'wrong check' -> 'wrongly checks'
    
    Change from v1 to v2
    - Add Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
    
    Change from v1 to v2
    - Add Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

 drivers/i3c/master/svc-i3c-master.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index dd06b7c9333f1..b113460f059c3 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -476,7 +476,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work)
 static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id)
 {
 	struct svc_i3c_master *master = (struct svc_i3c_master *)dev_id;
-	u32 active = readl(master->regs + SVC_I3C_MINTMASKED);
+	u32 active = readl(master->regs + SVC_I3C_MSTATUS);
 
 	if (!SVC_I3C_MSTATUS_SLVSTART(active))
 		return IRQ_NONE;
-- 
2.34.1