Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   Frank Li <Frank.Li@nxp.com>
To:     miquel.raynal@bootlin.com
Cc:     Frank.li@nxp.com, alexandre.belloni@bootlin.com,
        conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com,
        linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 6/6] i3c: master: svc: fix random hot join failure since timeout error
Date:   Mon, 23 Oct 2023 12:16:58 -0400
Message-Id: <20231023161658.3890811-7-Frank.Li@nxp.com>
In-Reply-To: <20231023161658.3890811-1-Frank.Li@nxp.com>
References: <20231023161658.3890811-1-Frank.Li@nxp.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFQxYnJHS1Y0T0c4Z3FyNklJeVptTUkrdU5QVVZIdmh5MEowbE4xdG9ZZGlR?=
 =?utf-8?B?Q2JOYmxLRkdIckZBbC9IWlJMQzVVaXFacUdsSjU0dTZzaHVzdGhmTlZoRFZ6?=
 =?utf-8?B?RkkwOS90Y01MRVk5ZjRHUHJyVUxyMnUwaEJ0NXhIRUlrUUNmR1IwQjBJdjZG?=
 =?utf-8?B?eC91M2xHd2JNT203eCtDUlFHQTgyUEFLM3ArcnhYd0JGWlY1Wk03Y3lpZnVB?=
 =?utf-8?B?a2VtWk5MdVkybVBsakJyN0E2Ykg1c25TWTFZeUwxRUJGa2ZOSTJZUExzWGw1?=
 =?utf-8?B?UTB1S2lGVkhGR0ZjNTZpR0creEpXTGFXbThubWVZZmRHb2Z4WFlXY3RobUhY?=
 =?utf-8?B?bEVKV09pSXpxbWNXQXVCWStldmFPZmVYSUNOQjRWY2F4TXFRNzMvSDVDbEdI?=
 =?utf-8?B?WWVTZGQzc3ViM0hiaDRCV25Ra25kSXFKc0hndGFTUHErRy93ZGNxa2ZYY3oz?=
 =?utf-8?B?VmM2ZDVsMWJCU0VLOEFMTWhnekh6UEVlTzBQVVl2MU5HNy9xWHVWYkxod3ND?=
 =?utf-8?B?dEpvQVhmSThsd0N6T0tPbXNWRGhUK21lZEVjOUlEQUErc3ZreU5ZWU1SZllX?=
 =?utf-8?B?STV4SXg0MGJiTE8rb01QYmM4Q1c1aTNMMlNZdzBRbFo4dDFHWUVSMDdab1ZC?=
 =?utf-8?B?bkRZYWUxMkkrbjlGSXBMN2lTMTZZdzY3dTJQTzlHYTk0eWQ3b0ZiVTVNd2ha?=
 =?utf-8?B?R0t1b1UwTHovWlVnSjlMQVdVVmJzOHlaVElyMHNLWEozQzlqSHdsREJnOGty?=
 =?utf-8?B?TmJCQkNKRGgvcTBkTVJ2SG85L3Q5bHRkaVF2emZvMmpLQjZVQnlxdnlmVFNN?=
 =?utf-8?B?QWZ1Z05TZTVmcHE2d3FvejIzSHpBQ0VKbjROT01rNmtSbzNOSSt1dmpDMUZX?=
 =?utf-8?B?SkZMUndaWksrTnFVbFUvUjBBQkpvendUV2RxbTRVMGVvNlVmQWtOa3E2T1l3?=
 =?utf-8?B?MDZxZncwQXk3dHNsOFJCUzBab1ZmRG9Od3M1NjdEVCtZQlJBODlhbGNFaHdG?=
 =?utf-8?B?ZC9adWJ2ZXFKYjhCZWl5TlFiUC9rQVJGQnJkM2tzZ1BwOXdhdmluUEwvTDZw?=
 =?utf-8?B?cWhpb2pOcUNwZGdGWkpOVEMwbmJiMmJTUmFFUllOQ0JmSTdKeGRmMHY5SG83?=
 =?utf-8?B?MC84eThLSERBeE03OGM3OUd4V1ovRzJUMDIvMTladExsVm1QTkRPZU8zY2ta?=
 =?utf-8?B?L1hpcmUxa3N0bTBKU1lDTjlvVE5KN0kxWEJBVjVlOW9JRHBadGNBQ2NRL1hk?=
 =?utf-8?B?MENaTzk2WHBzanU1VUFQQlZYeHRmUzFqVzIzM3d5TXpOY2hCZlVuRk84bWdp?=
 =?utf-8?B?VWxMRXlCZVk0YlhnZ1FVbjRhczNmZFpiNDNzMWFTR1Qrc1c3T2ltM0JlZ0JD?=
 =?utf-8?B?MFQ4aER3YVBUZlFFejlaZFdrOTlSaGE5cHM5STh0K2NnRGtxR3MyM0FCZGl1?=
 =?utf-8?B?VUlKbXhRczFzTnU0K01mOTNhN205QnRSV0VhZjE3WVZNU2tFSU96TWh4NGpm?=
 =?utf-8?B?elFGOWlFRUJCaDZ2Rjk4cWlKU1Y5WUFFd3FiRCtpaEF0QlZybm94OTRzaGdN?=
 =?utf-8?B?R3JYTkorRExRWnhmTUFsenNKTnBXK2xtVjRweDhPeGVyNGgvaXlSS1BXN1Fo?=
 =?utf-8?B?NDN0VkdIbG5MTlZQK0ZHOEhkWnVQL2l1d3graU1DR3Y0dlpwMDkxcHdobVNR?=
 =?utf-8?B?TSs3eXFkZ3NYN0Z3aG5CN281ME1GWjBJVXVxanRRRTY4elZwU3o2dHgwMXBV?=
 =?utf-8?B?QnF5WE1HU3JINkhwUXFsc3ByT2ZLQ3VhV0t5MnJpeVZIQmVMbTNIazYyWW02?=
 =?utf-8?B?RFNrOTFKWE0yNVVWcmhLZnp6dW1HWllFaVZHTGU3SUwyNndnWnBiYXpERjVt?=
 =?utf-8?B?K0UzMHVrVGV1bFdrTnVTejRwVXR4MTNOOHB2YnFHVjcwOG5yY0QrZ0NSV29O?=
 =?utf-8?B?M1g3eWtsUkJyYTl0bFZJMTNtcHhDNmZsYy9GUUw1Z3VuTzBIL1pMS2hyNy9L?=
 =?utf-8?B?Z3F4WVVaVVc5WUs1NTliK091NDBNZG1FUndOMllibGllcW1kOEY0dHlHbTZH?=
 =?utf-8?B?eHhObGtvV2graW1xcGxGM1BqMTh4N1ZRZitiUkNyMmFjNTAwdzJualdhTExh?=
 =?utf-8?Q?q5F6x5hc2oylmxOXC/lq8NzQ7?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6aa3968-6fb1-4441-0e8e-08dbd3e38bc9
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 16:17:26.0587
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fv2aAifx1F2hnB4a9mY7Ky225TgNnfdoQNvWE8DzyfWWSXdNQy2obMMT08ujlHnYmFcBAsyMQlKzPObKwtOM2A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8655
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 23 Oct 2023 09:18:02 -0700 (PDT)

master side report:
  silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090c7, MERRWARN 0x00100000

BIT 20: TIMEOUT error
  The module has stalled too long in a frame. This happens when:
  - The TX FIFO or RX FIFO is not handled and the bus is stuck in the
middle of a message,
  - No STOP was issued and between messages,
  - IBI manual is used and no decision was made.
  The maximum stall period is 100 μs.

This can be considered as being just a warning as the system IRQ latency
can easily be greater than 100us.

Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver")
Cc: stable@vger.kernel.org
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---

Notes:
    Change from v3 to v4
    - fixed missed update commit message
     Add dev_dbg for TIMEOUT case
     This can be considered as being just a warning as the system IRQ latency
    can easily be greater than 100us.
    
    Change from v2 to v3
    - remove 10k at commit message
    
    Change from v1 to v2
    -none
    
    Change from v1 to v2
    -none
    
    Change from v2 to v3
    - remove 10k at commit message
    
    Change from v1 to v2
    -none
    
    Change from v1 to v2
    -none

 drivers/i3c/master/svc-i3c-master.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c
index 1a57fdebaa26d..6b6bdd163af4f 100644
--- a/drivers/i3c/master/svc-i3c-master.c
+++ b/drivers/i3c/master/svc-i3c-master.c
@@ -93,6 +93,7 @@
 #define SVC_I3C_MINTMASKED   0x098
 #define SVC_I3C_MERRWARN     0x09C
 #define   SVC_I3C_MERRWARN_NACK BIT(2)
+#define   SVC_I3C_MERRWARN_TIMEOUT BIT(20)
 #define SVC_I3C_MDMACTRL     0x0A0
 #define SVC_I3C_MDATACTRL    0x0AC
 #define   SVC_I3C_MDATACTRL_FLUSHTB BIT(0)
@@ -226,6 +227,14 @@ static bool svc_i3c_master_error(struct svc_i3c_master *master)
 	if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) {
 		merrwarn = readl(master->regs + SVC_I3C_MERRWARN);
 		writel(merrwarn, master->regs + SVC_I3C_MERRWARN);
+
+		/* Ignore timeout error */
+		if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT) {
+			dev_dbg(master->dev, "Warning condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n",
+				mstatus, merrwarn);
+			return false;
+		}
+
 		dev_err(master->dev,
 			"Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n",
 			mstatus, merrwarn);
-- 
2.34.1