Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1350754rda; Mon, 23 Oct 2023 09:51:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFTKbz1+XAHxvmyZqqVAVLXuvuzYf7VH2ToAi8PuPjA+Et+2SNlBkkflQxDFVa4cp5cJ3ca X-Received: by 2002:a05:6a20:8f26:b0:17b:a34d:5b56 with SMTP id b38-20020a056a208f2600b0017ba34d5b56mr180201pzk.19.1698079886396; Mon, 23 Oct 2023 09:51:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698079886; cv=none; d=google.com; s=arc-20160816; b=QnjagRmR3RWOkznSuj3dMs02uAfyKE3c2ExAjbNMqLlRYDF6qq3A4NA2Rhhk1c0Xsy wcNHSc4T4qrqVRf7HVNW6omx1U8pB3ndLg3V/MAnkDA4BQDKsYM56uVglwwEH1gBU1Su tgZfEZ6vTq4jQ+oXQ2snnrwHHxbwXjtzsKoj/W9FLusU2bIgONJDaLEX9UKE+3pR1tiE JGAnKmukO5B519VW1UJpb0tyVvd63s/kqRuCQY/uH1jNj3rCoZU172uxW5j5IrbuX7Yb rC338rnr8IKY/qlI+74/nXTk/se99OrIDTpTLCBRRMCWrkzJyxQr/THyUKL95jFShQfV 3uqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=+KYkeNBxMFZaLMOC8uuqNz7UHwDIeM0eJWnT9pTEOv0=; fh=WqfAsD6sEpJmZ+djP7IaamPyIzzvUtJq/nVpJ5yAwUI=; b=RhAXvdnJ+S5TLIbJO6xYinNycZx0dCJLtW5CBpcMPjEgrcTYRRWYYkPJufMmVROFVF Kz3Tx2KsuyGZqzG9P78fWBLwO+y8dut5X9piFfskZBONY1VKcBpkUdkCB8aL5q/L1xGY 9oE15ZKnlVDFXALvKewqt+tIN9UKpA8FxH7qRQx1SX4tmF4tbAR0SsAJbDAnPoMVhTiM SocoaPzi4AfgjnSTUnQTiryennicfHIgO16mVLho5bF1/As6L90zH9YeUcaTrGGF7DBk jSyM/sUwaNG8OWuJNd90990jVyWBIMbznuiy3ugjW0Dm/ZtQq2Bf7Ny3bkvHMTfo9P9K 6jCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=guWlssFN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id y63-20020a638a42000000b005b861295496si6470372pgd.120.2023.10.23.09.51.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 09:51:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=guWlssFN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 81DED806502B; Mon, 23 Oct 2023 09:51:25 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229865AbjJWQvQ (ORCPT + 99 others); Mon, 23 Oct 2023 12:51:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjJWQvO (ORCPT ); Mon, 23 Oct 2023 12:51:14 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C85EDE for ; Mon, 23 Oct 2023 09:51:09 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4083f613275so29083895e9.2 for ; Mon, 23 Oct 2023 09:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698079868; x=1698684668; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+KYkeNBxMFZaLMOC8uuqNz7UHwDIeM0eJWnT9pTEOv0=; b=guWlssFNEHGYWfzkZhgJP4vgFZ+PAWzgceLZ4qHbVK+dqFv7pnUMo4lYLV3wfJETx9 mEQQw96F7jXzz3cCNqZ6CPzIDIrnuTWM/sHNmDQy32qEJxB9Md2Wv12TA/VPKSNHZslp WOhase80RJN5eqL5EBdGlCjWt8iD6po0NF/olBxm4UaTfIxd4GuRmmWdlPa+KsgwVhiZ cQ9dlBd4+mtsoYf476Rb6cBCl+cCR+ADZKsLk5Lz8NlyGSsbGC/m9GfZc3OfYDrB+Rzi X2uPFGDvzsweXzA4rgSjv1e6N5f9dYm3MiFrDa3lQg9mIhG0Xnqto4omUNinc9FPvmYJ R8WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698079868; x=1698684668; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+KYkeNBxMFZaLMOC8uuqNz7UHwDIeM0eJWnT9pTEOv0=; b=UFirp8pqK4W9jv23opotMHP5cWCaOSddhCm1ZbK3EG92chxfNt6GZqAKBy0fZE/Zcb biq+Z7Mj5Ih6XQdPX7J1sDdB0R7IIK3k8rJI+yt+UBG9GjEeZEDTWSW5XRE2TTVKEj5k K3XgMi2CmuOc0GhdBaSE0urA4swrKi39LxtZ5omATRf7de/BtFEf/9JQw9w9GTvb32Q/ G7tXY3typHXPCH0kp0/Bk6dKDiViC8MHgQajd5OlxbaqdJSSpuZgPcmV/bAOXc/i3x/2 xCkH3fJot8B1bNDAZ0uuB9x7Q8cP8cmp2gJpQYl5HBvaX7TAV4lLsW3XH4cVY8e2CtRk CKig== X-Gm-Message-State: AOJu0YyuD+PpOE5Q4XeniEqdDvMe7iaefqKBMzrJwiaPSPQZfpaWEyr0 fIkxtQ1YVgwVzhn+4GdGwAMBLw== X-Received: by 2002:a5d:5691:0:b0:314:dc0:2fca with SMTP id f17-20020a5d5691000000b003140dc02fcamr6782688wrv.29.1698079867943; Mon, 23 Oct 2023 09:51:07 -0700 (PDT) Received: from [192.168.1.20] ([178.197.218.126]) by smtp.gmail.com with ESMTPSA id b16-20020a5d5510000000b0032d2489a399sm8068772wrv.49.2023.10.23.09.51.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Oct 2023 09:51:07 -0700 (PDT) Message-ID: Date: Mon, 23 Oct 2023 18:51:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] ARM: dts: samsung: exynos4412-midas: fix key-ok event code Content-Language: en-US To: Raymond Hackley , linux-kernel@vger.kernel.org Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht References: <20231017101402.62740-1-raymondhackley@protonmail.com> <20231017101636.62755-1-raymondhackley@protonmail.com> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20231017101636.62755-1-raymondhackley@protonmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 23 Oct 2023 09:51:25 -0700 (PDT) On 17/10/2023 12:18, Raymond Hackley wrote: > Input event code 139 stands for KEY_MENU, instead of KEY_OK as node name > key-ok inplies. Fix it with correct event code 0x160. > > Signed-off-by: Raymond Hackley > --- > arch/arm/boot/dts/samsung/exynos4412-midas.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi > index 7daf25865551..3c1ae3c19828 100644 > --- a/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi > +++ b/arch/arm/boot/dts/samsung/exynos4412-midas.dtsi > @@ -159,7 +159,7 @@ key-power { > > key-ok { > gpios = <&gpx0 1 GPIO_ACTIVE_LOW>; > - linux,code = <139>; > + linux,code = <0x160>; I applied this and was about to send in pull request, but it does not seem right, sorry. The button was always called "menu" button. Why changing it to OK? Just because of node name? The node name does not matter, this could be called "key-1" as well.. Best regards, Krzysztof