Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <1e603c14-54aa-1ea8-cac7-99b29af92b4b@nvidia.com>
Date:   Mon, 23 Oct 2023 10:26:04 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.15.1
Subject: Re: [PATCH] hte: tegra194: add GPIOLIB dependency
To:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Arnd Bergmann <arnd@kernel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Arnd Bergmann <arnd@arndb.de>, timestamp@lists.linux.dev,
        linux-kernel@vger.kernel.org
References: <20231023115646.3573494-1-arnd@kernel.org>
 <CAMRc=MdoRWn_grWoKWagAi11S=mZ9RbP673L77a+qfN_8oTBcg@mail.gmail.com>
 <CAMRc=Mc7PCEimVEJ_JYg=4+X5PAJ1Lh2SxXsNEFpuKctbEPiYg@mail.gmail.com>
Content-Language: en-US
From:   Dipen Patel <dipenp@nvidia.com>
In-Reply-To: <CAMRc=Mc7PCEimVEJ_JYg=4+X5PAJ1Lh2SxXsNEFpuKctbEPiYg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZG1BemZhTDNjYWZYRHovTmJudFJnVURQSDhHazFkVkJtVDNFd2VTSEVNQmFw?=
 =?utf-8?B?RkFIVDRqeFliU2tjRXgwVDYzSllNaDkrYUFaU1hOVVNPN01sVVdnUkFuUjVl?=
 =?utf-8?B?UFgrOTIvVE5JTEZwUzF4WUZOOHRsSUcveWt4ckV6cWVnZEdWY1ZoNVNYZGcx?=
 =?utf-8?B?d3RiaGwyODFhRVJTcjZrN0pEMnBkSWw5YXpZM21HVitSRUw5Z2x4RlFhUmNl?=
 =?utf-8?B?NUd1bW1QRXM2eGtYenlZUGExcFlFdUp2Z3d6K2VjTDRISU1VVlMvZXQ3aHpG?=
 =?utf-8?B?MXdFQmRwYlJNVXAvZ1Q1N0R2VzVXTklUcHFMV01WWXpkUkI1SmtVWVdtZzVM?=
 =?utf-8?B?dkUzcFhBNjV0bVhGTDQrZm85QjVoUlQ3V0tDeXVPQ1JwaFNwQ2IwU3V6Kzcv?=
 =?utf-8?B?eTg1WXJIUGQ2cFQ4ZkNUV2tSUUFhL2dLUEpaMEFtS2ljeXdzUVdzMlc0NFJP?=
 =?utf-8?B?ZFdqS1cwc1JLSEkzZzhWZXp2VDUwZEw0T3RSLzhQM0J2OGJtVnpVcXhsQW1Q?=
 =?utf-8?B?SGl3bFY5U3drUmgyODhSZ1BPZUl0OGpOVE5ZNWRpUEtIRHBDb0VVVTd3TjEy?=
 =?utf-8?B?NlR3T2p4OXhXWlhpQkpieWlUREptdC9SUXJER1VzWUREUUxvc3pnVHlReTAw?=
 =?utf-8?B?N2F6OGZBVWdsT0tpendmaVh2Z3BUZVNjTFF6OWFOQ2VwUU9UalBJQmVkOTF6?=
 =?utf-8?B?dWdyMmJaUEpTdGRaWmlPUmRxY2c5cTgxRDRIZWxCaDdHRG8vQlMyOVRGV1Rq?=
 =?utf-8?B?L2JIMTZBTmZmTnltTUlJR2Vzc3cxelA0RUZGbFdqSEg2SnJwQk44N0xZZkts?=
 =?utf-8?B?OUN3c08wWVlFakxCempKK1F0VUUzbzNpeVpxSy9PaUFUQmwxQ3lXSk1iZ3pj?=
 =?utf-8?B?SndsTWM0M2Jkem9WWDhiblpoOUVTNFNCa2tjNUJWRHV1SG5Wdm9PZ3V6bTBU?=
 =?utf-8?B?TkhYVGJRVG8vU3IrRzRvODRDNmpvbm1zVTBWMmpiNjNmQVZWWHZCUmJueDZW?=
 =?utf-8?B?cEQ5Y3ZCWEV1Q1BaWDBwMGp4SXR2Mjh2MFAzTmorVUtFcDgrOGtSMlNGQUl5?=
 =?utf-8?B?MGtZcTZzb2s5T0M4S3NxUnprcTFaVUhyalFyeUc0bVRzZEM3RHprRHFzV2ZO?=
 =?utf-8?B?K1FoVC84eStrY1dqMEZNdGhqYXYxK0taWmUvWG1jYVVCUzQrUkFkd1hPVlRq?=
 =?utf-8?B?Rm1kTnV3V0piejQzNnduSmswWnNIMVVzVHhQSGhtRU4vR2FJRFNhb1MraXJh?=
 =?utf-8?B?b3RNNU5NZDY2SEpFcFkvbldyeDBxM1kvNXpFMDF6TlhhOXJyaW9OcFdaUk83?=
 =?utf-8?B?OXhYdDlpdHVYdDBrZHdab2srMXdxako5OVVJODhKQkVMRWtWckhoQkFyZmFx?=
 =?utf-8?B?eks5bEd0WmJWdWg0djlaWkpkaWc3N1hXdnVxTHk4OUx0V0wyNEordDRNZjZX?=
 =?utf-8?B?WEF6OVM1aTlWbUVtcEMzN29ZU2tWWXZRbHdCZUVKbkV1U1hPM2ZlcG0zSXJm?=
 =?utf-8?B?T0trSUEyNG1lNkJFMUNleTMzc2JpZU5VejdDc3IwR0pwbE42dXAwVW1JTmhR?=
 =?utf-8?B?TFVlYnBFNU0zaUFjZlhQbW9zQWg1UDlSQ1NscjkwTVA3TVRrNG1zWjNGZmZK?=
 =?utf-8?B?a0QwTUFKYmpURkNtZnpHNUNkamFyMnVRb1VUU2toWVA2bDE3eGFSN3NJYWRK?=
 =?utf-8?B?aVRrL1pPdzlHN0VKQ2dSbTJxVDFrSE45NWsyM0I4dndsbnFqVW4yNUdNMXZm?=
 =?utf-8?B?MVpxaStBYlJuS2EwcUNCR0Q3V2xLWlJvTk5HUE1FL3FGU1NKZmhGcnYzL1NU?=
 =?utf-8?B?OXdIL0tOMEk3RE9yR2Zkd0V3QnpsbG9ETDFmbjNVQjFSaTRRaEZoQXZUQ3Rz?=
 =?utf-8?B?U3laN0RHM0FlWGVaZ1l1amJEakhSeUdSR3dDOXA4aklsS1lCU095d2c0Zlg1?=
 =?utf-8?B?enAySk5HUTlyeXdTNG5UWno4WnJHMTBKTWd6Q29oWHZDcDhPZ1F3ZEdWUmFB?=
 =?utf-8?B?UVpaRmt3c0ZkOWZoa2tpNTJ3VTZHUHVNZllzeE44bmhtd1VwZ3U0c3p6N0tG?=
 =?utf-8?B?Z0J6VVhadXNnUm5WNlNQYUtnTFRWL052eWtSZ0M2dWRUYkc2bWlIbkhTSHE0?=
 =?utf-8?Q?bSoRaRSeHyMerrybiRTMC/lt5?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dace07f7-b981-4eee-ccaa-08dbd3ed2492
X-MS-Exchange-CrossTenant-AuthSource: IA1PR12MB6604.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 17:26:07.9754
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 43DGc8FCi8GrKXLrPrJKBB6XJ6Hpdc8Dbh6/2fafeClXBBfHJsey8MKNyt1+TvtUMRdElRFETQN8qrdII4pm5g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6782
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 23 Oct 2023 10:26:34 -0700 (PDT)

On 10/23/23 5:02 AM, Bartosz Golaszewski wrote:
> On Mon, Oct 23, 2023 at 2:00 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>>
>> On Mon, Oct 23, 2023 at 1:57 PM Arnd Bergmann <arnd@kernel.org> wrote:
>>>
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> The driver started calling into a few interfaces that are part of GPIOLIB and
>>> don't have stub implementations otherwise:
>>>
>>> drivers/hte/hte-tegra194.c: In function 'tegra_hte_line_xlate':
>>> drivers/hte/hte-tegra194.c:424:48: error: implicit declaration of function 'gpio_device_get_base'; did you mean 'gpio_device_get_desc'? [-Werror=implicit-function-declaration]
>>>   424 |                 line_id = desc->attr.line_id - gpio_device_get_base(gs->gdev);
>>>       |                                                ^~~~~~~~~~~~~~~~~~~~
>>>       |                                                gpio_device_get_desc
>>>
>>> Add a Kconfig dependency to only allow building when this is defined.
>>>
>>> Fixes: dc850faa28ee0 ("hte: tegra194: don't access struct gpio_chip")
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>>>  drivers/hte/Kconfig | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/hte/Kconfig b/drivers/hte/Kconfig
>>> index 083e67492bf2e..641af722b555d 100644
>>> --- a/drivers/hte/Kconfig
>>> +++ b/drivers/hte/Kconfig
>>> @@ -17,6 +17,7 @@ if HTE
>>>  config HTE_TEGRA194
>>>         tristate "NVIDIA Tegra194 HTE Support"
>>>         depends on (ARCH_TEGRA_194_SOC || COMPILE_TEST)
>>> +       depends on GPIOLIB
>>>         help
>>>           Enable this option for integrated hardware timestamping engine also
>>>           known as generic timestamping engine (GTE) support on NVIDIA Tegra194
>>> --
>>> 2.39.2
>>>
>>
>> Thanks. None of the new interfaces are "consumer" APIs and are not
>> meant to have stubs so depending on GPIOLIB is correct here.
>>
>> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> Ah, this goes on top of the patch that is in my tree so I'll wait for
> Dipen's Ack and apply it.

Acked-by: Dipen Patel <dipenp@nvidia.com>
> 
> Bart