Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1373106rda; Mon, 23 Oct 2023 10:28:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqO6w7U5C11ywDeWIgGUIjCz1t0NXYgNDs51zx9gbf1exD85BvFv/2/aUSbwLXuKINPTMd X-Received: by 2002:a17:903:28c4:b0:1b8:66f6:87a3 with SMTP id kv4-20020a17090328c400b001b866f687a3mr8192235plb.52.1698082125781; Mon, 23 Oct 2023 10:28:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698082125; cv=none; d=google.com; s=arc-20160816; b=foJ3F6ARihfEgFOaO9DDvILYQscP3AXlT7i/kvNJio9W/JIu22SNXzWVZuXsxdtwv4 2kHw371IvkC5cGWdvG2dahvOLjLbMSPoqClduWFAC/RSWz6uMzWwTjr3xAhKgb/U+kPT ZgoOr2yEdp2iQEwSicC/i5dXnR9kLS/nmnzxvP8LTjQtMwG9mldPH5+Y1wBIVi4CHydO cGnXfka/oxDu9xAFeDiV8CGrJav7qxgqoTlZFPnngmfaLH3fjSJWm3+jIa4oWy0MAC/G s5fIKvoDCtJR1N2N381iMI+K+gckOl3zD9Pw/cN+OGbVWLm5DaCDOYNujU+CdiaruaeD gscg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VOj9ECaB96rIjjnLWcT6tpDdCA0D2GI5mFoVxJymrv0=; fh=dqKkX7O9F9RZzf/R6V0qfKANpIPFMU3wcIkzn1VBcl8=; b=cP4Uu9JbyrpFEq7PhD1/n2/C2+yp1/2o7qJtY4A2WPNn4huExHmYyIDFiMKZI+c2zW XHjKTLLuekiP6PRQSGFI+txhDcowluHVMX5rdQgIbSS/d7IUbAfTdbCnEZv6iC4PHHzR ZwZxeKE178j8uhJ2ezFoptY5q2JyDAnn9sdy9UwS2nrS/t61kQGMhIJJwgqxrwsJXpa9 axtnvtNmJ1QbeUMhfOHcqxU3avZhCf06QZ/6JreRLIbBn0bUomLukUPEyNHDeVi7mD2g vse47hxJ6iJ6SLGmW7mhK287GqWlVZKOvncM3p9vLhRhDtdMWJw3x1gSOq0qL15aT41c nC6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=Vj8O3yXj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id z14-20020a170903018e00b001ca344f46efsi7227252plg.330.2023.10.23.10.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 10:28:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@ventanamicro.com header.s=google header.b=Vj8O3yXj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id A45C580AEB1D; Mon, 23 Oct 2023 10:28:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233494AbjJWR2j (ORCPT + 99 others); Mon, 23 Oct 2023 13:28:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233270AbjJWR2c (ORCPT ); Mon, 23 Oct 2023 13:28:32 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36A3610F6 for ; Mon, 23 Oct 2023 10:28:26 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-5ad5178d1bfso2583668a12.2 for ; Mon, 23 Oct 2023 10:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1698082105; x=1698686905; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VOj9ECaB96rIjjnLWcT6tpDdCA0D2GI5mFoVxJymrv0=; b=Vj8O3yXj48ezfKEVXZH6OQyv1S30Aao9NdA6oLxtvtclpgtOCXCrm8UTgpFJOqp3cO /eKUomcuxxUZXDHV5YlfaOJqdbbDYY4ZHE2RPqRChyaMHogtlCgEOuvJ8BmdRMcntD+t jUNFhiHzxkOnfS9MEnTusVHZuvnS+MFMph/avmp/JeMognpuFDUoKJoR1zwCtVolgj+y asIcHW9XMvcoTgBtrckRP6tHrCMY7VkwUs4HeYzaGWyKNdD4o06YN7hAlk2VPzav412L Dttk72f8RfpUjDK0RqWLxGdfgeQrI2Y6XuQIewgQi/iq6UvZqbg6SOABBli1zGMQ7zHi 9GlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698082105; x=1698686905; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VOj9ECaB96rIjjnLWcT6tpDdCA0D2GI5mFoVxJymrv0=; b=Asp03whLT2ZUWaStjt7ny8afDIyPSIqdbJU8D3NgDvCMeAqYmCt17D98SiXmPCx0KW sgoE9bNuNJh6/Wa9iYX2OUoP2ljbv0fZeIm5C5UXYMwch4txaUeGxfcjq2DiJy6rUmOF m6sKEGRWp7IDVFpiN26FnkNYcymiy3RICyAfUGK0c9ebmcaU5N+1Y1HiUkXoqjzdQmlE lUpOPdV+ELA2/DZqeUQ96Bq4Y3Elf52hnOx6zwcAIEaHGwumFm+pcdyPjexg+stBaGmI 4O4lpsnCsIWngGZqOQNSW2RiEphZXleCWEDa1L2viJXwCAkmrPYaiv7nWDMmY9k2xsX+ lV8w== X-Gm-Message-State: AOJu0Yx4KKoo2Xj8nQtnxKdNTD4Offyk42OPoLTCj12SNWsQBlR5vAKO ObctNwjnWvFyxI1QnBHa84Tjnw== X-Received: by 2002:a05:6a21:3d83:b0:17b:cfed:52ac with SMTP id bj3-20020a056a213d8300b0017bcfed52acmr225463pzc.49.1698082105149; Mon, 23 Oct 2023 10:28:25 -0700 (PDT) Received: from anup-ubuntu-vm.localdomain ([171.76.86.9]) by smtp.gmail.com with ESMTPSA id g5-20020aa79f05000000b006be055ab117sm6473194pfr.92.2023.10.23.10.28.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 10:28:24 -0700 (PDT) From: Anup Patel To: Palmer Dabbelt , Paul Walmsley , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Frank Rowand , Conor Dooley Cc: Marc Zyngier , =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , Atish Patra , Andrew Jones , Sunil V L , Saravana Kannan , Anup Patel , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Anup Patel Subject: [PATCH v11 03/14] irqchip/sifive-plic: Fix syscore registration for multi-socket systems Date: Mon, 23 Oct 2023 22:57:49 +0530 Message-Id: <20231023172800.315343-4-apatel@ventanamicro.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231023172800.315343-1-apatel@ventanamicro.com> References: <20231023172800.315343-1-apatel@ventanamicro.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 23 Oct 2023 10:28:44 -0700 (PDT) On multi-socket systems, we will have a separate PLIC in each socket so we should register syscore operation only once for multi-socket systems. Fixes: e80f0b6a2cf3 ("irqchip/irq-sifive-plic: Add syscore callbacks for hibernation") Signed-off-by: Anup Patel --- drivers/irqchip/irq-sifive-plic.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/irqchip/irq-sifive-plic.c b/drivers/irqchip/irq-sifive-plic.c index e1484905b7bd..5b7bc4fd9517 100644 --- a/drivers/irqchip/irq-sifive-plic.c +++ b/drivers/irqchip/irq-sifive-plic.c @@ -532,17 +532,18 @@ static int __init __plic_init(struct device_node *node, } /* - * We can have multiple PLIC instances so setup cpuhp state only - * when context handler for current/boot CPU is present. + * We can have multiple PLIC instances so setup cpuhp state + * and register syscore operations only when context handler + * for current/boot CPU is present. */ handler = this_cpu_ptr(&plic_handlers); if (handler->present && !plic_cpuhp_setup_done) { cpuhp_setup_state(CPUHP_AP_IRQ_SIFIVE_PLIC_STARTING, "irqchip/sifive/plic:starting", plic_starting_cpu, plic_dying_cpu); + register_syscore_ops(&plic_irq_syscore_ops); plic_cpuhp_setup_done = true; } - register_syscore_ops(&plic_irq_syscore_ops); pr_info("%pOFP: mapped %d interrupts with %d handlers for" " %d contexts.\n", node, nr_irqs, nr_handlers, nr_contexts); -- 2.34.1