Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1385331rda; Mon, 23 Oct 2023 10:53:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGzYZngeaaLg8pnwOvKPDTQtSgyD6O4nykDB4v1gGINWZG1OLeTeecad56BNeRZIDDGfnSf X-Received: by 2002:a05:6358:f086:b0:168:e922:cba9 with SMTP id ig6-20020a056358f08600b00168e922cba9mr1511626rwb.20.1698083636104; Mon, 23 Oct 2023 10:53:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698083636; cv=none; d=google.com; s=arc-20160816; b=M/vA0nv4opA61hVQX4IqSVnv1RNtYFyZm4xsHIF3dm1SfAO1PRb7PZcAVKALAtT0L1 6xjZp23GwIFSnAeTP3kw5gOh5WGIXrmhpA9l1184g49nHzo14DZiWwsbL1pVBqn7jReV /EiWlc9YwZ3gQ98Ko81yhdlmXovmN2saI3/ub5Iy+uLPDhTp8bwB6d0AgdDq6WV1ziCn 3/EWcm+uS98m1Qkg+igsHfrH1l3+fmJVQRRmXw9ea1qtRDi0RbtD5Pg0NhG7/Wk9L4fF n8KLGQu2m7RfSqChVCR+pc5UTEOldfT/H7i1yeem4uqhdMLLeJCsrwPGFNNJgvqL4tUX IFOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=9ko7C2EdoC9wphXk0tr3uC9i7HiAoGj4gZTXbp/k9LU=; fh=3ik7uc5YgogL+vGnFFByYGhLvtwxSEOZr9QQCGRSkNM=; b=fJhy8e7g/1wwR8aQWpLeUV8HY+0C4s0rykr7neSRSn2YFi8D8/ruCiGVbna6g+Pl5e AuunYKOrYPYruTsGfVsUoX7iHZYU4HQtAjns4VdTwMLqi/BISHPmn/0LvcAoyfs8iCf5 2hHyJnLGb1Tyh8A8zuU4naVxTlhyGkkWz92scRgRG9Zy182tYlet6KHi8FR2L+2KtMsj 86LqBJDmWuZ6gvG8fZrRXAD8wRSDOWJPdzSRbra7X1QGf5KVa7VRjgq0HrSH2j1DIR2J fEM86KTmfd0iKe9/ZEKl1QcRcGhQONWV8B9KCpYsD1NwwOwc3kPx2diZizbfcNusOjgQ 3DFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=znZz8Fvr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id bq2-20020a056a02044200b005aa41728293si7006946pgb.318.2023.10.23.10.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 10:53:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=znZz8Fvr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 7EE2B80A3F27; Mon, 23 Oct 2023 10:53:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229613AbjJWRxg (ORCPT + 99 others); Mon, 23 Oct 2023 13:53:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjJWRxf (ORCPT ); Mon, 23 Oct 2023 13:53:35 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DF96A3 for ; Mon, 23 Oct 2023 10:53:33 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 251F2C433C8; Mon, 23 Oct 2023 17:53:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1698083613; bh=Jhe+XeYG4ZAoofviz9gMtylgOsjcE4B/E4TIZ4/ULYY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=znZz8Fvr9vsi/Ax5MK6Q0e1d5+aKpOuPFM+pmFrvJosqNV/l7E/O7cI78iKyxD2aL YrTcgowceF+hp8sB/vgDoBCqtR5z3LCrDKbTtar6dV4vvUkfPItqJY2NBzoQ6TvnTt eaDlEFX1v9vF1pawCL+4Irduz9naDJ+XjaTZFSuw= Date: Mon, 23 Oct 2023 10:53:31 -0700 From: Andrew Morton To: domenico cerasuolo Cc: Hugh Dickins , Andi Kleen , Christoph Lameter , Matthew Wilcox , Mike Kravetz , David Hildenbrand , Suren Baghdasaryan , Yang Shi , Sidhartha Kumar , Vishal Moola , Kefeng Wang , Greg Kroah-Hartman , Tejun Heo , Mel Gorman , Michal Hocko , "Huang, Ying" , Nhat Pham , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 10/12] mempolicy: alloc_pages_mpol() for NUMA policy without vma Message-Id: <20231023105331.311373ed33a0dfe78ddaa9e5@linux-foundation.org> In-Reply-To: References: <74e34633-6060-f5e3-aee-7040d43f2e93@google.com> <1738368e-bac0-fd11-ed7f-b87142a939fe@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 23 Oct 2023 10:53:53 -0700 (PDT) On Mon, 23 Oct 2023 18:53:26 +0200 domenico cerasuolo wrote: > > Rebased to mm.git's current mm-stable, to resolve with removal of > > vma_policy() from include/linux/mempolicy.h, and temporary omission > > of Nhat's ZSWAP mods from mm/swap_state.c: no other changes. > > Hi Hugh, > > not sure if it's the rebase, but I don't see an update to > __read_swap_cache_async invocation in zswap.c at line 1078. Shouldn't we pass a > mempolicy there too? No change needed. zswap_writeback_entry() was passing a NULL for arg `vma' and it's now passing a NULL for arg `mpol'.