Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Mon, 23 Oct 2023 15:08:55 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Joao Martins <joao.m.martins@oracle.com>
Cc:     Arnd Bergmann <arnd@kernel.org>, Kevin Tian <kevin.tian@intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Brett Creeley <brett.creeley@amd.com>,
        Shixiong Ou <oushixiong@kylinos.cn>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio: mlx5, pds: add IOMMU_SUPPORT dependency
Message-ID: <20231023180855.GG3952@nvidia.com>
References: <20231023115520.3530120-1-arnd@kernel.org>
 <20231023120418.GH691768@ziepe.ca>
 <a16758d6-964d-4e46-9074-4d155f9b3703@oracle.com>
 <20231023131229.GR3952@nvidia.com>
 <3b731349-38e4-43bd-9482-6fe43871b679@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3b731349-38e4-43bd-9482-6fe43871b679@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?dYN4UQDd2m7ANFaCQB0CAVq/jf85wGmaoE+o6fv9rGiAV8Na6kGtqyYOptgM?=
 =?us-ascii?Q?ympYj7N/soB1rI7S76plTS88glom8GgwRUjCTBsn0MaUH9hrADHmy/VMD9Et?=
 =?us-ascii?Q?CL6EeBiUk6JUwKYWtEVk6q+9po26HabICNR611Xpwaa51uW4bEdHpTN9D+vB?=
 =?us-ascii?Q?+JYzF2zCG8nql0F9Ln45aIYl4mQg4Nqm81+ocirfFu+kGO6rM7+nN+qOrisi?=
 =?us-ascii?Q?4KRvcbG3XPXkKDmwyOhNnpY4hO8PBcDT603YpDCe87ntoeOoVJzw7QXv5MsZ?=
 =?us-ascii?Q?aa1qXRLh4f+ew5MTAWoSG8R2aFdGyIPq8mAi7StqvZufMujbXXVsLuCzDFmV?=
 =?us-ascii?Q?VeJVSj2wn6UjUa3TV3MtXNSITXmK1rmrui/BXFnJkgN+1ayLax5s7cx36SmC?=
 =?us-ascii?Q?3M48CDPEKpmIViy7b9ZXIewiQYHZuxNRWrTJmMCXltnYno90T2aMAOytVa8q?=
 =?us-ascii?Q?dVBhah4CVK0UvLgw/zC7sJIqXAqffn5Enf3ByPxBYaHxi/5J+hqUMeY+zoZY?=
 =?us-ascii?Q?inHarCFkRvEN/kV3MXmQw3MCG2pVN/RBBu6pdk3TKlTFfASlU4bWLtN+xJnY?=
 =?us-ascii?Q?HC3Tpnq63d5cNLwqOYJ5CGbK/sA5YYhMu1YY4sfgSmJ5sLJWxwC8TpZR7rGg?=
 =?us-ascii?Q?ofALoUtEWScItDJ/T9QG+mLy3Zogw7F7fFZPVHai4WufWwjhGLwHld/ECSM+?=
 =?us-ascii?Q?unei0CnRgtwRDZ0DkCSQWfKGpO8JO57BqwfUT2GaYUCXsmS2cVcyN1a1ZGIS?=
 =?us-ascii?Q?Zi8sZjBwC6nPIs8tqbzPaohN/29fX/kEU2BWyf4MfvwCuM/PB9m+fHk1uNJk?=
 =?us-ascii?Q?CKtL4XF3tsKaew8JdP+BxjqDRlRdWVvEXjxNaPhbRnVLxrsOVmiO+cD1/pum?=
 =?us-ascii?Q?EtsEMXNtC5aUyb9sR1zN7znZnufJJUbxdFHQGlW4bV8v77S5uF6aBeQv8Ywu?=
 =?us-ascii?Q?91blNt1B7utjpKGlgm55OWStG/BGvTLgB7mPcbHgtO9Z/YOZZlByJD6y3WoI?=
 =?us-ascii?Q?FfdvaFWib50SaCtYCWzAbbHZh6zBcnH3/Bd39oBCdGCS87f7dQBJerE5aCsW?=
 =?us-ascii?Q?g3SLAbJh0lARqicsZS5xQC0uZpDQD3eCwdUSW29SQ4mQI2M2oOQBNoh8G3FL?=
 =?us-ascii?Q?5Y3aGBn4C9v7DIrVA1NhrWvDdKXpJEIFcNx4CNKfEkzJR0dt2oLiKdfG18aH?=
 =?us-ascii?Q?qQCzb2q2RNWvC7lweBYPrTc2ahTU6U4nBZlVIulJ0PHQ6wzU2zVA6Oj5DNS3?=
 =?us-ascii?Q?Aj6bOyih+MmyGS/zdArZG+RNW2ivBkI+5f4Wd7A42FN3vHCjMoosQb7bnm5H?=
 =?us-ascii?Q?miYB/LoNM0q73leKo3m5cs4b4nlOcAzQs+a+GpZYHMahpqOlMOANPy5Jcqz/?=
 =?us-ascii?Q?XmxctIPJ5lDzzdmzbcWF/SPFnaGBxGKt9KbOtGPfrmf/UrLvVB/fCVku4Kxg?=
 =?us-ascii?Q?HOJTmCZD4LmaE788ReFpqRge1kQdJ5ePkrX3Ka8Q3b3gpw7coR2qIvmeirh6?=
 =?us-ascii?Q?RmUw7cpXnk+NY8ZbYnDVYTRGR5E+V3zWeMPHDMRz1fzy+O4EYfqazmeRoSkk?=
 =?us-ascii?Q?AIUliwgpKcV7KYbjViMBYUxSFfUYUdAZHfTr0/+3?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8a38b02c-6a0f-4d64-2130-08dbd3f31fb9
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 18:08:56.7062
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8YYNRkXPxzjhbsLU/NhsfU9Vnvzs8zy8KPyvh7PfiUYpeTeRYExMN/RNFwZAcMBI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR12MB9412
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 23 Oct 2023 11:09:18 -0700 (PDT)

On Mon, Oct 23, 2023 at 06:50:05PM +0100, Joao Martins wrote:
> On 23/10/2023 14:12, Jason Gunthorpe wrote:
> > On Mon, Oct 23, 2023 at 01:37:28PM +0100, Joao Martins wrote:
> > 
> >> iommufd Kconfig is only included in the IOMMU_SUPPORT kconfig if clause; so
> >> moving it out from the iommufd kconfig out into iommu kconfig should fix it.
> >> Didn't realize that one can select IOMMU_API yet have IOMMU_SUPPORT unset/unmet.
> >> I'll make the move in v6
> > 
> > I think this is some cruft that accumulated over the years, it doesn't
> > make alot of sense that there are two kconfigs now..
> 
> To be specific what I meant to move is the IOMMUFD_DRIVER kconfig part, not the
> whole iommufd Kconfig [in the patch introducing the problem] e.g.

yes

> Perhaps the merging of IOMMU_API with IOMMU_SUPPORT should be best done separately?

Yes

Jason