Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Mon, 23 Oct 2023 19:19:39 +0100
Message-ID: <86sf6142x0.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Raghavendra Rao Ananta <rananta@google.com>
Cc:     Oliver Upton <oliver.upton@linux.dev>,
        Alexandru Elisei <alexandru.elisei@arm.com>,
        James Morse <james.morse@arm.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Zenghui Yu <yuzenghui@huawei.com>,
        Shaoqin Huang <shahuang@redhat.com>,
        Jing Zhang <jingzhangos@google.com>,
        Reiji Watanabe <reijiw@google.com>,
        Colton Lewis <coltonlewis@google.com>,
        linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v8 00/13] KVM: arm64: PMU: Allow userspace to limit the number of PMCs on vCPU
In-Reply-To: <CAJHc60yGk2Gfh-GRtOE94NS0K968iGTfn_3SSMYXxbgKaA_+Pg@mail.gmail.com>
References: <20231020214053.2144305-1-rananta@google.com>
        <86v8ax4hae.wl-maz@kernel.org>
        <CAJHc60yGk2Gfh-GRtOE94NS0K968iGTfn_3SSMYXxbgKaA_+Pg@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.1
 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 23 Oct 2023 18:58:19 +0100,
Raghavendra Rao Ananta <rananta@google.com> wrote:
>=20
> On Mon, Oct 23, 2023 at 6:09=E2=80=AFAM Marc Zyngier <maz@kernel.org> wro=
te:
> >
> > On Fri, 20 Oct 2023 22:40:40 +0100,
> > Raghavendra Rao Ananta <rananta@google.com> wrote:
> > >
> > > Hello,
> > >
> > > The goal of this series is to allow userspace to limit the number
> > > of PMU event counters on the vCPU.  We need this to support migration
> > > across systems that implement different numbers of counters.
> >
> > [...]
> >
> > I've gone through the initial patches, and stopped before the tests
> > (which I usually can't be bothered to review anyway).
> >
> > The comments I have a relatively minor and could be applied as fixes
> > on top if Oliver can be convinced to do so. Note that patch #4 has an
> > attribution issue.
> >
> > > base-commit: 0a3a1665cbc59ee8d6326aa6c0b4a8d1cd67dda3
> >
> > maz@valley-girl:~/hot-poop/arm-platforms$ git describe 0a3a1665cbc59ee8=
d6326aa6c0b4a8d1cd67dda3
> > fatal: 0a3a1665cbc59ee8d6326aa6c0b4a8d1cd67dda3 is neither a commit nor=
 blob
> >
> > Can you please make an effort to base your postings on a known, stable
> > commit? A tagged -rc would be best. but certainly not a random commit.
> >
> I usually do base on a known -rc. But this series needed a couple of
> series from kvmarm/next (mentioned in the original patch), and hence I
> rebased on top of them.

Well, that commit has since disappeared, as git cannot find it (as
demonstrated above). Which is why I insist on a public tag as a base,
as everything else is completely volatile.

> How do you suggest I handle this in the future? Rebase to a known
> -rc on mainline, apply the required series, and then my series on
> top?

No. You base your own series on an -rc (ideally, -rc3). If there is a
conflict with another series, it is our job (Oliver and I) to fix it
(bonus points if you indicate a resolution for the conflict in the
cover letter).

If there is a hard dependency (something that would actively prevent
your series from working at all), you cherry-pick the minimal set of
patches that makes your own series functional as a *prefix*, and post
the whole thing, including the patches you depend on. Oliver and I
will make sure the common prefix is dealt with without duplication.

And for what it is worth, this series directly applies on v6.6-rc3
without a conflict.

	M.

--=20
Without deviation from the norm, progress is not possible.