Date: Tue, 20 Nov 2007 12:31:02 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: trenn@suse.de
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       Bjorn Helgaas <bjorn.helgaas@hp.com>,
       Rene Herman <rene.herman@keyaccess.nl>,
       "Li, Shaohua" <shaohua.li@intel.com>,
       "yakui.zhao" <yakui.zhao@intel.com>, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access
 resources in the pnp resource table
Message-ID: <20071120123102.03bdaa67@the-village.bc.nu>
In-Reply-To: <1195552283.23700.166.camel@queen.suse.de>
References: <1195552283.23700.166.camel@queen.suse.de>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 778
Lines: 24

On Tue, 20 Nov 2007 10:51:23 +0100
Thomas Renninger <trenn@suse.de> wrote:

> Unify the pnp macros to access resources in the pnp resource table

NAK

> port, mem, dma and irq resource macros are now all used in the same
> way. This is the basis (or makes it at least easier) for changing how
> the resources are allocated for memory optimizations.
> 
> Signed-off-by: Thomas Renninger <trenn@suse.de>

I really don't like this change.

_start implies an _end and an _len. IRQs have none of those features, nor
are they ranges.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/