Date: Tue, 20 Nov 2007 12:32:13 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: trenn@suse.de
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       Bjorn Helgaas <bjorn.helgaas@hp.com>,
       "Li, Shaohua" <shaohua.li@intel.com>,
       "yakui.zhao" <yakui.zhao@intel.com>,
       Rene Herman <rene.herman@keyaccess.nl>,
       akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/3] PNP cleanups - Make use of
 pnp_{port,mem,irq,dma}_{start,end,flags} macros wherever possible
Message-ID: <20071120123213.0744adc3@the-village.bc.nu>
In-Reply-To: <1195552273.23700.164.camel@queen.suse.de>
References: <1195552273.23700.164.camel@queen.suse.de>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 939
Lines: 21

>  #define pnp_irq(dev,bar)	 ((dev)->res.irq_resource[(bar)].start)
> +#define pnp_irq_start(dev,bar)	 ((dev)->res.irq_resource[(bar)].start)
> +#define pnp_irq_end(dev,bar)	 ((dev)->res.irq_resource[(bar)].end)

NAK as discussed earlier.

>  #define pnp_irq_flags(dev,bar)	 ((dev)->res.irq_resource[(bar)].flags)
>  #define pnp_irq_valid(dev,bar) \
>  	((pnp_irq_flags((dev),(bar)) & (IORESOURCE_IRQ | IORESOURCE_UNSET)) \
>  		== IORESOURCE_IRQ)
>  
>  #define pnp_dma(dev,bar)	 ((dev)->res.dma_resource[(bar)].start)
> +#define pnp_dma_start(dev,bar)	 ((dev)->res.dma_resource[(bar)].start)
> +#define pnp_dma_end(dev,bar)	 ((dev)->res.dma_resource[(bar)].end)

Ditto DMA is not range based.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/