Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1441758rda; Mon, 23 Oct 2023 12:42:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbKZ3PRwqNMW+Wupnh0qVWygd+TfhHenzLbEuOBVLxe0vvPSevADPPaXRTlRU/6baGURI1 X-Received: by 2002:a05:6a00:194c:b0:6b7:18c1:c09a with SMTP id s12-20020a056a00194c00b006b718c1c09amr7623207pfk.5.1698090147422; Mon, 23 Oct 2023 12:42:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698090147; cv=none; d=google.com; s=arc-20160816; b=XTQ+ZcUhTGSh6yXYZpnKRtob/6HRWXGTWk1SylVK9VoK32RmCwN0SQP8r3HzuitEVM ogfkd4W0Pqi6pX+TpVGN/8PiZbkNN7XUv1gvEgE3ICrRORaLRpz0miMDdNKRLHs0hBLv 8vAwLKOPwBAbvWew76v3rK5ZtUIaaCmCJEfIbKc8W2VyRvG2eZNBtDbLFCtTnbjnZOcQ DjfPUEJ2yPdFgjlUUC6+xFRBDUu5+cfP+9WYvaERpX4Ho4vhy6C45tU9KwUQb6muo/eY sUp6sQKMhDIQ5idyMAZwV0OFn2twCbx9PWo1L7TQfSnU9W0rbmctgkaEP3om+A+A0pZl nyrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=H2ftM92OKCvSHhh6kb+Glq3Mcgd9kOqth29i32E6zLk=; fh=iHDOLL3+e9PkOnYWU/AxfyJLgI/cozHVYh9KVKlRonI=; b=orA6BF+zjcVhJlHmes645fEBO2CFebaKnTqSiVnQkKMhanryZtPITqgWCCFKMgYYdA iJ/a3dsDPq4kY5zXJSpPOp4PaijYiAq7BNjGLXsohkQ9lEmJCxPgBTZq0IrOY8hdty9G /vZjsyPTNuLkAt9PH2nI94A46o9ClALM51jB5wXGU7gju4Zaznwps7P+fSzDVJ0Geoi0 d4k/jb48VOGd697rl06TNlEZ8jwCPitf+NrUoEmrugbrrBUo3b1iOwdjL0aOFDD0wyKD CeNzhLBrEiJq0R6wSkKh+3VKN7K+Fhs7Op1p76RWXe6cc2YJxs4ficbHfI0FAfQKPNGe k9Kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=nSFIIjZl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id j63-20020a638042000000b00564d6ad2746si6916163pgd.452.2023.10.23.12.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 12:42:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=nSFIIjZl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id C931A8068238; Mon, 23 Oct 2023 12:42:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230316AbjJWTmS (ORCPT + 99 others); Mon, 23 Oct 2023 15:42:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230081AbjJWTmR (ORCPT ); Mon, 23 Oct 2023 15:42:17 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E048B4; Mon, 23 Oct 2023 12:42:15 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-5079f3f3d7aso5841836e87.1; Mon, 23 Oct 2023 12:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698090133; x=1698694933; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=H2ftM92OKCvSHhh6kb+Glq3Mcgd9kOqth29i32E6zLk=; b=nSFIIjZlgDhwPVaKTaBCbptV3T9XiW4JVcjIokitb5AsuggcKlc3vegyu+Lddcngcx mR+92B42ET6SVpnAKtSq0geUZy5dBmDcJkGtsKBpmhr0DGbYtojdqTz/URbVj5gTs3gS hIcenGMJI0zQvCXWfd+CAlvJ5Zb0NugogPiILU5wD7FnZh9cT5wq4F1MZVdKSzoTS4Fl rCF/g6XoJZWbE6ptJEC8gJB2BwJrScXjHIsErcOVVRWte4Sg3sNjCqxXoeql1oRuQdgk TdIbuhZq5WsCPin5uK9wkEybyiKw88w8HqpWwT3H5X0E8h+ATJ5ZyHk9Oo/ybCo6wDOD CRDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698090133; x=1698694933; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H2ftM92OKCvSHhh6kb+Glq3Mcgd9kOqth29i32E6zLk=; b=seIwQA2ocMF0I0rcWzLGN/fAvHjCQFoyCeaO4yy++I85gAHWjitUU5pJ3MS3osmuQq KBcNRad7ts084OpoTsfjBQPGawitgwqS5XFAC2yp/6cUd51RMxTU+RkEoCgUMgtoj/EE qIQpIUngPMfNykzmauGGvAPttqtTHUQx7ieNI8sL8nRmFPpaEbv88I81EW4ClJ6DfXfT VZwxW21dGb7z8EAI8tn319VaiSGmLY6s1lGUCoc2rj4FkWZW5iOt/An+cR1zBv0NaZJy CAycQkPysaxs/OntXv+U/OQFItPSHWglf6IzUJnJEBmEyA78cn/DgDw0US4cgB7jcqgm w+WQ== X-Gm-Message-State: AOJu0YyN9k/7I54pI3kbaxp4vYQSgjN5EB+SZpNmfqKYK/rKG5ukrCPg Sr5c9Wvrbn1AX7MZoChm65NzOixlOg8dza40+es= X-Received: by 2002:ac2:5edb:0:b0:500:aed0:cb1b with SMTP id d27-20020ac25edb000000b00500aed0cb1bmr7346416lfq.24.1698090133099; Mon, 23 Oct 2023 12:42:13 -0700 (PDT) MIME-Version: 1.0 References: <20231023-topic-adreno_warn-v1-1-bb1ee9391aa2@linaro.org> In-Reply-To: <20231023-topic-adreno_warn-v1-1-bb1ee9391aa2@linaro.org> From: Rob Clark Date: Mon, 23 Oct 2023 12:42:01 -0700 Message-ID: Subject: Re: [PATCH] drm/msm/adreno: Drop WARN_ON from patchid lookup for new GPUs To: Konrad Dybcio Cc: Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Marijn Suijten , Rob Clark , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abel Vesa Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 23 Oct 2023 12:42:25 -0700 (PDT) On Mon, Oct 23, 2023 at 7:29=E2=80=AFAM Konrad Dybcio wrote: > > New GPUs still use the lower 2 bytes of the chip id (in whatever form > it comes) to signify silicon revision. Drop the warning that makes it > sound as if that was unintended. > > Fixes: 90b593ce1c9e ("drm/msm/adreno: Switch to chip-id for identifying G= PU") > Signed-off-by: Konrad Dybcio > --- > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h b/drivers/gpu/drm/ms= m/adreno/adreno_gpu.h > index 80b3f6312116..9a1ec42155fd 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h > @@ -203,11 +203,6 @@ struct adreno_platform_config { > > static inline uint8_t adreno_patchid(const struct adreno_gpu *gpu) > { > - /* It is probably ok to assume legacy "adreno_rev" format > - * for all a6xx devices, but probably best to limit this > - * to older things. > - */ > - WARN_ON_ONCE(gpu->info->family >=3D ADRENO_6XX_GEN1); Maybe just change it to ADRENO_6XX_GEN4? BR, -R > return gpu->chip_id & 0xff; > } > > > --- > base-commit: e8361b005d7c92997d12f2b85a9e4a525738bd9d > change-id: 20231023-topic-adreno_warn-42a09bb4bf64 > > Best regards, > -- > Konrad Dybcio >