Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1487938rda; Mon, 23 Oct 2023 14:18:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFihZRJ93xv4jznTGT1Bw8oCs6AjjOX7SM9crpceQCI4OICnuaRTSd2nVPmWLUeXiQMAzhM X-Received: by 2002:a92:d84a:0:b0:357:8d71:347f with SMTP id h10-20020a92d84a000000b003578d71347fmr10928836ilq.8.1698095890300; Mon, 23 Oct 2023 14:18:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698095890; cv=none; d=google.com; s=arc-20160816; b=rjN9gM6uUV0gxKu+WtCs45M039gEwA+Pipbb4GeK9DAPV7PmLw7xzwYdL6waGBIeL5 EhYGc4oo/AxQTmEHiAAuf1dzM6gPTNlVV24/rYa2tiBBqts5bzvt5VrObDuwxGg3inhS hLVyLrtxlVe4He2Uq/IPNihuju2H3hTP5U537NE04uFgOU3pHTNey0xe1m8457kIFQfs YEWIRJMQOqfZ67hfTY4LzQBofklpJOVV9klAxN9LvkGUbyM0K9ApXJ/fNkBYjUyg5JvH alBG3pMGWR+HMq1P9XCtEgkHo7VvWqfsZ16e8nZSIALMrSD8c3hI8SGRuA6lMgR3djhX MqVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=5P4u4xnlOQ5WlKE6Yaubko497DQUXHVtxijrqRqpyA8=; fh=xbnTKJzsb2UpKrn+8RcI1jrZUmh3TZBz93BSfBKhj2g=; b=VUnJuDVAZfRLgq1Y06wOdLirby2h5om6FyhKUOmtaE0IfKr6R+UKjj/MvYsW2iuoE2 vd+za3Y+9eOjuw+Kzz0/gfhFYQzXKrUB6Rqjg2Z/NvOiDE5X3WeSak7jd1DYtrbX+1kH SSsnpJlqq0Ub6fvyO2MJ2jwHZ5QmnruTcSNvUVKtpXC5gwd2ZcpfOIH2DfzivXYgjw/Q RVfAkNYerCT9Y+K4hYtXAarYQZAlB2IyUMM638rKBXtL1fC77dgXiGumCIkYq1nSzI9P 38pgCUMCgfSa8WjMN2gHofLi7naV56nTb62hG4zKm3y76Pa9TA5fQj/pNUSfjOLaTCnQ AI4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Acqh5PuR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id i184-20020a6387c1000000b0057d08dac75csi6848852pge.517.2023.10.23.14.18.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 14:18:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Acqh5PuR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7FB9D8031121; Mon, 23 Oct 2023 14:18:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231289AbjJWVRk (ORCPT + 99 others); Mon, 23 Oct 2023 17:17:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229657AbjJWVRi (ORCPT ); Mon, 23 Oct 2023 17:17:38 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B476DD; Mon, 23 Oct 2023 14:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698095857; x=1729631857; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=3Nldbc9tzSnQAq+doK1Q2lJrQIRVG5t3dRjDQwEw19w=; b=Acqh5PuRU0JDvWDni5flFQCW3LAvHuch3d9KBbiq3EdiAn5vDPwvlVRO P/1tFU9WikGrU3L4mdhq9su+Nz52MkfOENkA1RQLMhrDyWcnNYbmpcCyb 2drp7Nkn1kdKesl927JCLoertOFrGzpn7JHDAUA2KCjquY2KemXyp6tGd hktTy2V5EvShHokwel8tHJfad1YsoWedkUq9K9FbqFyqPoiACXy720JQv 9E2vHem9E0J8qmOu0maNfQGFLUoCC58xRooqdVsIKw0VuiYNTNkIJW7gC xaeWYyYq1IamMPF0q1QW1KIl4JR2Sav/3N70Ytbk4Q9TImHWl9GVV+uq/ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="377307911" X-IronPort-AV: E=Sophos;i="6.03,246,1694761200"; d="scan'208";a="377307911" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 14:17:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="824084736" X-IronPort-AV: E=Sophos;i="6.03,246,1694761200"; d="scan'208";a="824084736" Received: from qwilliam-mobl.amr.corp.intel.com (HELO desk) ([10.212.150.186]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2023 14:17:34 -0700 Date: Mon, 23 Oct 2023 14:17:25 -0700 From: Pawan Gupta To: Josh Poimboeuf Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Peter Zijlstra , Andy Lutomirski , Jonathan Corbet , Sean Christopherson , Paolo Bonzini , tony.luck@intel.com, ak@linux.intel.com, tim.c.chen@linux.intel.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, Alyssa Milburn , Daniel Sneddon , antonio.gomez.iglesias@linux.intel.com Subject: Re: [PATCH 6/6] KVM: VMX: Move VERW closer to VMentry for MDS mitigation Message-ID: <20231023211647.lgebgvt622zemg6y@desk> References: <20231020-delay-verw-v1-0-cff54096326d@linux.intel.com> <20231020-delay-verw-v1-6-cff54096326d@linux.intel.com> <20231023185643.oyd4irw43ztdqtps@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231023185643.oyd4irw43ztdqtps@treble> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 23 Oct 2023 14:18:02 -0700 (PDT) On Mon, Oct 23, 2023 at 11:56:43AM -0700, Josh Poimboeuf wrote: > On Fri, Oct 20, 2023 at 01:45:29PM -0700, Pawan Gupta wrote: > > @@ -31,6 +32,8 @@ > > #define VCPU_R15 __VCPU_REGS_R15 * WORD_SIZE > > #endif > > > > +#define GUEST_CLEAR_CPU_BUFFERS USER_CLEAR_CPU_BUFFERS > > I don't think the extra macro buys anything here. Using USER_CLEAR_CPU_BUFFERS in the VMentry path didn't feel right. But, after "USER_" is gone as per your comment on 2/6 patch, GUEST_CLEAR_CPU_BUFFERS can also go away.