Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <6ddcac19-70c1-4f94-ac11-9d864721ff62@redhat.com>
Date:   Mon, 23 Oct 2023 23:29:23 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [Nouveau] [PATCH] drm/nouveau/dispnv04: fix a possible null
 pointer dereference
Content-Language: en-US
To:     Ma Ke <make_ruc2021@163.com>, kherbst@redhat.com, lyude@redhat.com,
        dakr@redhat.com, airlied@gmail.com, daniel@ffwll.ch,
        tzimmermann@suse.de, noralf@tronnes.org, mripard@kernel.org,
        jani.nikula@intel.com
Cc:     nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
References: <20231013011850.103967-1-make_ruc2021@163.com>
From:   Danilo Krummrich <dakr@redhat.com>
Organization: RedHat
In-Reply-To: <20231013011850.103967-1-make_ruc2021@163.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/13/23 03:18, Ma Ke wrote:
> In nv17_tv_get_hd_modes(), the return value of drm_mode_duplicate()
> is assigned to mode, which will lead to a NULL pointer dereference on
> failure of drm_mode_duplicate(). The same applies to drm_cvt_mode().
> Add a check to avoid null pointer dereference.
> 
> Signed-off-by: Ma Ke <make_ruc2021@163.com>

For this one and the previous patch, please add the corresponding
'Fixes:' [1] and stable [2] tags and split the commits accordingly.

[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
[2] https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

> ---
>   drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
> index 670c9739e5e1..9c3dc9a5bb46 100644
> --- a/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
> +++ b/drivers/gpu/drm/nouveau/dispnv04/tvnv17.c
> @@ -258,6 +258,8 @@ static int nv17_tv_get_hd_modes(struct drm_encoder *encoder,
>   		if (modes[i].hdisplay == output_mode->hdisplay &&
>   		    modes[i].vdisplay == output_mode->vdisplay) {
>   			mode = drm_mode_duplicate(encoder->dev, output_mode);
> +			if (!mode)
> +				continue;
>   			mode->type |= DRM_MODE_TYPE_PREFERRED;
>   
>   		} else {
> @@ -265,6 +267,8 @@ static int nv17_tv_get_hd_modes(struct drm_encoder *encoder,
>   					    modes[i].vdisplay, 60, false,
>   					    (output_mode->flags &
>   					     DRM_MODE_FLAG_INTERLACE), false);
> +			if (!mode)
> +				continue;
>   		}
>   
>   		/* CVT modes are sometimes unsuitable... */