Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <7531aae8-c523-45e1-a9e3-bdecb485a00b@intel.com>
Date:   Mon, 23 Oct 2023 15:01:21 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next 2/3] i40e: Add other helpers to check version of
 running firmware and AQ API
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>
CC:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>,
        <mschmidt@redhat.com>, <dacampbe@redhat.com>, <poros@redhat.com>
References: <20231023162928.245583-1-ivecera@redhat.com>
 <20231023162928.245583-3-ivecera@redhat.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231023162928.245583-3-ivecera@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUdhM2VBUElZMm50SG5nZW9zS2Rwc0V3OERUeUZIK0UrOWlVTHdNSGV2ZWVO?=
 =?utf-8?B?MVd3eVFwOW5nS2IvSkpNS1loL0ZyNHZ5OVYzSU9Ka0pBOUR1TUtPWmJVNDZn?=
 =?utf-8?B?eStROWNZTmF0bEF1bU5UOS9ncHRvam5NSnJqeEJMSXdTY1p0cXp2bG1QRWtz?=
 =?utf-8?B?aklGYzBicU9zcVVxSjZRQW53TGRQMUUvRVVHNFlJM0xIUEVWQjlkMDdSTi81?=
 =?utf-8?B?SEcvUmRvcU9DQ1lwajdtTHFXa3NEUS95djZRRkxFakZJRzQrZFY0WWREa3d2?=
 =?utf-8?B?OVhISkZMSjlaMk9ROW9mdnBXcE5oMGFmNkVTMXJQMHJKYkNxQWhnMVV4UDE2?=
 =?utf-8?B?c3MyWXgwMGZDSUFpdkZEMHR5TTZXUjFoVWM1NWY2OWF4c3VDVEp1QjZUU1c4?=
 =?utf-8?B?T001Ukt0bTcvc3hFT2h0aGdsYzRvVlBsSGhSazhkVHFjYXh5MGY0aGdQQ0do?=
 =?utf-8?B?YTVraW5XN05POGpvVFpRUzJJUG8zNHhEMzBiZVBOQ3hLcHNnTFdzTlZWTjVa?=
 =?utf-8?B?OXlncDR3UDVkUkl4dmo3YjI5RDUrVWE2OFJKWHdBcEVhTGtNK1JqR3lGZlBw?=
 =?utf-8?B?d2ljNkN5ZFFjMFJKZmloeEthRlFUR3NoUE1mVnZGZ2M0cVRXMms0VlFEczVi?=
 =?utf-8?B?eXJZOG13eHhlTmNvNlljYXNEKzhLN0gza0pmL214N2ErNEY0WUlObUNFQzJX?=
 =?utf-8?B?VFRPQUZYS0NwMFpZaDBEQUFBcHhLRzhqRUp6WjdYZW9MZ1NYbjluN0dhMVZQ?=
 =?utf-8?B?VExHaXJ6UndJMXZ5eWYxb29oamhtV3VyVmlIT1JUSmg2cWltQTRReHZmTVRE?=
 =?utf-8?B?VXFNNkhlVUFjQXhyY0ZkNGlYU09kaXRFYlU0eUZLKzVuUjVMUnlBYk0zNXZV?=
 =?utf-8?B?OW5qcUtrQ3VwaHJqWm5JTG9SMzJOOElZTjdvamJ6dEVSbTlGUVl1WCtUY256?=
 =?utf-8?B?ekRReDhjV1lqOTY1eGlDeDB5aXJtUFhESGJSTWQ1dTRPRjVqM3YrT3gxc0VM?=
 =?utf-8?B?OUJmVExMQW9pY09tNlJScWMrTEN2OEVMd284RnhxTWd0eHFNaW1nVDZXeTI1?=
 =?utf-8?B?L0k1WXNML1BXNU5KM0pvS29KOXAyLzlPUjRKeXAvNHBEbDRwYmpSSzVGZURn?=
 =?utf-8?B?VU9KRzVSby9NSGh2bzd1VmdabkRkMnVHK20yR0xMOXlJaWQxamdsRXQ0c2ti?=
 =?utf-8?B?aUJJZlQvZlRZYmRHRjBjcGJRVmgxcUFYaVpNVnZ4M2E3aGtUSXVLd0Vkekp3?=
 =?utf-8?B?K3lQd1JMN1FiL3JjdmxyNlRzaSsvQ2NxWmRBVHBncUROYk9zbjM4ZDM0MmxQ?=
 =?utf-8?B?bWZaOEtWWm9ZQUlIc29UYWRXSTVndjE3QlF1aWszTEhwT1hoMkFFc0N0YkFa?=
 =?utf-8?B?QWl5c1lDLyt6YWdVYkkvRjAzYlVYdXdrWTRtVzRwbnIrZGw0R0hZTmk4TkN3?=
 =?utf-8?B?elBlOFF6UkVQWFE2RWgrQnV2WlFoTSt4SDdVRk1xaGpnSlpzOU1vbnJMNXNo?=
 =?utf-8?B?TUpmc0pRVjdTeStsVEQ3Sm50ZEFKSUlrNlhiR2RSNitxV3BwYTN2L2ZwSWJL?=
 =?utf-8?B?UTg4eGpKdCt4ZnpPbzd5WnkySGRMUnRkejNqTFNOUWNwSDJQaEora3REM0Vw?=
 =?utf-8?B?VzErUjBXeTIyN1NiZlYrNnpyMFBFemtEWVMyVUF6WHplaC9MUjlrS2lVTVZO?=
 =?utf-8?B?cU8xMDRxMlRKWi9tTFZIUFkxcE1zSVlsTUhFYkloSjlyaTRySkVGRFVYKzg3?=
 =?utf-8?B?QXZTT3pSbUl1MFBlVVhUeHBjK01KOTNmYU5RVlJRS3lpQ0tWWnh3a2w0Tno5?=
 =?utf-8?B?ZGkzR1dxNllEbGwySDRkaEl4SWlpblZpdStXRnptRS9ZTmhrdVFERTU5QXRS?=
 =?utf-8?B?OFdqdmsrckpkOEQ3QTdseGFOZ0cyK0c4eUI3bG9Bd1ZFU29IU1Y4V25rdE5X?=
 =?utf-8?B?d0hWRDBFUjdlMDVmU0hWd3lRYTdRZ3JIUmFmUTlBUFBYUUNRbk9vMHMrcTE4?=
 =?utf-8?B?OUFrNFB2ZXByZjJuYTB0NUg3OHVuWGFaRnE5VjZ0cE1QWjNCN2YvUHd2YTc4?=
 =?utf-8?B?a1ZTb2NCNy8zV2t2RXg3dTZ3N2YwTkZieDNERElvMVo5cklUbkpGa3d6WER6?=
 =?utf-8?B?RUtEalZlaSswVXBkNE1uSmhxOXFYRUlzMmNOaXF4dzJSb3ZWeU9GM0lMemk2?=
 =?utf-8?B?ZGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e3d4dc7c-888f-4766-5d6b-08dbd413992b
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 22:01:24.8364
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GgQGfkEguWvFzuyy3Rbiv6fQuS2edPBVUEUzyP/foRRKGYpFhSjFgo1PCPgiQh1FsIBP+mhoIQ2YhCUtcH4uHpaDkna+h8S/RhwALansCrg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB5700
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 23 Oct 2023 15:01:46 -0700 (PDT)


On 10/23/2023 9:29 AM, Ivan Vecera wrote:
> Add another helper functions that will be used by subsequent
> patch to refactor existing open-coded checks whether the version
> of running firmware and AdminQ API is recent enough to provide
> certain capabilities.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_type.h | 54 +++++++++++++++++++++
>  1 file changed, 54 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_type.h b/drivers/net/ethernet/intel/i40e/i40e_type.h
> index 050d479aeed3..bb62c14aa3d4 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_type.h
> +++ b/drivers/net/ethernet/intel/i40e/i40e_type.h
> @@ -608,6 +608,60 @@ static inline bool i40e_is_aq_api_ver_ge(struct i40e_hw *hw, u16 maj, u16 min)
>  		(hw->aq.api_maj_ver == maj && hw->aq.api_min_ver >= min));
>  }
>  

This has a bunch of checkpatch.pl warnings if you wouldn't mind fixing them:

> ERROR: inline keyword should sit between storage class and type
> #47: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:632:
> +static bool inline i40e_is_fw_ver_ge(struct i40e_hw *hw, u16 maj, u16 min)
> 
> ERROR: code indent should use tabs where possible
> #49: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:634:
> +        return (hw->aq.fw_maj_ver > maj ||$
> 
> WARNING: please, no spaces at the start of a line
> #49: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:634:
> +        return (hw->aq.fw_maj_ver > maj ||$
> 
> ERROR: code indent should use tabs where possible
> #50: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:635:
> +                (hw->aq.fw_maj_ver == maj && hw->aq.fw_min_ver >= min));$
> 
> WARNING: please, no spaces at the start of a line
> #50: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:635:
> +                (hw->aq.fw_maj_ver == maj && hw->aq.fw_min_ver >= min));$
> 
> ERROR: inline keyword should sit between storage class and type
> #61: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:646:
> +static bool inline i40e_is_fw_ver_lt(struct i40e_hw *hw, u16 maj, u16 min)
> 
> ERROR: inline keyword should sit between storage class and type
> #74: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:659:
> +static bool inline i40e_is_fw_ver_eq(struct i40e_hw *hw, u16 maj, u16 min)
> 
> ERROR: code indent should use tabs where possible
> #76: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:661:
> +        return (hw->aq.fw_maj_ver > maj ||$
> 
> WARNING: please, no spaces at the start of a line
> #76: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:661:
> +        return (hw->aq.fw_maj_ver > maj ||$
> 
> ERROR: code indent should use tabs where possible
> #77: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:662:
> +                (hw->aq.fw_maj_ver == maj && hw->aq.fw_min_ver == min));$
> 
> WARNING: please, no spaces at the start of a line
> #77: FILE: drivers/net/ethernet/intel/i40e/i40e_type.h:662:
> +                (hw->aq.fw_maj_ver == maj && hw->aq.fw_min_ver == min));$
> 
> total: 7 errors, 4 warnings, 0 checks, 60 lines checked
> 

Thanks,
Jake