Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1527442rda; Mon, 23 Oct 2023 15:53:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEt94OL2ZZoefheVaIZO387phXTUOZmGb5lLwjjiZMoLCdGUNRlPptQuQVMPZIh8syLGRjw X-Received: by 2002:a17:903:2450:b0:1ca:2ec4:7f3f with SMTP id l16-20020a170903245000b001ca2ec47f3fmr8938872pls.45.1698101619232; Mon, 23 Oct 2023 15:53:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698101619; cv=none; d=google.com; s=arc-20160816; b=TaQ7crZhvI+frZUQmmIM6XiKoAEVa8cwcee1X6lErGViD/osTBapqHTeZ7TTAhudc3 FyNAWjo26BC1uOql/rTXtEXkzi662p2xSEpCVVKv/PLXpopOTaZG1XjxGuXLTRdgL+Xs S77+ZdibBu8WVRoAQUMfm5SKUb+iYb72YsTVt9eTzrENUwSwj9JLmRqusm1BTTfTvOe0 kNZy42v15W2d6cNNm943zXpR6xECjADNSSFEvpoX/velE6Tn5ARHrN52vgpF4jEcxUm4 wVSMVYPYp+yNsokksXIAj9XiHfUEBpABbSKZ+L+zcAhNXJ0/VSSS3uqQSbmjD7gSTOnr yTBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=DKSpEmZXWmRF29MNGZuumHcdacLeWDMvW6V/OJxnx4g=; fh=mFrsfO98O2cE8r3pwsGAYJXoMokEWoIJfNXepM6BcDk=; b=eg/fgCWTMVH41w8bep5kt55O3YeXq7+tR59eImuVa17/cAHKhjkSVCktejvqoWHRLs Il99hfH4zILPylJZhZ4io1H8ZqDnD09HH/fiMglhx1B9ZoL16aaqBafHIz5HaYMqeCuJ 1hYUVyRLA18T3Txqr6Ye/xOh2eKpTKVyFWoIJRun4m/z7/mbAt+ufnIgEnTtgn0xFmRg qER5AUwl4aZ23/W4LCMUhaDouvDBuPeHHjU4r8T1z6OR7k8n3kxac/GJL9kCCuj2iG41 IlQ64C+BsS2zTidv26/KsdWxtYxKONRq3l/Ue9MK8kfzOPAmZZKhOzvivVRPw21KY/xF AS0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="g/ZQMPtf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id w4-20020a170902e88400b001c9c9e6371fsi7242043plg.527.2023.10.23.15.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 15:53:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="g/ZQMPtf"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id E3C608031132; Mon, 23 Oct 2023 15:53:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230483AbjJWWxS (ORCPT + 99 others); Mon, 23 Oct 2023 18:53:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229853AbjJWWxR (ORCPT ); Mon, 23 Oct 2023 18:53:17 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE5AF10E for ; Mon, 23 Oct 2023 15:53:15 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 158DAC433C7; Mon, 23 Oct 2023 22:53:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698101595; bh=2p2vYId+/XkAtr85GFeTQzGPwyHJushD8tZW2QZ/NCs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=g/ZQMPtfTk56Ys0Dbu0IxS8q5MWeRF0Do42hnKDF2NObWX8rz3+qy4jA02r7dZ6Xs w0v2g3rnNrL66Ak7jZAiSeLaUp0tpW3phpaF4ILKGez5gaX+Rd0c53i7omLjVFrwbb PQGOQBtPpN7x6afTja9y8fQSUJ8kDRVZWJ8F+ralL99LM7rGZQLOGXP4UHg3i70IBg 75MbecLbZZdzpSYihBW7LYvjciHOYOvIH7gzoOpX9i/O5SzrJgi9NyhEgjO8JRbXJ5 PxpIAaA7cK/xzk1ANn6/sA39le33Uw+I3I31PO1uqLfZi77U4zeR3FUObDwgwbxOHM RYeS2uXPXeL8g== Date: Mon, 23 Oct 2023 15:53:14 -0700 From: Jakub Kicinski To: Shigeru Yoshida Cc: jmaloy@redhat.com, ying.xue@windriver.com, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, syzbot+5138ca807af9d2b42574@syzkaller.appspotmail.com Subject: Re: [PATCH net v2] tipc: Fix uninit-value access in tipc_nl_node_reset_link_stats() Message-ID: <20231023155314.50b13861@kernel.org> In-Reply-To: <20231020163415.2445440-1-syoshida@redhat.com> References: <20231020163415.2445440-1-syoshida@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Mon, 23 Oct 2023 15:53:37 -0700 (PDT) On Sat, 21 Oct 2023 01:34:15 +0900 Shigeru Yoshida wrote: > Link names must be null-terminated strings. If a link name which is not > null-terminated is passed through netlink, strstr() and similar functions > can cause buffer overrun. This causes the above issue. If strings need to be null-terminated you should switch the policy here https://elixir.bootlin.com/linux/v6.6-rc6/source/net/tipc/netlink.c#L91 from NLA_STRING to NLA_NUL_STRING, no? -- pw-bot: cr