Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Mon, 23 Oct 2023 20:05:09 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     kevin.tian@intel.com, joro@8bytes.org, will@kernel.org,
        robin.murphy@arm.com, baolu.lu@linux.intel.com,
        iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
        yi.l.liu@intel.com
Subject: Re: [PATCH v3] iommufd: Only enforce cache coherency in
 iommufd_hw_pagetable_alloc
Message-ID: <20231023230509.GI3952@nvidia.com>
References: <20231023185700.11407-1-nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231023185700.11407-1-nicolinc@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sRnaZzpNMh5+hSu5W+t6F2jGwumzu8fQcQwXhQ2O0ab8nzJuPuG/zXFLJMt4?=
 =?us-ascii?Q?9fmyGzm32jQqv05TGGRxwgwrWUm+i/SdyzL9UFq1HJdVnxDVO9Vs2YLEI6ZW?=
 =?us-ascii?Q?O+OV/G4zKA+DjMd/+XJcFqZKePZG9nBV5QKWnGyodMTgalaMFtWB3k4vloY1?=
 =?us-ascii?Q?ORu6xctUqUAv1FplZ6Ib54j0JDi1Th2a2aU/2j9sjDat6BBhYqY5RXrpy+q2?=
 =?us-ascii?Q?7CrobWeOiyBFuecurlStZ/zceOCtAZLRfHXLTkdeZwrlq0rvoaPYlmra0pur?=
 =?us-ascii?Q?4DXQ4URsL1Rb1NjExzJAwkegEniLzDU5rVQKxCWP9qPaWe4sh0zqVK4kQqHW?=
 =?us-ascii?Q?xwTZmiezK5gjuYmEpE0QIup3c1WkaotjVdXN1qOaiR2/4MbYsnMEVK4/UY3y?=
 =?us-ascii?Q?WTxkXFGu9j21Z36lMvwKum2LQcGb0Pz+jCCRHWXE9nqiLV4LBethCoKHMQkK?=
 =?us-ascii?Q?T59ccManjoxSUuLKNH0WXUzBHVmsTHvLicBZg57kiXGWEtspGbHVAII8I8D+?=
 =?us-ascii?Q?GUMPpw9gb+LtKFxJZhTKckngq1vK4CdyIj8Udy4oU7+cNoU19l0/F0CelrMw?=
 =?us-ascii?Q?DUde4k/0DUFyxVB/3tpxwv3QnnQM2e1ItnA7hTZe5OfAqd2TvZGqLQ2E2Gbf?=
 =?us-ascii?Q?MB/OO7ceokjcuPogxHg3UaYXFqGrBR8UFv4wXmeW8fVMO9T3drz54mQ7GFfV?=
 =?us-ascii?Q?aJioRTj1Ukci/fcmbDPWGnglxTWByy2tZtf1OAJS+Rkiv7ruJ/9+yfcexlZq?=
 =?us-ascii?Q?7/BqMjPO49S8Rro8mvw64jYun4k11QkwEuLiVH2oPcTNczWZlNo1mKFmJ0NG?=
 =?us-ascii?Q?IP7P2phu5G+wloy0Ak0Uvd4CHlIkfaoXlA4svR+vTHwInh3pWWv8vRstKLNa?=
 =?us-ascii?Q?BmePrgbBhugt2WXK7E9eyZZqqTbDoZrRb8inYsKuWTkXCjCYDMVugCUEnNOi?=
 =?us-ascii?Q?0k9GNE7URB7zKlvIkQ4+WvV5lQCyENHnINugc56EL0Y+FhpftcY0QfdSIenG?=
 =?us-ascii?Q?cPancdl0xRdFspZXHZX0PdvSlO2FslVAeuQLA75hp3lR7chvrhvKYH0q8wH2?=
 =?us-ascii?Q?EdUcCI9wFnUpIN9giJnWdnsYrjhUjlKedJSo1+z89O3EUZJ9Pzf1Tuwz/sls?=
 =?us-ascii?Q?ud9SaQ3ywEaLVWmDq9KHXH2zTaymyy4DlkUcVq566JRjiH1FyjKz5QFokUlt?=
 =?us-ascii?Q?t0zwX8t6hYJC66TyeDCj1K5rLWgi3loJUqEx9DpAZbKHxK2Y0w74MdDIPY81?=
 =?us-ascii?Q?Mx3JBXhtcqBIaUSAanUrvcBEFcanbENYTjDOKyKNy3WWVk9i7OXQbV4f/ViL?=
 =?us-ascii?Q?S2Ki4bIYk7CPK1hA8VhoNufSAO8L2q57Ikj9vEaoRJ7etnUaYm3oss0RB+g3?=
 =?us-ascii?Q?Vibywg6IJozdfiWkGWo2jFvSD0VWOWZ0JWh1rlRLfLA83LhsOXEYAAOlU19w?=
 =?us-ascii?Q?HAXNuU1ZehgqAWsZqNaSoLVrGXGYk3/LG1oDep1r68JPPue72DcNB0h5oxNa?=
 =?us-ascii?Q?aJNPuFJdwb6yyJogtNlku6/BPwpJXGvnrrTICtovNIug2pI1qJE0GmwYtpAI?=
 =?us-ascii?Q?Mk1PAhMfVAbQrnjRqPZQjQQ3SJgMhg4aBtVbF5vN?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40649f8c-680e-496b-6bec-08dbd41c81d6
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 23:05:10.9151
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /S2k8UoTIp4qPINJ/9/TQnexilp9D6PKAMuG70tFHXmDHISkz9EnrSkF+sS3kN3W
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7654
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 23 Oct 2023 16:05:20 -0700 (PDT)

On Mon, Oct 23, 2023 at 11:57:00AM -0700, Nicolin Chen wrote:
> According to the conversion in the following link:
> https://lore.kernel.org/linux-iommu/20231020135501.GG3952@nvidia.com/
> 
> The enforce_cache_coherency should be set/enforced in the hwpt allocation
> routine. The iommu driver in its attach_dev() op should decide whether to
> reject or not a device that doesn't match with the configuration of cache
> coherency. Drop the enforce_cache_coherency piece in the attach/replace()
> and move the remaining "num_devices" piece closer to the refcount that is
> using it.
> 
> Accordingly drop its function prototype in the header and mark it static.
> Also add some extra comments to clarify the expected behaviors.
> 
> Suggested-by: Kevin Tian <kevin.tian@intel.com>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
> Changelog
> v3:
>  * Reworked the first line of the added commets.
> v2: https://lore.kernel.org/all/20231023035733.27378-1-nicolinc@nvidia.com/
>  * Dropped "fixes" tags and merged two patches into one (Jason)
>  * Added comments to the remaining enforce_cache_coherency call (Jason)
>    [Please feel free to rephrase, or let me know what to change.]
>  * Replace "num_devices++" with list_for_each_entry (Baolu)
> v1: https://lore.kernel.org/all/cover.1697848510.git.nicolinc@nvidia.com/
> 
>  drivers/iommu/iommufd/device.c          | 20 ++------------------
>  drivers/iommu/iommufd/hw_pagetable.c    |  9 ++++++++-
>  drivers/iommu/iommufd/iommufd_private.h |  1 -
>  3 files changed, 10 insertions(+), 20 deletions(-)

This looks OK to me, Kevin is it what you think it should be now?

Thanks,
Jason