Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <97e1f76a-3505-4783-838a-10b9cacee8bd@intel.com>
Date:   Mon, 23 Oct 2023 17:14:17 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH V2] net: ethernet: davinci_emac: Use MAC Address from
 Device Tree
Content-Language: en-US
To:     Adam Ford <aford173@gmail.com>, <netdev@vger.kernel.org>
CC:     <aford@beaconembedded.com>, Andrew Lunn <andrew@lunn.ch>,
        "Grygorii Strashko" <grygorii.strashko@ti.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>, <linux-omap@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20231022151911.4279-1-aford173@gmail.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <20231022151911.4279-1-aford173@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0p5WmtkZ3ZHTWY4YVZ1MFdhbGNncGErZlFDSytzeEZmZXpmVmx6eDc4Y2RT?=
 =?utf-8?B?dGd6V3hkYWpRUDVpNi9FN1lyTDV5bmE2VkVkTmUyOXFmYWM3aVdyd091YThH?=
 =?utf-8?B?bk9OeTV4allFbjdXRmtHQytzdTBNdmc3c1V4QmdBeCtZSUlZeTArMDJMVXUy?=
 =?utf-8?B?M2xIUUwwT3dycFJ1QnhnRFR6OWkyUzJxQmdNOEhjMGZoVllHNkZYSDhRWkxy?=
 =?utf-8?B?UDdxaElsUW04ck92N2pNZ04wdTNDd0JZVThZem9XMjhBNzU2ZG1lTmphRnp2?=
 =?utf-8?B?cFQwR3VSVjU4ZlhxRDFtN0ROMnJCM2MxRmR6SHRoY1NZamtXZEJveGwweXVx?=
 =?utf-8?B?dElleWx0bEdPYUsrWlNibUVuSmp4MU43ZC9UUFdqQWtmMFROcHlVczNFTUJ1?=
 =?utf-8?B?RVN6L3h0a0x2dkRxSHpBdUN2Y2crbWw1dVlxUXhEbkR6bExnM2V4RjVRcnpZ?=
 =?utf-8?B?TTJWWVFxeU5XN0lMOVNNNkNUeE5jUkxTVjVaUytNby9MeEdtbjlYUWV0MDFY?=
 =?utf-8?B?eGM5Z0w3S3NrdzQ3dnhSQ2RkdEZyeCtMU25zMWdqaXh4eGF5aW5JRmJYN0F2?=
 =?utf-8?B?cnNNeVNLcjR5eUVKWmxQYmhabzFSYXR5dFN0anRURndyajNEcG5YRnFtb3lL?=
 =?utf-8?B?M3BQRVhUTDdSd0FxS0JjSmV1TE5MUHM0NWx1M2NzbHhOVXcxWFB2VWlpZEIx?=
 =?utf-8?B?aEhUcWJBUjFiZXhMeDNCWEJWY3plYjljTUxaWGYzSW9OMklpdzJ6ZmVKOVhC?=
 =?utf-8?B?SHZ0UDd3TldMZGk4NE9BOFp6azY5dTFKNk9OQ3krU1c4WW56OEMrM0FvR2ZR?=
 =?utf-8?B?WUcveXNXU0VNdmppVjEzZ2JoY3RsSDVtUnZaN3BCeXV5VnMvZjlkaFlXSGgy?=
 =?utf-8?B?ZGN5WSt4UDBZYkxBbXJ5L2tJMzNhbDRUY1FYd041NlJZUmZiODNBbEhCMzBj?=
 =?utf-8?B?c2xNUzl6UDlJclYrQ2xveEhDS1lFaWtiSFU4TGFiU0hiY3I3KzNDdjNpelRM?=
 =?utf-8?B?TE8zQlRWSHczOUVuM2FscEI4dGxFdm44RVh3ampRM0w0NXdZdGxHbEFneG1s?=
 =?utf-8?B?bnBGUXR1TmtBcXFFTGdmSEZlTE9DOUl0eXNLQ2dWZTY4djJlTGpybmZuMmsr?=
 =?utf-8?B?ZHJ2T3FQUzBVeDdoeVRuYjRHQXY3WHZRZ3JBN0IvRTl4N0U3ckRVVThLN0RY?=
 =?utf-8?B?R3VxeUNMSTdOQlZ0Y0VIMWZoK0pRTzh4UVVZb09oVTdRVVBWMW83TTZ4VjVx?=
 =?utf-8?B?QTN0Z0VENi9CVjBsRWtDd2tlbDk4b0NKTEN2bHhhUml2T3loU3FhU20rdS9p?=
 =?utf-8?B?VHcrMkEwdHJvK3Jlc3g0eFBnUjZYQnNzWlBNR2ozc1JES0NzbjhxOGNTdzgx?=
 =?utf-8?B?T3VvekhDWlBOeUt3eXVzY0dnV0lFY0MxMEVoVHJZekFCYjhXdTBmOHRwcjZa?=
 =?utf-8?B?SHpnM1RrVEFpWmZjRGtVT3k3UkcwTU95YU9VTStIRHNrRnFqR1FYRzQ5aDk0?=
 =?utf-8?B?VTRhQjh0eGMyTGNJbmRQM01xdTRZcHB3b0ZjbFlvQmpIQ1A4Yno1U2JWNWVv?=
 =?utf-8?B?dnN1Z3JmbjdNUXJiVE1tNi9WbUU0THI4VVRkTXJhcm15Z1pRNlpheXo2dXl6?=
 =?utf-8?B?Qzd0NFNkbTFNaENuN1MxWFFXWGlDUzFSMnhsbTJqQ2d4TG90OEJFbWZySm01?=
 =?utf-8?B?M25Td01kUzgzZTJ5U3UzUnM4eVVLWEo5cWFwTEpoR3g4aVQ5MGVzT2oxOHI0?=
 =?utf-8?B?S3p0N3JVb3lKcmFqY1VXbFZiVFJWTno0ZEszajFRd3F1U0c1U3BZL2ZsbVl6?=
 =?utf-8?B?NTM2K3pSM0JacW5WdVZjSEZwdFV2S012d0xLS2hla2I2Uzd0L2ZFZStHdGMx?=
 =?utf-8?B?eUZlSEpqK3BHUUc2TitmSmZML2JCUU1XSmRJVTRGV1hMTEsyQXRIaHNzbVhV?=
 =?utf-8?B?NnhOajcrSmh1MXNhNEkxMkxQemJEWFFHUVdIWW1UblpRemdLSUc2VTczM2wr?=
 =?utf-8?B?cHZhU0wwOGYwZUtIYzBZMzd4U3k1MkxaVjJsS2o2azlSOFB3cy9LRGhuTFFv?=
 =?utf-8?B?RkorWVNpS2JEZk5DeHR5bW1jSG9vajViRjNPcFNQb01pMGV2bFcxUjNVNWtp?=
 =?utf-8?B?amdUTlI3MGlBSEpSd0x0T3Q5M2JDRTNFU0MvL3VQSzI5dGc1TjgraU5iOEY0?=
 =?utf-8?B?YUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 700b4814-7acd-41cb-f880-08dbd4262ab8
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 00:14:19.4620
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aUBrZBodKvy964KnHX+aOQt765caUUlyAA3m3EMXHVBBEw31Gwiy1jCwUZtfY+oTLqjnKxe3VTOFFJKS8TbFQPr74SAXrjLzTwcqv3SFkSc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8487
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 23 Oct 2023 17:14:47 -0700 (PDT)


On 10/22/2023 8:19 AM, Adam Ford wrote:
> Currently there is a device tree entry called "local-mac-address"
> which can be filled by the bootloader or manually set.This is
> useful when the user does not want to use the MAC address
> programmed into the SoC.
> 
> Currently, the davinci_emac reads the MAC from the DT, copies
> it from pdata->mac_addr to priv->mac_addr, then blindly overwrites
> it by reading from registers in the SoC, and falls back to a
> random MAC if it's still not valid.  This completely ignores any
> MAC address in the device tree.
> 
> In order to use the local-mac-address, check to see if the contents
> of priv->mac_addr are valid before falling back to reading from the
> SoC when the MAC address is not valid.
> 
> Signed-off-by: Adam Ford <aford173@gmail.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
> V2:  Rebase, add R-B tag, and post stand-alone for netdev branch, since
>      the device tree patch has already been accepted via the omap tree.

Looks like you didn't add the tag for which tree. Given the context, I
would assume net-next.

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>