Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1569381rda; Mon, 23 Oct 2023 17:34:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFfC2/1nvGeHQMKLUFg0HzLkQa//Ucm7hGZaEhEzNnT8PaA3F3PN2S4yz7jrjk19VPUEGze X-Received: by 2002:a05:6870:9f8a:b0:1dc:33a:40d8 with SMTP id xm10-20020a0568709f8a00b001dc033a40d8mr14818759oab.4.1698107681526; Mon, 23 Oct 2023 17:34:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698107681; cv=none; d=google.com; s=arc-20160816; b=rHN2zP/csZm7JiZmNpuGOXPcq+02kgs7BzgsIXV6oJQuCbn3CcRYBzRbz1z/YzCMKd yjLujbI6Cly+YnAX3Et7ZaTda3FTU/KPfNuzJc4AwavQySlBz0mtGqI8FZOJ8UTgDBNj cNXfRm7g44Utj6G1uebrf0AWXi9CI6LGy0LDgJQ0CWqXIl3iG8W9YyhZjCd371P/z7B+ QhgNPSgI0y40VF8Ek+l6BjyhYxrHC4R1YIQ/LoqAllC1ofPfE40FD/wBzMKhYNKEk7gy a70BR15fTine5n9C5+4Y22YzxN71NcS2IlIqEvofJj9ZkLb1tKpDlt5JB+seZrfHZqk1 124Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=jm4cUu1Woa9OgzmQ0ndOww8g+k+sCkruBbPjIo/bzSI=; fh=I7aKpsS65fkYJ2+ssNjjw8PPJScYH4iikLdjR/+WOCg=; b=dGipiAzCf/JbtSjkqqsYjsn9LOCyk7EhIU87oJs9CUP8NTrz73c11Wz9HLpoTh5U/F NDjgSyn071oEOv1C5HrwRT7LPkU5OKo00Qsglm9AXSa1syZ3ok1nVSZzMZNSCXELVuMG z28ZuDDu+dffyHK1HjHbRMS6yEOZOSJy/CkfmuETxyLNFE0v1vCVC/N+LXzHG7a/HNae aQO+Ex/K6dNVpXOztNDVqC6lXhpT+FseDOuIEceFtOlwb6vDgftcS40jfjVwlgWHjR1x Jv/jXECmQC0d8jG6Xgh7z+KVe07+gm9e5O0cN/LDEU3ZDdVSv9kaz7uQITb9K48NzvNB YXyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cZgLuAbJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id p26-20020a637f5a000000b005b8915cc557si5081010pgn.773.2023.10.23.17.34.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 17:34:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cZgLuAbJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7E01680C245B; Mon, 23 Oct 2023 17:34:40 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231523AbjJXAei (ORCPT + 99 others); Mon, 23 Oct 2023 20:34:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231396AbjJXAeh (ORCPT ); Mon, 23 Oct 2023 20:34:37 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECCFB10C; Mon, 23 Oct 2023 17:34:35 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62F2CC433C8; Tue, 24 Oct 2023 00:34:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698107675; bh=jm4cUu1Woa9OgzmQ0ndOww8g+k+sCkruBbPjIo/bzSI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=cZgLuAbJKNEvWLyOR74XM+R4BpOsqsUlKiwSAyO1Rt/CXI503XfP2CZUH1o9xqXGT lcsuSg/4ZslXnZq8UaPmriUnofQ3jt/dL64yJmDHsB3L1cI8t1OpxrexNNOjE91AqX Zj3iVm4N1392ZxZfhyLL97wlR7owtPU+FmihSaHRlbd5/UZM8vXnQVm1VkWkp3Brbs bPu/1vvGfIjMWk0O5RZkignc2zgB8L8wM4DsqxRo9Kuy0cKFCp8SSS1XgE0VFeBABF KPKT5eUZeFUAOTckC2fx4ZtWO3WQqGBxHhI741OlLBUhKo7uH7hDauEclOdrjdwFrb j/NX3P5H0MG3A== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20231023153821.189331-4-bryan.odonoghue@linaro.org> References: <20231023153821.189331-1-bryan.odonoghue@linaro.org> <20231023153821.189331-4-bryan.odonoghue@linaro.org> Subject: Re: [PATCH v3.1 3/4] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bryan.odonoghue@linaro.org To: Bryan O'Donoghue , agross@kernel.org, andersson@kernel.org, conor+dt@kernel.org, dmitry.baryshkov@linaro.org, jonathan@marek.ca, konrad.dybcio@linaro.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, quic_tdas@quicinc.com, robh+dt@kernel.org, vladimir.zapolskiy@linaro.org Date: Mon, 23 Oct 2023 17:34:33 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 23 Oct 2023 17:34:40 -0700 (PDT) Quoting Bryan O'Donoghue (2023-10-23 08:38:20) > diff --git a/drivers/clk/qcom/camcc-sc8280xp.c b/drivers/clk/qcom/camcc-s= c8280xp.c > new file mode 100644 > index 000000000000..0631bd5fad57 > --- /dev/null > +++ b/drivers/clk/qcom/camcc-sc8280xp.c > @@ -0,0 +1,3048 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2021, The Linux Foundation. All rights reserved. > + * Copyright (c) 2023, Linaro Ltd. > + */ > + > +#include > +#include Is this include used? > +#include > +#include > +#include Should be mod_devicetable.h instead? > +#include Is this include used? > +#include > +#include > +#include > +#include This got included twice. > + > +#include > + > +#include "clk-alpha-pll.h"