Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1588152rda; Mon, 23 Oct 2023 18:24:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGel3GNJmEkHBe5nc1/edmSqka0+0B2M2O42FBei4fN7OOgzCjSJCwTeD/fMWkjFvMS3qvj X-Received: by 2002:a17:903:1cd:b0:1c9:cad9:e6e3 with SMTP id e13-20020a17090301cd00b001c9cad9e6e3mr19363753plh.32.1698110692408; Mon, 23 Oct 2023 18:24:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698110692; cv=none; d=google.com; s=arc-20160816; b=EC2UP6I1tC/7WZ+9Je81FDM39TBQ54XjFK7K6OhdwJNjvj+ETuojDjLPTF2ugBN1Sg LIRps/Bh227N7fL6n4fejg/AHrJFdxqEXJlU+3ML2RwvYH9SqsSR8Op1SXdFEW8OE7mu 0wf/HifYzr51JOCtW75y1N5IzE5c/Zm1W0aikwECgYie/D4Xjo2QdZUoOyxUzrkKz1xz G6H6/+Y21SldXGRxmx4yREgreYKvfny9Q+jH3V4826iDKkZrsdHQFBMbvMfywRt4YcaR w6qrmW7Irb3fQ+XXuipm7+gr88XxqA4lxJb6HZyad5fKc6/LMPC6L3EdIwXvtZJ6Z+Iv q8Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:autocrypt :from:references:cc:to:content-language:subject:user-agent :mime-version:date:message-id:dkim-signature; bh=ukfZ2wDSYwLBJ91J8jVOY9qdOhwfvLQPwRB8zxLyUOI=; fh=pC0XvU6Xf7VJgzzXTaHlJtOSJvvenS8lNyMrGOdGzvk=; b=bI/hXeHCkE65TpDoqC1QMKugyxhpHzu01YYhyULZSQ+uAAwYXPHvR/1PfvAEc2NmVK zUAQwKcuO4rg86cLkxW0kGhj6Bv6SEbjT8KCnjYNjMVEnLZODvWMD4yAvLNTw/wkDLc5 KylfCFjCwnRqM6tA2VEiixWUJNUmWWadTfpjcv+6zB6X7DTfGuyypvzmEke1ftibQNyI Z4aIY2t2NaS7xjnrEPc4X259ExzfFYuie9T6CGj3rvvYzkZGP3mbD2yGjak7P11umG4z DSdw0RP5N6GzWmGcaAOS0Ope5fiM965KeziN/wOjNW1O3V7rTCcQ7dKuISotzYneGYv0 QixQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ErFEmo7p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id j4-20020a170903028400b001c7545405b5si7657912plr.519.2023.10.23.18.24.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 18:24:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=ErFEmo7p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 24B7980A5F03; Mon, 23 Oct 2023 18:24:50 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230373AbjJXBYn (ORCPT + 99 others); Mon, 23 Oct 2023 21:24:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbjJXBYl (ORCPT ); Mon, 23 Oct 2023 21:24:41 -0400 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11C20A1; Mon, 23 Oct 2023 18:24:40 -0700 (PDT) Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-6bf03b98b9bso3272618b3a.1; Mon, 23 Oct 2023 18:24:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698110679; x=1698715479; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ukfZ2wDSYwLBJ91J8jVOY9qdOhwfvLQPwRB8zxLyUOI=; b=ErFEmo7p7ozkpEqphqYyv56ZRMyjKo6XCVoLbw6Uwyg+FY7w84knJEVVk0mWOsADNg GFFNsEhAMVnA2FeBKoYSFl8TLb1bVk8YwKWYaO3cy+wKbXGDZWW0YQRiL9BwRXXs89BJ TEkrnAEkb01QcrtPw1NWWHvvwWwp6cbeGi4I7+7lj483x9pAFVh5A4VDoRox2QXbFUhX 1PYedkE/ALDilnpQkprtVhmlBEYwECoaKKYow4qR712y037HajHMSllkikuFQvVVvFbM +3kzK0FDK/1F1hKpZ+n6qcL9XM/bdnJP8mHbvEXmmY46IH/YVM4Sww7KFEy9FuJamu/U zTVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698110679; x=1698715479; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ukfZ2wDSYwLBJ91J8jVOY9qdOhwfvLQPwRB8zxLyUOI=; b=s7cqwdM6ljlYS+hgIAB+cDdPMbqkU2+RZcwbeCP8w318HDWnHjUCrh8NjXdtqxPCtj xIojQnweItBVl0XbYBroFeXuLRG/CJ5t30vV4bBSaU1nmr73buMKckPcyoM7yMe0/Pi5 1y+8dUhqez7OTK1L78N8xPIyGbD7ZTqr1aXzi6SQGEhikCwGX6RLmaILRROZeH/5T41C DdyaHHA4st92Ubk1NO4zvaT8Ch2u6OqJzLmkq/TqILhckfV0t96QCCiM42+NTjMc5D0o rp0fcAp0GVVTUA19+7ijV39Am5Dl/6y5WY4kAVrbLfC7jXUmtLXarWD6iWjblYeJgRuW QRKA== X-Gm-Message-State: AOJu0YxhRf78DNuWL1gjVvoKFksffk7pOAfBlX7lbakvijWAZ7plDuh8 xYazlwPntYrsxvRBLlpJpbM= X-Received: by 2002:a05:6a20:da9a:b0:17a:e2b9:77e0 with SMTP id iy26-20020a056a20da9a00b0017ae2b977e0mr1778169pzb.7.1698110679359; Mon, 23 Oct 2023 18:24:39 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id k3-20020aa79d03000000b006bc3e8f58besm6757110pfp.56.2023.10.23.18.24.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Oct 2023 18:24:38 -0700 (PDT) Message-ID: <1bb56c00-d7b1-4a81-8fd8-49e05d36a506@gmail.com> Date: Mon, 23 Oct 2023 18:24:37 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/8] r8152: Run the unload routine if we have errors during probe Content-Language: en-US To: Douglas Anderson , Jakub Kicinski , Hayes Wang , "David S . Miller" Cc: Edward Hill , Laura Nao , Alan Stern , Simon Horman , linux-usb@vger.kernel.org, Grant Grundler , =?UTF-8?Q?Bj=C3=B8rn_Mork?= , Eric Dumazet , Paolo Abeni , linux-kernel@vger.kernel.org, netdev@vger.kernel.org References: <20231020210751.3415723-1-dianders@chromium.org> <20231020140655.v5.2.Ica8e16a84695e787d55e54e291fbf8a28e7f2f7b@changeid> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== In-Reply-To: <20231020140655.v5.2.Ica8e16a84695e787d55e54e291fbf8a28e7f2f7b@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 23 Oct 2023 18:24:50 -0700 (PDT) On 10/20/2023 2:06 PM, Douglas Anderson wrote: > The rtl8152_probe() function lacks a call to the chip-specific > unload() routine when it sees an error in probe. Add it in to match > the cleanup code in rtl8152_disconnect(). > > Fixes: ac718b69301c ("net/usb: new driver for RTL8152") > Signed-off-by: Douglas Anderson Reviewed-by: Florian Fainelli -- Florian