Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1611289rda; Mon, 23 Oct 2023 19:37:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkE0e5FeN0qh7Yi5NfHK5y6KmkiVi9CRE4/b8yKFnWouomsZj55IY5nXFX++7EiSRnhaVm X-Received: by 2002:a17:90a:7066:b0:27d:2ecd:6a23 with SMTP id f93-20020a17090a706600b0027d2ecd6a23mr8245861pjk.14.1698115035103; Mon, 23 Oct 2023 19:37:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698115035; cv=none; d=google.com; s=arc-20160816; b=Mff87uQPwesfZw2fn6zq5IX+fwoK1kSJNGTvvQWupEBqjEykjESxTSwtLG0UGLlKWu wOPLzNbp8Fktnmlzs4rekFGcrRAyD54CFOLYTF+EUwov6V4VkkZP/iiogtpcCzpkWkIV qUA6OojkLvqby7U4E1wua5cy3WWVJae34VwF24UIWQxt6PQwlsrSaSpfmSJNOSKTHrQk +h8yZCkuwTcT9VfOfE/NFvkn69o9WFGRcE/n1q7QHtmz/H5slqdX26aq9TZAvxR2EcJW Uoc4zXRUzLxffJe/QXXgXF/rd12V15mcLoRmN1G7RkkdWVyqvylCIPVAsjfli6TSN4aA fNUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:date:to:cc:from:subject:references :in-reply-to:content-transfer-encoding:mime-version:message-id :dkim-signature; bh=/ntFqWlZOSrFN5h7F1g134fKEDXkzE06VefnG5D/BsU=; fh=OmSJjJZ5xnMRR04srgB6/QtF01mHSUkoeULSyNsSq44=; b=lcUmKKhhuzwz3yAa7JlsON17ejFsbDqfo6kxE72yBjz6drChDQ8jNl00L9geQ5jDDv GY30wphGxsv4wlB8ITBdzoiZh57oDoO/HEik28LwQRipSe7SepffwYbCA20+uGduwAGk RSGzt+4hWyzO3bh9TZYEVG303iMMhtFWYONX/sIn1FifYmJhu4sB22JhnPTnXZDYgmav M2x8MYd/WkKOJbeRNuAgHp6vik/Sg6I8uIry+XK/wwMQZAZyE+gfDBRzrsJsj7aI+0EI bb4gUzx+LDEZV1AvpYcPEoDlZf9e57DlHq+JEr1z3B41gdQnUJAQxuHrVFV0piLXe+35 GM2w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SjMEhmLb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id il5-20020a17090b164500b00277374d74afsi10269483pjb.12.2023.10.23.19.37.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 19:37:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SjMEhmLb; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id CB6448050D33; Mon, 23 Oct 2023 19:37:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232137AbjJXCgh (ORCPT + 99 others); Mon, 23 Oct 2023 22:36:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232146AbjJXCgf (ORCPT ); Mon, 23 Oct 2023 22:36:35 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB49310CB; Mon, 23 Oct 2023 19:36:28 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 433D4C433C8; Tue, 24 Oct 2023 02:36:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698114988; bh=/ntFqWlZOSrFN5h7F1g134fKEDXkzE06VefnG5D/BsU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=SjMEhmLbasRCbIKduAKjjoLFEdtMpFGf+wznDfM1nf0UOqX9SmYLGs7/tITkFw+x+ 57JYGG+Iw9xKCC24RBXi7H4jDZ03WgYHhWVqsIAvOTRxug4uSNoCCHN1a1ZhMLYVyP A9t+JzGrhu91tFCzxbbwCb7v71NQ9lLnWXYRVdJJlr4ww60a4MpoLw56aycu3ShTxF T/LqlreDIK9ElLj8MB0ZVzD6IuG1SbJM5pIRnK6PfTrFvkjLZOnPbx5xv+kLyBDTsI lxZ4c1Gz2dB2wIQj4K6MT59ABFd7KkpUe7Q2WoNdkHiKnnorHMYd0722hHnKgsTxfF P9NHpUJibW1dg== Message-ID: <05698f7e76734125ad06c52b9fc495fe.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230909162047.41845-1-biju.das.jz@bp.renesas.com> References: <20230909162047.41845-1-biju.das.jz@bp.renesas.com> Subject: Re: [PATCH] clk: si5351: Simplify probe() From: Stephen Boyd Cc: Biju Das , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Biju Das , Andy Shevchenko To: Biju Das , Michael Turquette Date: Mon, 23 Oct 2023 19:36:26 -0700 User-Agent: alot/0.10 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 23 Oct 2023 19:37:09 -0700 (PDT) Quoting Biju Das (2023-09-09 09:20:47) > The driver has an OF match table, still, it uses an ID lookup table for > retrieving match data. Currently, the driver is working on the > assumption that an I2C device registered via OF will always match a > legacy I2C device ID. The correct approach is to have an OF device ID > table using i2c_get_match_data() if the devices are registered via OF/ID. >=20 > Simplify probe() by replacing ID lookup table for retrieving match data > with i2c_get_match_data(). >=20 > Signed-off-by: Biju Das > --- Applied to clk-next