Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <f039e5c9c373710218dfd1e96a89d7b1.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20230909150516.10353-1-biju.das.jz@bp.renesas.com>
References: <20230909150516.10353-1-biju.das.jz@bp.renesas.com>
Subject: Re: [PATCH] clk: cdce925: Extend match support for OF tables
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     Biju Das <biju.das.jz@bp.renesas.com>, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org, Biju Das <biju.das.au@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Biju Das <biju.das.jz@bp.renesas.com>,
        Michael Turquette <mturquette@baylibre.com>
Date:   Mon, 23 Oct 2023 19:39:13 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Biju Das (2023-09-09 08:05:16)
> The driver has an OF match table, still, it uses an ID lookup table for
> retrieving match data. Currently, the driver is working on the
> assumption that an I2C device registered via OF will always match a
> legacy I2C device ID. The correct approach is to have an OF device ID
> table using i2c_get_match_data() if the devices are registered via OF/ID.
>=20
> Unify the OF/ID table by using struct clk_cdce925_chip_info
> as match data for both these tables and replace the ID lookup table for
> the match data by i2c_get_match_data().
>=20
> Split the array clk_cdce925_chip_info_tbl[] as individual variables, and
> make lines shorter by referring to e.g. &clk_cdce913_info instead of
> &clk_cdce925_chip_info_tbl[CDCE913].
>=20
> Drop enum related to chip type as there is no user.
>=20
> While at it, remove the trailing comma in the terminator entry for the OF
> table making code robust against (theoretical) misrebases or other similar
> things where the new entry goes _after_ the termination without the
> compiler noticing.
>=20
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---

Applied to clk-next