Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <07937184481af74c65108bae26526605.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <0eebfc14-dbcd-4987-9e94-ea5630b6c268@linaro.org>
References: <20231002170021.192740-1-trabarni@gmail.com> <0eebfc14-dbcd-4987-9e94-ea5630b6c268@linaro.org>
Subject: Re: [PATCH] clk: qcom: gcc-msm8953: fix stuck gcc_usb30_master_clk
From:   Stephen Boyd <sboyd@kernel.org>
To:     Andy Gross <agross@kernel.org>,
        =?utf-8?b?QmFybmFiw6FzIEN6w6ltw6Fu?= <trabarni@gmail.com>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Mon, 23 Oct 2023 19:59:02 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Konrad Dybcio (2023-10-06 16:50:18)
> On 2.10.2023 19:00, Barnab=C3=A1s Cz=C3=A9m=C3=A1n wrote:
> > According to downstream dwc3-msm source this clock has FSM dependency on
> > gcc_pcnoc_usb30_clk so enabling it would fail if latter isn't enabled.
> > This patch add works around this issue by changing parent of
> > gcc_usb30_master_clk to gcc_pcnoc_usb30_clk. This is acceptable because
> > both clocks have same parent and are branches/gates.
> >=20
> > Signed-off-by: Barnab=C3=A1s Cz=C3=A9m=C3=A1n <trabarni@gmail.com>
> > ---
> "meh"
>=20
> There are multiple cases, especially with qcom, where there are some
> magic "dependencies" without parent-child relationship. The common
> clock framework doesn't currently have any good way to handle this,
> other than some mind gymnastics like you had to do here with matching
> them against a common parent/ancestor..
>=20
> Stephen, what do you say?
>=20

You can't change the parent to be not the actual parent. The consumer of
the branch probably wants to call clk_set_rate() on the branch and have
it propagate up to the parent to set the actual rate. Can the axi clk
simply be left enabled all the time? That seems simpler. Otherwise we
probably need to leave the axi clk control to the interconnect driver
and make sure drivers enable interconnects before enabling this branch.

When things start to get this tangled I tend to think that we need to
remove control of the clk from the general drivers and put the logic to
control interconnects and clks into some SoC glue driver and expose a
single interface, like genpd power_on/power_off so that general drivers
can't get the sequence of steps wrong. Instead all they can do is "power
on" their device, and the SoC glue driver can do the proper sequence of
framework calls to power up the device.