Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <320656f5-5f6a-4d5c-a028-98d4a1b0dd85@huawei.com>
Date:   Tue, 24 Oct 2023 11:08:07 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
From:   Jijie Shao <shaojijie@huawei.com>
Subject: Re: [PATCH net-next] net: hns3: add some link modes for hisilicon
 device
To:     "Drewek, Wojciech" <wojciech.drewek@intel.com>,
        "yisen.zhuang@huawei.com" <yisen.zhuang@huawei.com>,
        "salil.mehta@huawei.com" <salil.mehta@huawei.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>
CC:     <shaojijie@huawei.com>,
        "shenjian15@huawei.com" <shenjian15@huawei.com>,
        "wangjie125@huawei.com" <wangjie125@huawei.com>,
        "liuyonglong@huawei.com" <liuyonglong@huawei.com>,
        "chenhao418@huawei.com" <chenhao418@huawei.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20231023010836.507078-1-shaojijie@huawei.com>
 <MW4PR11MB57763C8FF069B2A567EDCC85FDD8A@MW4PR11MB5776.namprd11.prod.outlook.com>
In-Reply-To: <MW4PR11MB57763C8FF069B2A567EDCC85FDD8A@MW4PR11MB5776.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


on 2023/10/23 16:55, Drewek, Wojciech wrote:
>
>
>   }
>
> +static const struct hclge_link_mode_bit_map hclge_sr_link_mode_bit_map[8] = {
> Names of those arrays are a bit too long. I know this is a standard here but I'm not sure if
> "bit_map" at the end is necessary.

"bit_map" will change to "bmap" in v2 patch，and the structure name will 
be changed together.

>> +	{HCLGE_SUPPORT_10G_BIT, ETHTOOL_LINK_MODE_10000baseSR_Full_BIT},
>> +	{HCLGE_SUPPORT_25G_BIT, ETHTOOL_LINK_MODE_25000baseSR_Full_BIT},
>> +	{HCLGE_SUPPORT_40G_BIT, ETHTOOL_LINK_MODE_40000baseSR4_Full_BIT},
>> +	{HCLGE_SUPPORT_50G_R2_BIT, ETHTOOL_LINK_MODE_50000baseSR2_Full_BIT},
>> +		if (speed_ability & hclge_sr_link_mode_bit_map[i].support_bit)
>> +			linkmode_set_bit(
> Checkpatch complains about wrong wrapping (here and in the next 3 functions):
> CHECK: Lines should not end with a '('
>
>> +				hclge_sr_link_mode_bit_map[i].link_mode,
>> +				link_mode);
>> +	}
>>   }

this wrong wrapping will disappear if "bit_map" change to "bmap".

Thanks.