Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1665582rda; Mon, 23 Oct 2023 22:18:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhGmmetwVz0FEHue+8ylfTKUK/jIGnbPbbBlmlg/mmonq09klbmUCOwfmkWGhqt0wIYxWe X-Received: by 2002:a17:90a:a206:b0:277:4be4:7a84 with SMTP id u6-20020a17090aa20600b002774be47a84mr19096765pjp.19.1698124688805; Mon, 23 Oct 2023 22:18:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698124688; cv=none; d=google.com; s=arc-20160816; b=EGUpr3rPRmwZEZIwEzi0pCwqXXHiur6GufjimaV/pwG4CUy7ggjh/RT5PdtRlMQjZ1 nOn3zVi15YL+xP3MhKMMMjX9NtCQ12ru8A5C1lHnmwCDbroEbGfclQT6qINjHeCYT0Ki WrIEFflTfOMeHhGoDecDdJ3rWdshePgdEStdRMGHB85hHFHhSI1Z5VobD1B8lgm+9MyZ mWxiAksbsjseMgeoHacw+n1BSmzfAguuxaO3w+MSGaAqjxVI9F8Nis8ZD2JU+Q200MP3 oTJv52aaICOLI57GYvu73vnUTZepyOlf+XNQNMLHJVXdXmRR0L8YGatVcC63WYmYdQsb gUVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EfwtReRlgvoROTihY0+48R14MC3Oiu7Kj0o4NjAywec=; fh=d5uDGeYcUSjesbWBN2u7Arzxmm4wpltvnizjx8Gqz7c=; b=Tn7N9gp1Et87cC0+RFToME1T3pjb3DCWaw+xlM7S4MSme5ABihx+YFPiVfELv8e9p5 mXVJ05KC71xwdka3kzfLnKk+paa+tJBeqBv+Zu/0N/12DrK/2JPJmVYfA0BGiOD2Of31 DNJgWyqWa9A6Rhg1RQY5Renh+MmCQBOSPAHjxGCiZ3qGv0Ulx2F9uAt1zr1Gtj08LkXf jcwa026Jr3+gqHGmPFjTsmvFsAUJX1uy7SnSJ3PYCGbMh0IbaZw4KonhdQ+JiD0wZJKM tQVpFQBHOBpcxIU+GC2iA9205l9Za8g7uleNXg0NmYcAvCJ81LtTl/gIvc7lEIRvWDue 1WlA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=VKyzA5BF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id nv9-20020a17090b1b4900b002791a73ab07si8175062pjb.54.2023.10.23.22.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 22:18:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=VKyzA5BF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 87AD98095835; Mon, 23 Oct 2023 22:18:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232069AbjJXFRx (ORCPT + 99 others); Tue, 24 Oct 2023 01:17:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbjJXFRw (ORCPT ); Tue, 24 Oct 2023 01:17:52 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6605EE5; Mon, 23 Oct 2023 22:17:50 -0700 (PDT) Received: from localhost (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sebastianfricke) by madras.collabora.co.uk (Postfix) with ESMTPSA id 689F966072AE; Tue, 24 Oct 2023 06:17:48 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698124668; bh=YUECIn9F7kjCAWXeysCb2OmHfTThMl1ioFSUYe3i6tY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VKyzA5BFMfTebKGTpgbXOHlBI4TOBKxspJ2gEp7Y4c06wJ1oQN9VUymRMw1Wuc6Fi dy1S3fuToU1nYW32KKfGvW3frKe7eOxhQADXeG6711QTInsixI7gaLmcrUfIZU4Z/R sM58MTgt2EyULA8Qo+LjmzzZse9eUuLg8Lib57V6ZTYeu8tX2LewKqpiFHGvX8zX63 /ghgXZe4mEV/dnljf8Ar6HSgsK0dkPOpknoaIMTP2qQUqn9g0x9GTDRnse83rfwz9w VkpWvStRr8eSfPpHjdWjwOQxMWLeDnKChtWxuwFxclE0Xn2z17qiu4OG/VT1tG+NK4 qw97avw+gd45g== Date: Tue, 24 Oct 2023 07:17:45 +0200 From: Sebastian Fricke To: Krzysztof Kozlowski Cc: Rob Herring , Krzysztof Kozlowski , NXP Linux Team , Conor Dooley , Mauro Carvalho Chehab , Jackson Lee , Hans Verkuil , Sascha Hauer , Pengutronix Kernel Team , Shawn Guo , Philipp Zabel , Nas Chung , Fabio Estevam , linux-media@vger.kernel.org, Tomasz Figa , linux-kernel@vger.kernel.org, Nicolas Dufresne , kernel@collabora.com, Robert Beckett , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Darren Etheridge Subject: Re: [PATCH v13 6/8] media: dt-bindings: wave5: add Chips&Media 521c codec IP support Message-ID: <20231024051745.d663ekj7klrl4yzj@basti-XPS-13-9310> References: <20230929-wave5_v13_media_master-v13-0-5ac60ccbf2ce@collabora.com> <20230929-wave5_v13_media_master-v13-6-5ac60ccbf2ce@collabora.com> <20231016134720.GA2650973-robh@kernel.org> <20231021120526.eqe3esyxyi5b3e5d@basti-XPS-13-9310> <3d465d3c-386d-467b-87e9-806962464ac5@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <3d465d3c-386d-467b-87e9-806962464ac5@linaro.org> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 23 Oct 2023 22:18:05 -0700 (PDT) Hey Krzysztof, On 22.10.2023 18:01, Krzysztof Kozlowski wrote: >On 21/10/2023 14:05, Sebastian Fricke wrote: >> Hey Rob and Krzysztof, >> >> On 16.10.2023 08:47, Rob Herring wrote: >>> On Thu, Oct 12, 2023 at 03:24:12PM +0200, Krzysztof Kozlowski wrote: >>>> On 12/10/2023 13:01, Sebastian Fricke wrote: >>>>> From: Robert Beckett >>>>> >>>>> Add bindings for the chips&media wave5 codec driver >>>>> >>>>> Signed-off-by: Robert Beckett >>>>> Signed-off-by: Dafna Hirschfeld >>>>> Signed-off-by: Sebastian Fricke >>>>> --- >>>>> .../devicetree/bindings/media/cnm,wave5.yaml | 60 ++++++++++++++++++++++ >>>>> 1 file changed, 60 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/media/cnm,wave5.yaml b/Documentation/devicetree/bindings/media/cnm,wave5.yaml >>>>> new file mode 100644 >>>>> index 000000000000..b31d34aec05b >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/media/cnm,wave5.yaml >>>>> @@ -0,0 +1,60 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/media/cnm,wave5.yaml# >>>> >>>> Filename matching compatible, so: cnm,cm521c-vpu.yaml >> >> With which compatible should the filename match? (see below) >> And just to be sure, this means that I rename the file to: >> `.../devicetree/bindings/media/cnm,wave521c.yaml` > >With the fallback compatible. > >> >>>> >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: Chips&Media Wave 5 Series multi-standard codec IP >>>>> + >>>>> +maintainers: >>>>> + - Nas Chung >>>>> + - Jackson Lee >>>>> + >>>>> +description: >>>>> + The Chips&Media WAVE codec IP is a multi format video encoder/decoder >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + enum: >>>>> + - cnm,cm521c-vpu >>>> >>>> Can this device be anything else? Why VPU suffix? >>> >>> It needs an SoC specific compatible (TI something...) as well (or >>> instead). Unless there's a public spec with details on how many >>> clocks, resets, interrupts, etc. there are. >> >> Okay so how about this, a bit similar to the Coda driver supplying both >> a general option and a SoC specific version: > >Can generic compatible be used alone in board designs? If it is licensed >block, then most likely you want a fallback. Alright, so a fallback seems appropriate, how do you like this? properties: compatible: items: - enum: - const: ti,k3-j721sX-wave521c - const: cnm,wave521c Providing a fallback and adding a enum which can be extended later on. > >> >> properties: >> compatible: >> enum: >> - ti,k3-j721sX-wave521c >> - cnm,wave521c >> >> (ti,k3-j721sX-wave521c = manufacturer,SoC-codec) >> (tested on j721s2 but should work on other variations as well) >> >> Another alternative could be: ti,k3-wave521c (less specific on a single >> SoC series but connected to a bigger range of devices) > >Best regards, >Krzysztof Greetings, Sebastian > >_______________________________________________ >Kernel mailing list -- kernel@mailman.collabora.com >To unsubscribe send an email to kernel-leave@mailman.collabora.com