Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1667929rda; Mon, 23 Oct 2023 22:25:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYG0No7OUw9zWuUz6sQCByTRGBdJnWegbEeFVoHyVjWGOUzugsoxqhLbE4TJPnd1z5a6WC X-Received: by 2002:a17:903:32c8:b0:1ca:8a38:38c4 with SMTP id i8-20020a17090332c800b001ca8a3838c4mr11545390plr.27.1698125110964; Mon, 23 Oct 2023 22:25:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698125110; cv=none; d=google.com; s=arc-20160816; b=LgDO9DtSycwbRN3y0gBcxAdZE4LQVfWgsScE94q/65Pwc1ElPm/dJXRBOvy0cZEIXy AXddOZhIJ0hYpxrj2pYBFSaeAt5QAGMKBW2ro/ouwZjeAZ5upbMKiXunVrOCmzZbvEV1 sbvf22dwrQhi01uswwkivO50Hf+D9b6qhtie/XJ8E5nzi1zuYeA1XyiAajuvULudh1PJ GeLnj7hJRpcaPQmstTttG2yTa+0fmW7S11Dz9VF1iV/SgS42fy4JZQ6zHLNvoLF5B1sC yynU6iiBBzbRs0f0lN1BqnkASXa90qQpxK5eRCXZlyRi4N/n9WgxOU5fvT8uEwYJAMlN JqYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature:dkim-signature; bh=3xKoNE41itsf53R8KnfXvJY7xIgN+SlleTH+6Hkx508=; fh=t2vr4PQkttnZ6R247isx0vzkDTZu3kfyu/5GMcc1yLI=; b=nGskBLTmUnmBReQ9WzI1lx5PnKijNpBhf12zmxB/odfY9aEew03IXJtqjDqZokswib fuLI0x5FlI/B6PWHk1bhoDY6KRtcp5IlCz1Y0PrpI2g+mpM/ORd1xUpf/i6QwqkRhO3f h283tw8Hfx2UEc28ypGEkPTcVdXZln2uFK0kulKL9VRHOq6W/y/8hyN8aR/HmlZJaUd4 oIsqfSaaWBybt8sMzVki7pZZPvA6Pw+k9CYRAtWbq7CZcZNBzUlw4kXTyzIunmZj0Mzy l/Yi4A2x8iVHlVVvrav2UpdgVbi3PD/xuvoX5tziFFq+RMuYmkEpG366U1uG5uYJGpmj TdnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=HQxVO+RZ; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id j12-20020a170903024c00b001c9b15bf936si7991723plh.220.2023.10.23.22.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 22:25:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=HQxVO+RZ; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id E58B680A32D9; Mon, 23 Oct 2023 22:25:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232174AbjJXFZD (ORCPT + 99 others); Tue, 24 Oct 2023 01:25:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbjJXFZB (ORCPT ); Tue, 24 Oct 2023 01:25:01 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D6FA125 for ; Mon, 23 Oct 2023 22:24:59 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 433FB21B65; Tue, 24 Oct 2023 05:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1698125098; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3xKoNE41itsf53R8KnfXvJY7xIgN+SlleTH+6Hkx508=; b=HQxVO+RZzP/2M9FrSXdLRF4zGbweYrjkWaC6nPce5cOf0UN1SCKPQa09F4T/IUVzWqSe// BEdNB14zraXi8e20q+0QO9FIjeGXJXrDYyrmiHEW0QrSI8jINZ1rrZkaK/icfAaDz4pRag q8CDTCsz4MAlKUV7aH8WmBX6owX4XNg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1698125098; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3xKoNE41itsf53R8KnfXvJY7xIgN+SlleTH+6Hkx508=; b=l+uRzkjg4nqQow1Q67Km6jlgRB2GHIIV/48C5RkRlDf1K9Ia4loL+MqAhkGEin0t90xDHT MXMV9zkxzmmU47BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 108471391F; Tue, 24 Oct 2023 05:24:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tq7HAipVN2XiAwAAMHmgww (envelope-from ); Tue, 24 Oct 2023 05:24:58 +0000 Message-ID: Date: Tue, 24 Oct 2023 07:24:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme-keyring: add MODULE_LICENSE() Content-Language: en-US To: Randy Dunlap , linux-kernel@vger.kernel.org Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org References: <20231023230052.31161-1-rdunlap@infradead.org> From: Hannes Reinecke In-Reply-To: <20231023230052.31161-1-rdunlap@infradead.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -11.05 X-Spamd-Result: default: False [-11.05 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.96)[99.83%]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 23 Oct 2023 22:25:09 -0700 (PDT) On 10/24/23 01:00, Randy Dunlap wrote: > When NVME_KEYRING=y (NVME_AUTH is not set), there is a modpost build > error: > > ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o > > so add a MODULE_LICENSE() to keyring.c (copied from auth.c). > > Fixes: 9d77eb527784 ("nvme-keyring: register '.nvme' keyring") > Signed-off-by: Randy Dunlap > Cc: Keith Busch > Cc: Jens Axboe > Cc: Christoph Hellwig > Cc: Sagi Grimberg > Cc: Hannes Reinecke > Cc: linux-nvme@lists.infradead.org > --- > drivers/nvme/common/keyring.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff -- a/drivers/nvme/common/keyring.c b/drivers/nvme/common/keyring.c > --- a/drivers/nvme/common/keyring.c > +++ b/drivers/nvme/common/keyring.c > @@ -180,3 +180,5 @@ void nvme_keyring_exit(void) > key_put(nvme_keyring); > } > EXPORT_SYMBOL_GPL(nvme_keyring_exit); > + > +MODULE_LICENSE("GPL v2"); Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew Myers, Andrew McDonald, Martje Boudien Moerman