Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <33857df5-3639-4db4-acdd-7b692852b601@suse.com>
Date:   Tue, 24 Oct 2023 08:53:40 +0300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v14 12/23] x86/virt/tdx: Allocate and set up PAMTs for
 TDMRs
Content-Language: en-US
To:     Kai Huang <kai.huang@intel.com>, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
Cc:     x86@kernel.org, dave.hansen@intel.com,
        kirill.shutemov@linux.intel.com, peterz@infradead.org,
        tony.luck@intel.com, tglx@linutronix.de, bp@alien8.de,
        mingo@redhat.com, hpa@zytor.com, seanjc@google.com,
        pbonzini@redhat.com, rafael@kernel.org, david@redhat.com,
        dan.j.williams@intel.com, len.brown@intel.com, ak@linux.intel.com,
        isaku.yamahata@intel.com, ying.huang@intel.com, chao.gao@intel.com,
        sathyanarayanan.kuppuswamy@linux.intel.com, bagasdotme@gmail.com,
        sagis@google.com, imammedo@redhat.com
References: <cover.1697532085.git.kai.huang@intel.com>
 <ac0e625f0a7a7207e1e7b52c75e9b48091a7f060.1697532085.git.kai.huang@intel.com>
From:   Nikolay Borisov <nik.borisov@suse.com>
In-Reply-To: <ac0e625f0a7a7207e1e7b52c75e9b48091a7f060.1697532085.git.kai.huang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YldFOGIxclVkWGFCZE9rb2FqajNTZmRuZmpqSTR3SVF5VGpCR0tEd1B1VFJY?=
 =?utf-8?B?d3lNSlc0S0V3ZWd1T1FuVWxCcHFjYzhvK1VTcXd3aTljUmpLUXYzeWlrc1Y0?=
 =?utf-8?B?T2JsRnZFSlR1Wk1hS29PVW00bzNGRVJ2UHhJY3Y4YUJwUnVtMEttTkhLUnRx?=
 =?utf-8?B?dVExZmxnNUowaCtUbi9jeFBMa3YzZENCanpkUU41V0NsdjVIc1FFUEMrS0c3?=
 =?utf-8?B?N3NvU2w5em93ekdub0cycm9tMU1IMFd2ZitYdmsvOXhWaUZJUXRwRWpORVMv?=
 =?utf-8?B?cjZNcnNmUmdqOEhaVUU4UStTb1JKamdFdmUvdTRidUQxV1lzR3ByaDhxTkcr?=
 =?utf-8?B?UkgvSmJsVDRDckFncTlaaHpmZmtnUHowVEIyOHBPUlBjQ3plejNMUmt5eWI0?=
 =?utf-8?B?Mkw3eWtwRzkvaUxIVm9pWWJWRVoyNFZlSGU0NDNiZWFPVVN4N20xTllFQWhw?=
 =?utf-8?B?SVZwWVBLaGtzbUZrdFFWL0RUelFoZVd1cHpLWHNDdHdFU01OUyt6RjJ0bC9W?=
 =?utf-8?B?ZkZjaW9IdjdQK25VLzlGY04wdS9TNm9zMzZPSnA3VlFlZ20reEUrZmlld1pU?=
 =?utf-8?B?QWdFcFdWTlpmU0loRmhRQnJZdU9MK2FPSjV6cTA2N2J4d1RNYklKMXJCOG1r?=
 =?utf-8?B?S3N2dDIrTk9NcGpHZXRzZUM3d3RUcmZRNytXVTI0b3lHajNvNUdhZnoySDZN?=
 =?utf-8?B?NzZ2WFFUbWJrZmJ6am5rbWcyZXkrYWNtWkh4NUxxcFZkQTNDajhKcFpsOWw5?=
 =?utf-8?B?T0FnVlJpSjZYb0c5QkxCR3BmR3B5NXM4TWJmM2F4ak50RTdxSE1wdk9hTVdZ?=
 =?utf-8?B?WUtQazMrUzlOS1cwT2lmM0Z4d3FMTHpnMkJ5cW13Smw4RWlBZTM4MnE1UGdR?=
 =?utf-8?B?V0hyNExTN2VlaUdHWWkzVGc2UFpiRjAxQ25KQ0pXZXp1OTBwbi9nZEVrRDly?=
 =?utf-8?B?R2RwYnZWdm5oQm8xUGMxaThzM1l2MG1na2V1RGRXeE9yMDJuS3hGdkliVVA2?=
 =?utf-8?B?VnppYm9tQzJReWoyeXZjSU9RTGM1MUphbE94OHBzNzJRUnhpdzRFbXBxanVH?=
 =?utf-8?B?TWcyb3luZzBWQXp5STcwYm1VSzEwWE9LMVRlcnVHN0t0TWVERFV3bzFxVTJS?=
 =?utf-8?B?V2MwdGRnRktUSmlvVmZxZVI3cmJvOWVuaWM2ZEM1RjBaYjRtb1IzZHFSaEVB?=
 =?utf-8?B?TzZFL0JvUmt0NnM4Rm9ONzN3cHRORFNWQnZlQ2xXcnNLbDdUM3kvTDVSczZF?=
 =?utf-8?B?SFpVMFh1NWc2ODRwbCttTGlUVUovVDQyemMxM0k2SFUrRDNrcUVwY1VuRmY0?=
 =?utf-8?B?dC81d3lkT2dqMjZDOXl4aWFVbDIvM2xNR0VxaWFLSjVFSC9sQzFtbkhBRm56?=
 =?utf-8?B?dE56L0dqVFZJendZQ2Y2S3dpMG5KS1hjVVdiZ3I1S0JMRUNMSno4YTVqbk84?=
 =?utf-8?B?Sm8xWnlNeFA5aThvUWprazBoTnpQcGdCd1NKQUZoWC9SVFllU1YyK0M0MWFl?=
 =?utf-8?B?dktRbFNjS3BEQVM1YXR1S1pnZDNsa0hXbFJXN0FGRkVYVXJuR3RrY0txNzA5?=
 =?utf-8?B?RHB2aFZ2SHQ2TThzRUNaSHJCZEsvTG9HUjhCSkxRZGVmZ2x1Q1U2YTA1QVNY?=
 =?utf-8?B?ZmFWMFhDSHFRUlAwalVhVnI0RDB3UktocXVkMkRUczJaSHd5bFB4c1RVcjZX?=
 =?utf-8?B?K0ZkWDhLNjkwNmlucmtMZGM0R1g3L2gzNnVlRkVzV25HMWVyWklxZmQwQ0tP?=
 =?utf-8?B?ZEtuS25PVXlhYWRQOFN0bklvTzRQeWFrZ0J4NTdnOW02SlZUZjgrWm5TSVJh?=
 =?utf-8?B?NUpaZDdvQ0g0ZEY0NDg5WlVBbitiQ094clA3TG5MT3BpSlNwQ1ZtQTl2UW5r?=
 =?utf-8?B?N0Y1TVNOQlZ2RUtDZ3I3dSsvSWQvN3FBeUtJclQrVjViQ2FUT09VL2h0SmM0?=
 =?utf-8?B?b0pYSklrQVVrRWZzeUY3MTJpUVV6OHhVbjZsdFhlTGdhdlo5aThCRmtON01z?=
 =?utf-8?B?NllMRmxRc21zTlpRd0VvRU1OUlJ6UXRpWm1kRi9rdXZyY0VwckdDWmlrVmlo?=
 =?utf-8?B?K3JiakRyUDN4NGJMUnJvdzZtR3Fwd2dwMy9iTXJDZ1lmVUFFbzMyRHFDeUZP?=
 =?utf-8?B?RUMwb3c5TU1JZGhaKzVidGZQTytLdEpnT1M4TmZIRmVXekd4V29KMkpJQzRY?=
 =?utf-8?Q?F3rhcqBX8w8HXloCeAMQnqru908zo5rhtym+mNhfMGPZ?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fcbf2a2d-caed-4870-919a-08dbd45594b7
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB7790.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 05:53:43.7402
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6PdYg5ergWztMTdCuNwXuziWMxwzz6CVimZkGtV0psr5ZM3Tg4dyS4j0j1MEOj+hNJXDG42F3EHdVXXwGUMfcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9203
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 23 Oct 2023 22:54:55 -0700 (PDT)


On 17.10.23 г. 13:14 ч., Kai Huang wrote:

<snip>

>   arch/x86/Kconfig                  |   1 +
>   arch/x86/include/asm/shared/tdx.h |   1 +
>   arch/x86/virt/vmx/tdx/tdx.c       | 215 +++++++++++++++++++++++++++++-
>   arch/x86/virt/vmx/tdx/tdx.h       |   1 +
>   4 files changed, 213 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 864e43b008b1..ee4ac117aa3c 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1946,6 +1946,7 @@ config INTEL_TDX_HOST
>   	depends on KVM_INTEL
>   	depends on X86_X2APIC
>   	select ARCH_KEEP_MEMBLOCK
> +	depends on CONTIG_ALLOC
>   	help
>   	  Intel Trust Domain Extensions (TDX) protects guest VMs from malicious
>   	  host and certain physical attacks.  This option enables necessary TDX
> diff --git a/arch/x86/include/asm/shared/tdx.h b/arch/x86/include/asm/shared/tdx.h
> index abcca86b5af3..cb59fe329b00 100644
> --- a/arch/x86/include/asm/shared/tdx.h
> +++ b/arch/x86/include/asm/shared/tdx.h
> @@ -58,6 +58,7 @@
>   #define TDX_PS_4K	0
>   #define TDX_PS_2M	1
>   #define TDX_PS_1G	2
> +#define TDX_PS_NR	(TDX_PS_1G + 1)

nit: I'd prefer if you those defines are turned into an enum and 
subsequently this enum type can be used in the definition of 
tdmr_get_pamt_sz(). However, at this point I consider this a 
bikeshedding and you can do that iff you are going to respin the series 
due to other feedback as well.

<snip>