Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 24 Oct 2023 14:10:27 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
CC:     Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        "Vincent Guittot" <vincent.guittot@linaro.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Swapnil Sapkal <Swapnil.Sapkal@amd.com>,
        Aaron Lu <aaron.lu@intel.com>,
        "Tim Chen" <tim.c.chen@intel.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>,
        "Gautham R . Shenoy" <gautham.shenoy@amd.com>, <x86@kernel.org>
Subject: Re: [RFC PATCH v2 1/2] sched/fair: Introduce UTIL_FITS_CAPACITY
 feature (v2)
Message-ID: <ZTdf0529DL51pj8m@chenyu5-mobl2.ccr.corp.intel.com>
References: <20231019160523.1582101-1-mathieu.desnoyers@efficios.com>
 <20231019160523.1582101-2-mathieu.desnoyers@efficios.com>
 <f40522de-b71d-4848-8aa3-5b87d38bb847@arm.com>
 <c79ac631-61c7-4953-a657-74047a264029@efficios.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <c79ac631-61c7-4953-a657-74047a264029@efficios.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?k6Rv3eUAKV28ht6sK0ZzbED4EnMDD9L4btZQa9wEB9HKsE9wM7xLcSNHnoCF?=
 =?us-ascii?Q?vXgufHb7m5dmCxqMAhYg+FGI8V+Jcc1AsV3xKMAkLyVMtecjcxghgQD6SHB3?=
 =?us-ascii?Q?q8n1LvV8f8IKPY9PvlpJ5Bf+6iuV5ztq6zoWK0dMi98t1Dd9pHnDlkFfpr9o?=
 =?us-ascii?Q?cLceOf2GEh87wYtu7SkTRHXtXw4n/sjhPTQWS67RdXdTR6jzkFioQT2RmM5Y?=
 =?us-ascii?Q?0bphpHdKjshY2Ure65JXeQSA17w6bAlb6TWWFCqXozDxNoLNKGftoSInJD7v?=
 =?us-ascii?Q?4TUpLnDFtrO6UhvOrZCLn0GZR5aNA+14yZxxBRjfxafQzi3vuGNPLSoTOHSs?=
 =?us-ascii?Q?hDAJVlzcU9OROuzu33pGqbsUX7REtHgAIp5U/unYvBZJtNCaocMRpfX3C+DM?=
 =?us-ascii?Q?zHgzMT85VMiUfuW50tPOuOeOoF0v6JHSm1ocl/oLICPG93PoB/C8JS+KMYbQ?=
 =?us-ascii?Q?kMI/PlLrWaOic2I8Vj2QR/DyqTGC4V1iFsEpeyyqLLxQq2icBWQ30cFDJDgH?=
 =?us-ascii?Q?Io/DXqmVe461vDXAbwfheGDgWZJjD78mmtPsO0UUyLiiKUphoz5z2hEWfzKn?=
 =?us-ascii?Q?8F2T58sTliMq47hlx4ZqQT93EKRscsI67jS3zBZ7GGZWvldy2ta079oiGUXF?=
 =?us-ascii?Q?5ir726LiiZu/yfGbKLDcqz/pWH2RMx3hrjQBkxUXwafEpI+ICpjHxlQS0g5A?=
 =?us-ascii?Q?H+9YZdvUABOfYZjA1NZesL8giyNwGs1Lqsj6AYARaimR/bng89SzmfAaUbKg?=
 =?us-ascii?Q?w5tDahS/D0UXRRvd19LbeWQp8q2rNTmtGudlkR3lPEP6yzs2HUuOJT2n4TIU?=
 =?us-ascii?Q?/u3xOIDHzcrJ4nNIk+dZ1h92vmbtx0v/cvpxOeeJK+Ud26EbHX+xpBLPOHWo?=
 =?us-ascii?Q?EUt7PoA0EAH+Qg0o14/l5XuA09aOf7t9yAmfpUrFCp+z29TEjXratTbQktFX?=
 =?us-ascii?Q?A8lc9uoVRTILX8BRwZELmQ26cPrQTg5LOsGnTs7KFOd/iHZkqVgjEGPmg39y?=
 =?us-ascii?Q?HMlPb6mIbyh+pbAPFX+La51iAcBt6waR+Fa9x//6Juse0jQgxNhAJwwlgiVG?=
 =?us-ascii?Q?/se3DsjMmCWrc3FzWmlNTLgwjGXTuAgtXYZ3ONoRITR8v008u6DCiobPdTmy?=
 =?us-ascii?Q?suEMhlXXISqkRyBY7NzP4O3SNb38Ye+gJTmAjofDpquSfvaf52U+wCpOZveq?=
 =?us-ascii?Q?6++LMQirBqDIFOhPX1suVXHis0WJypdVcBz+o9mtzDdpqBS/4xWjfKIanSHO?=
 =?us-ascii?Q?QP/ruegdlq4NPWZe09IRSE8VD+WXM5V+/sgtOoT62HLSuSm8ZmsDyWAGSjIN?=
 =?us-ascii?Q?Hpt/tabaPZlgo0LTf+wFdhZ0AVkwE7Y91NrprEI1Lb4IKOXyeqDf3mCZ/BB7?=
 =?us-ascii?Q?rmvJ8JLhOHPrAftAX7jhABj3+auEvyZCAkFSefsuOxovS/NZidJUDHvrb4p8?=
 =?us-ascii?Q?VAgAJnGlQzZ1Nx6+puM2LlFUqLd4mSASYCPoJOlshf1dPqDzJD0hbS2txhce?=
 =?us-ascii?Q?CBJHoMK6zVla/G9RMVpSlTeaiIRBw9IRHPv0VSQRS0fSWj4KL8Nu0VKxEAE6?=
 =?us-ascii?Q?DPsvlCWjUFmfkjMOzEn081MqVoMo8ErVP+aMAIfD?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cfd2ed6-dc45-4df2-2d0d-08dbd457f4a9
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 06:10:43.6825
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 9myWTHLGJ8sNGW4zZv+BwKA+oN5CZtJX/bXr7PvgyE5ZiXp3ABKLiyPXMbXViANLYp/WnkwwDeWh6iRXAdNW4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5184
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 23 Oct 2023 23:11:08 -0700 (PDT)

On 2023-10-23 at 11:04:49 -0400, Mathieu Desnoyers wrote:
> On 2023-10-23 10:11, Dietmar Eggemann wrote:
> > On 19/10/2023 18:05, Mathieu Desnoyers wrote:
> 
> [...]
> > > +static unsigned long scale_rt_capacity(int cpu);
> > > +
> > > +/*
> > > + * Returns true if adding the task utilization to the estimated
> > > + * utilization of the runnable tasks on @cpu does not exceed the
> > > + * capacity of @cpu.
> > > + *
> > > + * This considers only the utilization of _runnable_ tasks on the @cpu
> > > + * runqueue, excluding blocked and sleeping tasks. This is achieved by
> > > + * using the runqueue util_est.enqueued.
> > > + */
> > > +static inline bool task_fits_remaining_cpu_capacity(unsigned long task_util,
> > > +						    int cpu)
> > 
> > Or like find_energy_efficient_cpu() (feec(), used in
> > Energy-Aware-Scheduling (EAS)) which uses cpu_util(cpu, p, cpu, 0) to get:
> > 
> >    max(util_avg(CPU + p), util_est(CPU + p))
> 
> I've tried using cpu_util(), but unfortunately anything that considers
> blocked/sleeping tasks in its utilization total does not work for my
> use-case.
> 
> From cpu_util():
> 
>  * CPU utilization is the sum of running time of runnable tasks plus the
>  * recent utilization of currently non-runnable tasks on that CPU.
>

I thought cpu_util() indicates the utilization decay sum of task that was once
"running" on this CPU, but will not sum up the "util/load" of the blocked/sleeping
task?

accumulate_sum()
    /* only the running task's util will be sum up */
    if (running)
       sa->util_sum += contrib << SCHED_CAPACITY_SHIFT;

WRITE_ONCE(sa->util_avg, sa->util_sum / divider);

thanks,
Chenyu