Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
Message-ID: <35b325ba-8575-900c-5746-8586f9b2c42d@intel.com>
Date:   Tue, 24 Oct 2023 15:09:26 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH] mm: mlock: avoid folio_within_range() on KSM pages
Content-Language: en-US
To:     Hugh Dickins <hughd@google.com>,
        Andrew Morton <akpm@linux-foundation.org>
CC:     Matthew Wilcox <willy@infradead.org>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Stefan Roesch <shr@devkernel.io>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
References: <23852f6a-5bfa-1ffd-30db-30c5560ad426@google.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <23852f6a-5bfa-1ffd-30db-30c5560ad426@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0xkZXdZSTVubi83SkljSFViZEdNY0dKSHZmRUFhNHB2OXNvcVhvN0dtdG5r?=
 =?utf-8?B?M1hoUTl1MXkxSm9MajZPRnB0WUk1YlJqazB2ZHNOQmNBeEQxSmQ2QW9nWkFR?=
 =?utf-8?B?cVI2VFdUd0tHY3Q1QWpmL2lka2RxbWpZZnVpb3ZtWTUzMFFKdUxUNkNaSGYx?=
 =?utf-8?B?cUdjbk0zWXM1Wm83QjlpbFRWM1VTb3dwYklaai9QRVNvdlFzSi9JR1pBUjNu?=
 =?utf-8?B?TUVGSGpDN3JJU3Nva3MvZlBreVBqRlY4NXR4QjlEaFp2dzA1aDkvaG14KzBi?=
 =?utf-8?B?cW9Fdm1HeU5iSE9DU09SZUJTQVFHL3kra0N3cDFqSkRqSENOenFwRUFiei9j?=
 =?utf-8?B?aHpSSnFxd2kwN0VrZXJoSWJzNTFWNnVRY1p0bEZjQlVRSEdhN0hLU3I2YU44?=
 =?utf-8?B?MWVGWmo3OHkvcVZ3V1VvWTgyZWpDRldwR01zeXBmYXIvcEM4ZksxTUNOQ1Br?=
 =?utf-8?B?amU1UGJnOUZhZ2FDV3AxbURSSjd0WDBjTlhNRkFEYTRBbHkrWkV6ZUJkWEF1?=
 =?utf-8?B?T2I1SThRRC9VWTQrSGZ0cEgvVmszTDg2NW4rTm5IdXFBYm1rUFVic3doOFJW?=
 =?utf-8?B?M056MWZ6cGMxb29vNEpkWmFwdzcxZGdqV2VmdzF0c2c1MFNUcUQrdXVOZVIr?=
 =?utf-8?B?azl0REhmSTd0VU5SK2hlQnY4YjdwcWJqYjdOMU9WUVZVRUZBYzFrZ1VGYUJm?=
 =?utf-8?B?emNDU2tXSEtlWkxSendER0tNS2U2aW1RcXRSMCtvOUZXTFlDTFAzWGxNbm9v?=
 =?utf-8?B?eXhiQ3lIRlBYRkJMK1MycVV0bnBYcERmVXhyMzc5S3JaNThKcFBEUTJPQncv?=
 =?utf-8?B?NDZ2akVjTW9wMDBoemZ2MlpvbHZEYTZzNzdFVHlCaUJDcE5TQTZCSVIvL2dq?=
 =?utf-8?B?K0ZtcUtUUndpQlhiaGFWcnJ0Y24zWVVLNXBMbkNhQ1ZWN1BkNjk1dXIwaGln?=
 =?utf-8?B?VnFMdDdCR1hFY0Y0bjdwdVNSR3Bkb1lKYy9aRjRvcUxYMDZIL0Z1Q2JMTktq?=
 =?utf-8?B?WWs5ZzNCNFNlQi9LdmhCUFlHeWdHQ211UGp2RUdhOTdzR3JkK01oU1Zyd24z?=
 =?utf-8?B?OWxrNmNhcFZ6dUlGa1BLOVZyUHgxdmx3WEZBc3V2MDhTZjFSQ0tyUXN3YTRS?=
 =?utf-8?B?TTlUTHl5RXdHRE5qVnRnaHYwa1RGMFVaZjJ3R2lSV3ZXTFA0cnh0THRBS0hu?=
 =?utf-8?B?U0pMcEkxZnBKYnRaNW00am5oMFNBMjlVZ0RXeEpXeHhWRFM5U1VHbmF1RkJr?=
 =?utf-8?B?RTBjYnZ2TVkySHc4eTJjNmxLNVF1SEptbTUxT0VzWGhOQzQ0SW9OSmpBU0Nz?=
 =?utf-8?B?ZkJoL3BmZEdBb3pyNVp6L004VGdXdjVQdmlXS0JFY1cvZit2RE1sdjFSUk9n?=
 =?utf-8?B?NkJ5eng2eUdSbFBya0Rsa0NoREhkVndkZ2hUaVdPcDlxS2p1YzQrSXQ1akF2?=
 =?utf-8?B?cXgyaXQxOFFBSTFsRzV3VzlTVmFEc0pVOEZ1M3BBQ1VrSTNYa1RNV1JXVi91?=
 =?utf-8?B?MzNuVEhYWXl4Y09Qa0FBSE9tTkZRd1k1ZHUvS3ErUGk2b0J2TGdYVlVlaXpH?=
 =?utf-8?B?ajI1VXdpTU1IaGtOZDNyekRQTncxbWp0cnlsaWJtMTd3d012cDhOTGxscGh3?=
 =?utf-8?B?ay9leHcxQzFMdnR6aGt6VEtHY2UydGxMVDVqR3U4VjE0MXNmY3d6KzFHNEhO?=
 =?utf-8?B?dFJKYjVoWm1XbkhsMDhDUVJHc09sUE1hQ1dXK3dqTlJLZW1NdEFYVzR6S1lB?=
 =?utf-8?B?cXNaQXVLd29GMHZQQWI1K3R2YTdxMU5tdFRqK2Vad2lkTFpMVW5SWDFKdnlv?=
 =?utf-8?B?OGVsQVZQVkRZSlJ6aDJoeGxLc1VWWWQwbVl5c3M0YWlIclZPMHFMNzdRYjhZ?=
 =?utf-8?B?eFUxM1g4RUZRdzNUTlFOU3dhSHgzVks1eTdXNFR0bGhOaGJlYlZWRmJKMXR0?=
 =?utf-8?B?SzlIRXlBV3VmdDJxejhjS094REtUNlZjN014RjhPOGdGNThSN0NVSmhCd3pI?=
 =?utf-8?B?VllXOFZVVWdrbHh6SFZyZEI4QW9VR085TDFabDJRUGRJMlBxRG56M0ZXNjlC?=
 =?utf-8?B?eEdRejRpRHpOSTl4OGJEcExHNHVJYlU0TnhGakJBb3dKVW9QckVJWjVPNEtH?=
 =?utf-8?Q?xYNRGPLGVpLML3kHcWQGUTplU?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 244416c4-758f-4ac9-3439-08dbd4604fd1
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 07:10:32.5858
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a5M+H9dDlfw1B6Rsr8rQ8rHQFEeS69QfxeEtGeVGUZJUEFnofgfhAKwj+wyAK5yL9p1ywkoeGowOxaLLrAnXrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8138
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 24 Oct 2023 00:10:52 -0700 (PDT)

Hi Huge,

On 10/24/23 14:38, Hugh Dickins wrote:
> Since mm-hotfixes-stable commit dc68badcede4 ("mm: mlock: update
> mlock_pte_range to handle large folio") I've just occasionally seen
> VM_WARN_ON_FOLIO(folio_test_ksm) warnings from folio_within_range(),
> in a splurge after testing with KSM hyperactive.
> 
> folio_referenced_one()'s use of folio_within_vma() is safe because
> it checks folio_test_large() first; but allow_mlock_munlock() needs
> to do the same to avoid those warnings (or check !folio_test_ksm()
> itself? or move either check into folio_within_range()? hard to tell
> without more examples of its use).
Checking folio_test_large() here looks fine to me now. If KSM could support
large folio in the future (Not sure whether this will happen in the future),
we could revise.

> 
> Fixes: dc68badcede4 ("mm: mlock: update mlock_pte_range to handle large folio")
> Signed-off-by: Hugh Dickins <hughd@google.com>
Thanks a lot for catching this issue and fixing it.

Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>