Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp1710822rda; Tue, 24 Oct 2023 00:20:38 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGV/XpLMW92Rf4va+ckcua1t2ee1MrNAVTX6uBA03mnHNhRubzuvCFrzwjAc6xK1rYH5mf3 X-Received: by 2002:a05:6a20:8f0d:b0:14e:509:1d7b with SMTP id b13-20020a056a208f0d00b0014e05091d7bmr2002818pzk.8.1698132038521; Tue, 24 Oct 2023 00:20:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698132038; cv=none; d=google.com; s=arc-20160816; b=wTAjy/GR4MHYQ5Tcgh7UpZTfnXvsypMboswOwkeRd/YrsnuG5ZRep+x8fsL5T+xAon UQxQby+Citl0i0hU+y1yCyM+FvqQOv8S9J1YMl7JcnCt14i8yQPYbc1tVzlHPdTsgSaj XmUbfdh3eBBwJ4t/dzMAw86hKJh3lBLa4xtWJsfR44tFrPLjo8aq//m4bF65WIRqbz/O UK16PL4X0XaO6pBDDAdAlNv1nhr/WRv/tXx5WXbFRUpIaeYNtn7+ANspRzQ2A/Hnwn6U 0OrPvGD/6w+oFXI+asvqPNdN7UAPtoF8iKbxc2C49e2molpgthC2aExJ4Zg4FXp5fODt sxSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=0Y1x3dap5k1CC/+tZIYzrFoTRq1BFtPEC8GkhLPmkgs=; fh=6zfQWYT84uMUkZK3d7KMOA01GAZ2SsielBpfOQKQ1Y4=; b=kC8mX2LHrkxMLDZRhXlb00WqVGL8Ub8lCzYKVa0jhUvmQN9UvOUTk8eA+7l1XzPBm1 esb21WLvyd7npnwqCwi9cnSgcdddRnuBcEQhHW5kGlkJX6SZTOYnBr43a31bS3dSHWVN Eo142qIvqP7/hVEEUbSk2te6RvuNWniWSmzhV75GBjoAd4tAqMZF4npt3+euKwefg4VE JNUntro1Y78ZDj4TKWfkZctxDYnwp61fb+th3XT4HOio3ywAaJyZNpzQR2nVSgQFseIZ ZkVCH/2M54jx6Ctw9dbSBRphvieOCvpHovF7ls/3af1j2rveTb5ObaggMxY5f37Uyz9X q76A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l7bVa0LL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id lr11-20020a17090b4b8b00b00277630078f9si8377285pjb.12.2023.10.24.00.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 00:20:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l7bVa0LL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 3F8168067E22; Tue, 24 Oct 2023 00:20:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232772AbjJXHUK (ORCPT + 99 others); Tue, 24 Oct 2023 03:20:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232420AbjJXHUI (ORCPT ); Tue, 24 Oct 2023 03:20:08 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 695B712B; Tue, 24 Oct 2023 00:20:06 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 027F5C433C7; Tue, 24 Oct 2023 07:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698132006; bh=60uKQEnj+93gHj83QGt3xD3fa/pnl7xAR/0kIcMK5Ho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l7bVa0LLh1mM6loLdouR/d1wOr/VFp+xdHbHGUmM1PZIyK6TmAQvUKAOo+okCrANL xDuvbDhSsKgfAS7NodEIXCmt8W3GhHj5whbbBktaOI2ocYfyGbTlsE4pgenKjKJt9V ujbSfC5+46qmFgJNO9OREmyVm79QVdnq8G0ymY6mnMwFj/SJ/OhLMflhyf2iVKpDjY KEdiRjWK1OZdosQdOmzFppLRP3X3CpcFMLpdh7vRzhCzQWdA8M1kdxHzPL70aXwo0s E2iDQPBwF0FiNt6igJvdXHXYV6tEqDgBjkfLdR6PTMHoPIVxBpe51okiuAfmPW6QLc qiS1+MhFcBPrg== Received: from johan by xi.lan with local (Exim 4.96) (envelope-from ) id 1qvBi9-0003gD-34; Tue, 24 Oct 2023 09:20:22 +0200 Date: Tue, 24 Oct 2023 09:20:21 +0200 From: Johan Hovold To: Krishna Kurapati PSSNV Cc: Thinh Nguyen , Greg Kroah-Hartman , Philipp Zabel , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Felipe Balbi , Wesley Cheng , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com, quic_jackp@quicinc.com, ahalaney@redhat.com, quic_shazhuss@quicinc.com Subject: Re: [PATCH v13 09/10] arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB ports Message-ID: References: <20231007154806.605-1-quic_kriskura@quicinc.com> <20231007154806.605-10-quic_kriskura@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 24 Oct 2023 00:20:18 -0700 (PDT) On Mon, Oct 23, 2023 at 11:12:40PM +0530, Krishna Kurapati PSSNV wrote: > On 10/23/2023 9:53 PM, Johan Hovold wrote: > > On Sat, Oct 07, 2023 at 09:18:05PM +0530, Krishna Kurapati wrote: > >> + usb2_en_state: usb2-en-state { > > > > No need to include '_state' in the labels. > > > Any specific reason ? I have no problem if removing the suffix but just > wanted to know the reason. For consistency with the rest of the sc8280xp devicetree sources (including this file) where we've used that pattern (e.g. as reproducing "state" in the label is mostly redundant). For example: pcie2a_default: pcie2a-default-state {} and nvme_reg_en: nvme-reg-en-state {} Johan