Date: Tue, 20 Nov 2007 15:14:04 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: trenn@suse.de
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
       Bjorn Helgaas <bjorn.helgaas@hp.com>,
       Rene Herman <rene.herman@keyaccess.nl>,
       "Li, Shaohua" <shaohua.li@intel.com>,
       "yakui.zhao" <yakui.zhao@intel.com>, akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access
 resources in the pnp resource table
Message-ID: <20071120151404.4332d0d4@the-village.bc.nu>
In-Reply-To: <1195568360.23700.202.camel@queen.suse.de>
References: <1195552283.23700.166.camel@queen.suse.de>
	<20071120123102.03bdaa67@the-village.bc.nu>
	<1195568360.23700.202.camel@queen.suse.de>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 807
Lines: 19

> At the end is some example code how things could get even more cleaned
> up. It shows how I think pnp layer and one example driver would get

Your example adds rather than removes code.

> If this is not an option, please advise how to move on here:
> Still use struct resources for dma and irq, but just do not name it
> _start, but name the macro pnp_irq_no?

Is it actually even worth changing in the first place ? You seem to be
complicating the code not simplyifying it, and at the end of the day
ISAPnP is obsolete and BIOS PnP is obsoleted by ACPI

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/