Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <887636af-6be7-f418-bfa4-d85501f2f40c@intel.com>
Date:   Tue, 24 Oct 2023 11:15:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] checkpatch: allow tags between co-developed-by and their
 sign-off
To:     Sean Christopherson <seanjc@google.com>
CC:     Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Lukas Bulwahn <lukas.bulwahn@gmail.com>,
        <workflows@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, <linux-doc@vger.kernel.org>,
        Jacob Keller <jacob.e.keller@intel.com>,
        "Mateusz Polchlopek" <mateusz.polchlopek@intel.com>
References: <20231023102846.14830-1-przemyslaw.kitszel@intel.com>
 <ZTZ9Bk3-NrK_cVDu@google.com>
Content-Language: en-US
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <ZTZ9Bk3-NrK_cVDu@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZjJiUC9Ra0ZieDBOWDY1dzVrZmhQc2pNaTZPWUdUOEVoWDZrMktXODZpaWhy?=
 =?utf-8?B?cmliR0hBVVVrNURUUTFQeGFSUklTbDVVb3MwZHhvdG91OGhvczFtWUZ1ZFdh?=
 =?utf-8?B?aGhXeklISHVXWEV4MGxSMDNVNmQ0UXNpaUlRU2ZZUVp2MkdTcUVucE40c2Nz?=
 =?utf-8?B?VnFnYnNTeWo2MEo0WDFPVWpzcyt1RFliYzU5NUVJY05RSUUxQXNSbzVpeTU2?=
 =?utf-8?B?UlhPRWkvWDBDL3ZxSWZTQi8waExzVDR6SDRHMEh6eUF3aWczb0M0aHMrVnRz?=
 =?utf-8?B?WXpPVG13a0xWVllHckNwSWNGUUNhSHlYc0RWNWRPZHpkTUFIUmVKcCs0Qmdq?=
 =?utf-8?B?M2hkakRpKzhqV2d0dGFSbkRZN0VCTXpyYnNPWTNlQ1lReGNkQTc0RmI3OTlN?=
 =?utf-8?B?cjM3RW5wN3VGK3JnbjhDTEhuU2FnaCs1ZS8veFdKZWRBeW4wR2VXZysyQnNt?=
 =?utf-8?B?VzRqNFE2RERVODhKODl1NzFkM2NJTEY2Z1JheXFqTWR5T1VtK053QVBzM3hO?=
 =?utf-8?B?VEptNUdsSldJOXhJbHpES1JOWnZUTjdiQ0RZY0dDV0daWkNHc05CTDJsNTho?=
 =?utf-8?B?SW5iVlZzeFVDTXQ5TXo5RzY4RytHOTk5MUd5UmtZL2pOUHVweE1VU3Ywa1VF?=
 =?utf-8?B?b3lxNlVtTmlSRW0vS3FrSWxMVE42U0JheGJyYk5LbkNLZ2pQL0o2NmRETkE4?=
 =?utf-8?B?aFl3UjNoZGNKT21ZbTlTZ05HUUk5WDErOFJ0dlBucTY3S2ZZSS9NUHRtWXVx?=
 =?utf-8?B?OUQraDl4UzFRYUVEd0taSGhZQ3lxTXhuN0ovWG1kUkFHa2R5dE9KNzFtOU1q?=
 =?utf-8?B?aUxlVWI5aG15NERqS3dTbnYrNHRsYUNqYkJGSUY0bEF3RjhaZUtFV2tHWFZs?=
 =?utf-8?B?ZzZXbE1GZjZ0RmNLQ05qQkdSb1lreVlzVS95cTlLVVBhalZJRDh0YjFRWUxm?=
 =?utf-8?B?bXZlZmR6TlQvR3psVkV4amo1blRCU3JHOGlyZEJ2NHpvREtvVkJOYW5EK3cr?=
 =?utf-8?B?NklaUXNHWmRTT1drOHNjU1QrNmpJMzNGczBDMytjT3V2ZzJMTjJDV1ZnNml4?=
 =?utf-8?B?eFl6T1NTaWQyTDNRUlNpTnhTM1EyVnF2K3Z1RnNrQ2Q4Z3dpYVkwTlBVRGRy?=
 =?utf-8?B?SzlOUTBkQldRS05DMlNVb1hBMzhtRW9DYVZ2czVYRGM2RzFQazEzMDBNQ0Nk?=
 =?utf-8?B?a1FjL2dhMW95U3YwQkdkdmo0NUhCd1NMUE1EY1lTM002MS85cTR4MFVFUXF5?=
 =?utf-8?B?Zms3RnhOMUtCUWN2UnZVVkRRWVMweHk3VFcrOTR4TXBqYmlBQVFlZEtCZXpB?=
 =?utf-8?B?SnNaSlVHTDFQdytKNW9GVzJGYXlmanlveEMwYlYyK1lkNzRwSTlrRXc2UVZS?=
 =?utf-8?B?bEVjNHhCRjlaWWhIN2R2L0JIQ2MxTDk3SFFKSGpMazkzalF0ejJuN2xCVExv?=
 =?utf-8?B?QnFxeDIyeEJNQU1IWkhqd2JJUU1aQ081R2xjU3Y4Q1ZPTGtVbkQvNG54b1N1?=
 =?utf-8?B?R0pNdGRNVXlhV1NHM3RWdU15emFaby9yL21SdkcwZmtIU2YraVFzSFdTZlFE?=
 =?utf-8?B?eHVWSDd6cHdvWHNNOHBXTlJOTTJNVktQRGFrRU1pLzhmYk5XNVc1UE5GMlZa?=
 =?utf-8?B?NlV2dXpBOE9BRVRDcXpMN3Y3dWs4aVIrUllPb1pxL0dZZVZVdUsvOFlJUEFC?=
 =?utf-8?B?NnljajhOc0lkT1VtckM4d3dVb1pxZjVmcTVoK2NkTlBwdlRNeXBRT3VLNzFx?=
 =?utf-8?B?R1Q3WXVSaE15RXMwam1OUE5zR3g2UHV4c2RMcG8zOHI4Q3ZRYnhpbDQ5NWdE?=
 =?utf-8?B?QWp0OWpRUGVRUHpuTlQ3dEZmWXRqaS83WDMvZkVUci9rRHBIOW1mN014ZnZE?=
 =?utf-8?B?dExPcVpBSGErTld5eWg0SzlJZXNJVGMvMFc0eTJOQ1hsWUFZaTU2eUUwb3Nh?=
 =?utf-8?B?UGkxVExSbmV4aHd0QW1Kekk1VE1ZZGhRdk01M3QxMnVvN1BIaEFnRkV0cnA1?=
 =?utf-8?B?N0pMZmcvK3luMWtKYk51ZnJVNDUxeFhqSCsrVGV2ajJXd1ZyRm1ML3lhbDdu?=
 =?utf-8?B?MlFDRXdUb2JLZytMaXRqeEFHOFhueTVNYXIwSVU4V2UyNkFhRUFXcGNEQUdN?=
 =?utf-8?B?cTVhZWNmMjBaWlBFdGU0VUlpaFhpVXF2Ujd6Q1hYeE1xUUlVeWFTa0NwOUpi?=
 =?utf-8?B?MVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b0049868-4e6e-42f7-c629-08dbd471d41a
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 09:15:55.9568
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2gOB15IH9HL7faxfmgdg9w1GuUO1LfpOyG4fcWqWHpOUoKD7GeiiUWWdTKAGYo9Q0lyO9PR2jFq01yDjS1jrmZK3xVXgNtOIPm+CUZaU+3k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7049
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 24 Oct 2023 02:16:12 -0700 (PDT)

On 10/23/23 16:02, Sean Christopherson wrote:
> +Mateusz
> 
> On Mon, Oct 23, 2023, Przemek Kitszel wrote:
>> Additional tags between Co-developed-by and corresponding Signed-off-by
>> could include Reviewed-by tags collected by Submitter, which is also
>> a Co-developer, but should sign-off at the very end of tags provided by
>> the Submitter.
> 
> ...
> 
>> Mateusz Polchlopek <mateusz.polchlopek@intel.com> has reported this to me.
> 
> Heh, there's a tag for that...
> 
>    Reported-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
> 
> And it's usually a good idea to Cc the reporter in case there are questions they
> can help answer.

Heh ;) then I would get a checkpatch warning for not providing Link: to
the report, somehow I wanted to avoid those for checkpatch contrib :)

> 
>> @@ -509,16 +509,18 @@ Example of a patch submitted by the From: author::
>>   	Signed-off-by: Second Co-Author <second@coauthor.example.org>
>>   	Signed-off-by: From Author <from@author.example.org>
>>   
>> -Example of a patch submitted by a Co-developed-by: author::
>> +Example of a patch submitted by a Co-developed-by: author, who also collected
>> +a Reviewed-by: tag posted for earlier version::
>>   
>>   	From: From Author <from@author.example.org>
>>   
>>   	<changelog>
>>   
>>   	Co-developed-by: Random Co-Author <random@coauthor.example.org>
>>   	Signed-off-by: Random Co-Author <random@coauthor.example.org>
>>   	Signed-off-by: From Author <from@author.example.org>
>>   	Co-developed-by: Submitting Co-Author <sub@coauthor.example.org>
>> +	Reviewed-by: Some Reviewer <srev@another.example.org>
>>   	Signed-off-by: Submitting Co-Author <sub@coauthor.example.org>
> 
> This is silly.  Allowing tags in-between Co-developed-by with Signed-off-by
> unnecessarily complicates things, e.g. people already miss/forget the rule about
> tightly coupling Co-developed-by with Signed-off-by.

Meh, I see that as a pure process simplification with proposed rule
being almost the same as the current one, thus as easy to remember or
forget.

> 
> And if we're being super pedantic about chronological history, arguably the
> Reviewed-by should come before the Co-developed-by as adding the Reviewed-by is
> a (trivial) modification to the patch that was done by the submitter.

Tagging patches is not considered co-development by most people.