Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <9c7f1643-2384-e458-23c1-8cd2326bcbf4@intel.com>
Date:   Tue, 24 Oct 2023 11:15:48 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH] checkpatch: allow tags between co-developed-by and their
 sign-off
Content-Language: en-US
To:     Lukas Bulwahn <lukas.bulwahn@gmail.com>
CC:     Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>,
        Dwaipayan Ray <dwaipayanray1@gmail.com>,
        Sean Christopherson <seanjc@google.com>,
        <workflows@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>, <linux-doc@vger.kernel.org>,
        Jacob Keller <jacob.e.keller@intel.com>
References: <20231023102846.14830-1-przemyslaw.kitszel@intel.com>
 <CAKXUXMyOk+06ZRc7gvYMA=KHvZZp1FXiCJC5Tp9M=SUQfQnBVQ@mail.gmail.com>
From:   Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <CAKXUXMyOk+06ZRc7gvYMA=KHvZZp1FXiCJC5Tp9M=SUQfQnBVQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFh3dXV6YldmYkNaYXVYMHhPZVVGeFRBMnBiYVZmYzJvQnR1UEhWMGhCbURR?=
 =?utf-8?B?R0RqSWNLamo2WExxL1dGWEhEcHYvbjlBbVdsNlNzcVo0NzNLTCt3UFBjUWdP?=
 =?utf-8?B?dEQ1VTdrVmNSdjZ3Tm9QOEUvSWpiV3dPcldYUUFOTUFXbUsycnNBRDlZWUN2?=
 =?utf-8?B?Q3ZBd1JJSGVvbG1OcmwySkJ1SU1FeFp2RGJxV1BTNHBWSkRhQzVNTkNPdUg2?=
 =?utf-8?B?dkVBU3p3SzJkbGtQczFwRmJRdk9WUjkxbUtIckNQeW1wQURPU0pKM1dXVFRU?=
 =?utf-8?B?cmJGSk5GTmVUSmdKSGc1VUl2bDNGdGZyVStCRjN0YXh6d2RsU1IxN1MxcjEw?=
 =?utf-8?B?b1hNbTZrSnJuUzVsR3dVdzJiUE9IeVRWMGZzc0R6SXdvNlVlN3hXckhieTlt?=
 =?utf-8?B?UDhEd29RU1ovRG5ZbTh0dFlaRFUyTEFqcHJ0akhuZ2tkTjhDbG8veDRyVGhu?=
 =?utf-8?B?a3Bkbjh6SHVCRUJrb3Vnc1o2bjRiMVgydUNvdDZYTWN2RWtKUE05SkFUMk1u?=
 =?utf-8?B?dVpzUTl0bzFQMUR6bzBSZDl6STc3TjlBRlhrc3lLRkN4bmticm5pSXB5aUpl?=
 =?utf-8?B?dHNqTzRReEJlNTdHd0VveS9HM1VqOHhaN21ZdC9zTmhkc1VHVGQ0eUZ1Rnd0?=
 =?utf-8?B?T3lJd0Q2d245WDFPblNYaEhiWlA1aCtpYnY1S2xoUG1kUWxBdVE2SWpMZDBX?=
 =?utf-8?B?Wi90YkU5VmlMR1p6WGFLT1dRdzFwYUFSc3ZjZlJqdmVzNVgyZlF3WGE4dUVI?=
 =?utf-8?B?TkF5QkE4dk00TlFxNEdaMDRObVhEVHRGZnVwbDY1eVdFNmx6V3U4eTV4bHp6?=
 =?utf-8?B?cEw5cFdTandJelp1VDBCZlB4QTdmcFdkdGlHR3M5ZWFYNEtZUmtHazFOdWll?=
 =?utf-8?B?eDNuU3g2T3lEeWQ1Vm1ZU0RkWEg4dHJPTkt6cTRBYzlwalh5Q3BPZlFtRmNu?=
 =?utf-8?B?Z0F3UmpweFcvNHFiMXdOOWNzcW56WUgxNk5oTnlaM0k1RUJoMjdlWlJ2UDd2?=
 =?utf-8?B?R3RGcnNuYmhGS2pkdDJiNnFiNjE4b1JZYVdUU2J3Ryt1anZlUWg1bEU1bmE5?=
 =?utf-8?B?MENWK29FTzhuY01HT2dSZTdEREY4UFBndVpXNEZPbmRvdW5CQWQ1b1VuSEpE?=
 =?utf-8?B?eVhDeVYzdGhkdW1RdVRxcS81dm1MWjRuZTZSekdxaExXcitGL2xWL3VWbmxW?=
 =?utf-8?B?THJuVVlVQ1BGVUxLbFFIK2NieFM0NUx3UW5IWHFkZEZ3Y0pqbmlCdjR3SC9D?=
 =?utf-8?B?amNhRWRSNGVvWHlQNkoxUUxBeFA0ZjN6c2l1NlhSRlBvRlgxdWY1YzhLelY1?=
 =?utf-8?B?aG1kOXlGZ0hzRVNpQlZhNlQ2dGFTaExoN1hYOFBWQmpKN3NkYXVlS1FJTzRM?=
 =?utf-8?B?THRNR2Y1TGxNais2SkNBVVZ1SGFtWjRTQjBiN01sNTVRclhpZ1BuaWVoSnFj?=
 =?utf-8?B?RFR1NVRoNGJGYXNueVpLQWpRd0kwOVhpZC9NN1VGdEtGaFZKY0hTbjRkbWsr?=
 =?utf-8?B?VFNpaW9lekJlcU50UTlyNFo0QW0zei9EdENxdFY5YXBVNlNSenMrOXRRSHNL?=
 =?utf-8?B?SXNIeVpBZ3NHcGhSdVFqQVJBL0JaZ1JMTFkxWFZkeHNJZE1kQ2lXejBnYUlU?=
 =?utf-8?B?dkQxSzJBamthVndGbFB5UCs1M1haczd0K3lRb0hSZ2I1WEFONlFZdmdWMjRE?=
 =?utf-8?B?UXVleHFTZkFMSnhHYUxuaHVKendqaXdQK0F6UXNDdVE5SWc5R01va3o5bHFm?=
 =?utf-8?B?SFRFd3RkMXo3MUZQSWFiTnJTS1N0dzlJOTlKOGtXM3l1Q245OEdiVXE5U3Ru?=
 =?utf-8?B?d2FxcEN1dm9VM2orTjQ5dXR0QUN4c3gxY2tjVGVnQ0IrUXFSbkNWVEUwa0Vs?=
 =?utf-8?B?aElNYTZFWVpNMjBVS3BxZGZrV1dNMm5ZRWVxb0FFbGVlL1RLOTgzUTV0WEx3?=
 =?utf-8?B?cEpNWnlTb3VWbER0Y0xrcUlYTHphY0NlN2kxdTg0a1lmb2d1L2hxZUIwQ2lK?=
 =?utf-8?B?K3UwV2VtRmlOVit0Y2txT0lUUk9UWHd1cVV0ZHdVVkY3N3dkUTFldzhPQytF?=
 =?utf-8?B?RWQzTTJaTGo5OGZwYTZsOFNWUzlOSFN3MW9XdGlKQUJ5QzlPdW1nQzFVVElP?=
 =?utf-8?B?bXpYQm9lUHcyaDNMU0paN25RakxjTHNVNnNwbytqOUVCWFV3YnVJWDZ0Z2dz?=
 =?utf-8?B?UlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c48c5417-a687-4d31-8ad1-08dbd471d41f
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3672.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 09:15:55.9785
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Jg6bsf6me2AgfUlJzjVM/FvtfwHKSnJTzoEDKk2fyGmnvElftiVtEIiiiK/OFmzFpyL8Gou8H1BjVEprlqmgyKNoQldomCrcYQ3TpEb/DqI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7049
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 24 Oct 2023 02:16:30 -0700 (PDT)

On 10/23/23 16:16, Lukas Bulwahn wrote:
> Hi Przemek,
> 
> On Mon, Oct 23, 2023 at 12:29 PM Przemek Kitszel
> <przemyslaw.kitszel@intel.com> wrote:
>>
>> Allow additional tags between Co-developed-by: and Signed-off-by:.
>>
>> Removing the "immediately" word from the doc is a great summary of the
>> change - there is no need for the two tags to be glued together, barring
>> ease of checkpatch implementation.
>>
> 
> I think the currently suggested process of keeping Co-developed-by and
> Signed-off-by glued together is good, and I see no reason why this
> should be changed, nor do I see any drawbacks.
> 
> 
>> Additional tags between Co-developed-by and corresponding Signed-off-by
>> could include Reviewed-by tags collected by Submitter, which is also
>> a Co-developer, but should sign-off at the very end of tags provided by
>> the Submitter.
>>
> 
> The other tags, Reviewed-by, etc., can go anywhere just not between
> Co-developed-by and corresponding Signed-off-by. So, why do you have
> this need to put it exactly there rather than putting it anywhere
> else?

Multiple times during review it was odd for me to look at thw SoB of 
submitter not being the last thing, and that's the result of the current
rule - co-dev authors put collected RB as last thing, only to keep their
CdB and SoB together.

> 
> The commit message tells me what you are proposing, but there is no
> rationale in the commit message and that is put up for discussion here
> with the proposed change.
> 
> I see many potential areas of work for the checkpatch script, but in
> my humble opinion, this really is not one of the rules that needs to
> be improved.

I started the other way, identified what was pissing me off, then tried
to fix that, despite of requirement of writing in perl.

> 
> Lukas
> 
> (...snipped the rest...)