Return-Path: <linux-kernel-owner+w=401wt.eu-S1760738AbXKTPqM@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760738AbXKTPqM (ORCPT <rfc822;w@1wt.eu>);
	Tue, 20 Nov 2007 10:46:12 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760473AbXKTPoK
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Tue, 20 Nov 2007 10:44:10 -0500
Received: from g5t0006.atlanta.hp.com ([15.192.0.43]:5023 "EHLO
	g5t0006.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759643AbXKTPnv (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 20 Nov 2007 10:43:51 -0500
X-Greylist: delayed 475 seconds by postgrey-1.27 at vger.kernel.org; Tue, 20 Nov 2007 10:43:51 EST
Subject: Re: [PATCH 4/6] Have zonelist contains structs with both a zone
	pointer and zone_idx
From: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
       linux-mm@kvack.org, rientjes@google.com, nacc@us.ibm.com,
       kamezawa.hiroyu@jp.fujitsu.com, clameter@sgi.com
In-Reply-To: <20071109143346.23540.69776.sendpatchset@skynet.skynet.ie>
References: <20071109143226.23540.12907.sendpatchset@skynet.skynet.ie>
	 <20071109143346.23540.69776.sendpatchset@skynet.skynet.ie>
Content-Type: text/plain
Organization: HP/OSLO
Date: Tue, 20 Nov 2007 10:34:53 -0500
Message-Id: <1195572894.5041.19.camel@localhost>
Mime-Version: 1.0
X-Mailer: Evolution 2.6.1 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2747
Lines: 62

On Fri, 2007-11-09 at 14:33 +0000, Mel Gorman wrote:
> Filtering zonelists requires very frequent use of zone_idx(). This is costly
> as it involves a lookup of another structure and a substraction operation. As
> the zone_idx is often required, it should be quickly accessible.  The node
> idx could also be stored here if it was found that accessing zone->node is
> significant which may be the case on workloads where nodemasks are heavily
> used.
> 
> This patch introduces a struct zoneref to store a zone pointer and a zone
> index.  The zonelist then consists of an array of this struct zonerefs which
> are looked up as necessary. Helpers are given for accessing the zone index
> as well as the node index.
> 
> [kamezawa.hiroyu@jp.fujitsu.com: Suggested struct zoneref instead of embedding information in pointers]
> Signed-off-by: Mel Gorman <mel@csn.ul.ie>
> Acked-by: Christoph Lameter <clameter@sgi.com>
> Acked-by: David Rientjes <rientjes@google.com>
> ---
> 
>  arch/parisc/mm/init.c  |    2 -
>  fs/buffer.c            |    6 ++--
>  include/linux/mmzone.h |   64 +++++++++++++++++++++++++++++++++++++-------
>  include/linux/oom.h    |    4 +-
>  kernel/cpuset.c        |    4 +-
>  mm/hugetlb.c           |    3 +-
>  mm/mempolicy.c         |   35 ++++++++++++++----------
>  mm/oom_kill.c          |   45 +++++++++++++++---------------
>  mm/page_alloc.c        |   59 ++++++++++++++++++++--------------------
>  mm/slab.c              |    2 -
>  mm/slub.c              |    2 -
>  mm/vmscan.c            |    7 ++--
>  mm/vmstat.c            |    5 ++-
>  13 files changed, 145 insertions(+), 93 deletions(-)
> 
<snip>
> diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.24-rc1-mm-010_use_two_zonelists/kernel/cpuset.c linux-2.6.24-rc1-mm-020_zoneid_zonelist/kernel/cpuset.c
> --- linux-2.6.24-rc1-mm-010_use_two_zonelists/kernel/cpuset.c	2007-10-24 04:50:57.000000000 +0100
> +++ linux-2.6.24-rc1-mm-020_zoneid_zonelist/kernel/cpuset.c	2007-11-08 19:18:27.000000000 +0000
> @@ -1877,8 +1877,8 @@ int cpuset_zonelist_valid_mems_allowed(s
>  {
>  	int i;
>  
> -	for (i = 0; zl->zones[i]; i++) {
> -		int nid = zone_to_nid(zl->zones[i]);
> +	for (i = 0; zl->_zonerefs[i].zone; i++) {
> +		int nid = zonelist_node_idx(zl->_zonerefs[i]);

Should be:
 +		  int nid = zonelist_node_idx(&zl->_zonerefs[i]);
                                              ^
else doesn't build.  Stand by for testing...

>  
>  		if (node_isset(nid, current->mems_allowed))
>  			return 1;
<snip>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/